August 2006 - slime-devel - mailman3.common-lisp.net

[slime-devel] Removing some allegro warnings
by Gary King 07 Aug '06

07 Aug '06

The patch below wraps #'excl:without-redefinition-warnings around a number of forms that cause allegro to complain... Any comments? Index: swank-allegro.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank-allegro.lisp,v retrieving revision 1.89 diff -u -w -r1.89 swank-allegro.lisp --- swank-allegro.lisp 28 Jul 2006 15:04:53 -0000 1.89 +++ swank-allegro.lisp 7 Aug 2006 14:32:44 -0000 @@ -28,8 +28,9 @@ ;;;; TCP Server +(excl:without-redefinition-warnings (defimplementation preferred-communication-style () - :spawn) + :spawn)) (defimplementation create-socket (host port) (socket:make-socket :connect :passive :local-port port @@ -64,40 +65,48 @@ (setf (stream-external-format stream) (find-external-format external-format))) +(excl:without-redefinition-warnings (defimplementation format-sldb-condition (c) - (princ-to-string c)) + (princ-to-string c))) +(excl:without-redefinition-warnings (defimplementation condition-references (c) (declare (ignore c)) - '()) + '())) +(excl:without-redefinition-warnings (defimplementation call-with-syntax-hooks (fn) - (funcall fn)) + (funcall fn))) ;;;; Unix signals +(excl:without-redefinition-warnings (defimplementation call-without-interrupts (fn) - (excl:without-interrupts (funcall fn))) + (excl:without-interrupts (funcall fn)))) (defimplementation getpid () (excl::getpid)) +(excl:without-redefinition-warnings (defimplementation lisp-implementation-type-name () - "allegro") + "allegro")) +(excl:without-redefinition-warnings (defimplementation set-default-directory (directory) (let* ((dir (namestring (truename (merge-pathnames directory))))) (setf *default-pathname-defaults* (pathname (excl:chdir dir))) - dir)) + dir))) +(excl:without-redefinition-warnings (defimplementation default-directory () - (namestring (excl:current-directory))) + (namestring (excl:current-directory)))) ;;;; Misc +(excl:without-redefinition-warnings (defimplementation arglist (symbol) (handler-case (excl:arglist symbol) - (simple-error () :not-available))) + (simple-error () :not-available)))) (defimplementation macroexpand-all (form) (excl::walk form)) @@ -129,8 +138,9 @@ (:class (describe (find-class symbol))))) +(excl:without-redefinition-warnings (defimplementation make-stream-interactive (stream) - (setf (interactive-stream-p stream) t)) + (setf (interactive-stream-p stream) t))) ;;;; Debugger @@ -578,14 +588,15 @@ (when doc `("Documentation:" (:newline) ,doc)))))) -(defmethod inspect-for-emacs ((o t) (inspector acl-inspector)) - inspector - (values "A value." (allegro-inspect o))) - +#+(or) (defmethod inspect-for-emacs ((o function) (inspector acl-inspector)) inspector (values "A function." (allegro-inspect o))) +(defmethod inspect-for-emacs ((o t) (inspector acl-inspector)) + inspector + (values "A value." (allegro-inspect o))) + (defmethod inspect-for-emacs ((o standard-object) (inspector acl- inspector)) inspector (values (format nil "~A is a standard-object." o) (allegro- inspect o))) @@ -613,8 +624,9 @@ ;;;; Multithreading +(excl:without-redefinition-warnings (defimplementation initialize-multiprocessing () - (mp:start-scheduler)) + (mp:start-scheduler))) (defimplementation spawn (fn &key name) (mp:process-run-function name fn)) @@ -632,21 +644,26 @@ (find id mp:*all-processes* :key (lambda (p) (getf (mp:process-property-list p) 'id)))) +(excl:without-redefinition-warnings (defimplementation thread-name (thread) - (mp:process-name thread)) + (mp:process-name thread))) +(excl:without-redefinition-warnings (defimplementation thread-status (thread) (format nil "~A ~D" (mp:process-whostate thread) - (mp:process-priority thread))) + (mp:process-priority thread)))) +(excl:without-redefinition-warnings (defimplementation make-lock (&key name) - (mp:make-process-lock :name name)) + (mp:make-process-lock :name name))) +(excl:without-redefinition-warnings (defimplementation call-with-lock-held (lock function) - (mp:with-process-lock (lock) (funcall function))) + (mp:with-process-lock (lock) (funcall function)))) +(excl:without-redefinition-warnings (defimplementation current-thread () - mp:*current-process*) + mp:*current-process*)) (defimplementation all-threads () (copy-list mp:*all-processes*)) @@ -654,8 +671,9 @@ (defimplementation interrupt-thread (thread fn) (mp:process-interrupt thread fn)) +(excl:without-redefinition-warnings (defimplementation kill-thread (thread) - (mp:process-kill thread)) + (mp:process-kill thread))) (defvar *mailbox-lock* (mp:make-process-lock :name "mailbox lock")) @@ -751,8 +769,10 @@ ;;;; Weak hashtables +(excl:without-redefinition-warnings (defimplementation make-weak-key-hash-table (&rest args) - (apply #'make-hash-table :weak-keys t args)) + (apply #'make-hash-table :weak-keys t args))) +(excl:without-redefinition-warnings (defimplementation make-weak-value-hash-table (&rest args) - (apply #'make-hash-table :values :weak args)) + (apply #'make-hash-table :values :weak args))) thanks, -- Gary Warren King metabang.com [http://www.metabang.com/] (413) 885 9127 * (206) 338-4052 [Fax] gwking on #lisp (occasionally)

1 0

[slime-devel] swank format-iso8601-time bug in non-integer timezones
by Bob Halley 07 Aug '06

07 Aug '06

(resending, since I sent this from the wrong Sender id the first time...) In format-iso8601-time in swank.lisp, the following code is used to compute the timezone offset to print: (multiple-value-bind (h m) (truncate (abs zone) 1.0) ;; Tricky. Sign of time zone is reversed in ISO 8601 ;; relative to Common Lisp convention! (format nil "~:[+~;-~]~2,'0D:~2,'0D" (> zone 0) h (round m))) (round m) does the wrong thing in timezones which are not integers. E.g. at the moment I am in Adelaide, Australia, and the timezone is +09:30, which corresponds to a Common Lisp timezone value of -19/2. As written the code prints my timezone as +09:00. Rather than (round m), we want (round (* m 60)). Regards, /Bob P.S. Slime rocks, thanks! :)

1 0

[slime-devel] patch for editing method definitions from inspector
by Earl J. Wagner 01 Aug '06

01 Aug '06

This fixes a problem in the inspector where I'd hit M-. on the method name, then have to choose the method even though the method specializers were right there. Also, the previous patch is for keyword symbol completion. I'm not sure if my first (incorrect) patch was posted to the list or blocked. It it arrives, ignore it. -Earl Index: slime.el =================================================================== RCS file: /project/slime/cvsroot/slime/slime.el,v retrieving revision 1.635 diff -u -r1.635 slime.el --- slime.el 24 Jul 2006 14:01:03 -0000 1.635 +++ slime.el 1 Aug 2006 22:22:03 -0000 @@ -6319,12 +6319,15 @@ (:type list)) dspec location) + (defun slime-edit-definition (name &optional where) "Lookup the definition of the name at point. If there's no name at point, or a prefix argument is given, then the function name is prompted." (interactive (list (slime-read-symbol-name "Name: "))) - (let ((definitions (slime-eval `(swank:find-definitions-for- emacs ,name)))) + (let* ((method-context (slime-extract-method-context name)) + (full-name (if method-context (format "%s" method-context) name)) + (definitions (slime-eval `(swank:find-definitions-for- emacs ,full-name)))) (cond ((null definitions) (if slime-edit-definition-fallback-function @@ -6801,15 +6804,7 @@ ;;a setf-definition, but which? (backward-up-list 1) (slime-parse-context `(setf ,name))) - ((slime-in-expression-p '(defmethod *)) - (unless (looking-at "\\s ") - (forward-sexp 1)) ; skip over the methodname - (let (qualifiers arglist) - (loop for e = (read (current-buffer)) - until (listp e) do (push e qualifiers) - finally (setq arglist e)) - `(:defmethod ,name ,@qualifiers - ,(slime-arglist-specializers arglist)))) + ((slime-in-expression-p '(defmethod *)) (slime-extract- method-context name)) ((and (symbolp name) (slime-in-expression-p `(,name))) ;; looks like a regular call @@ -6829,6 +6824,22 @@ (t name)))) +(defun slime-extract-method-context (name) + (save-excursion + (let ((method-p (when (slime-in-expression-p '(method *)) 'method)) + (defmethod-p (when (slime-in-expression-p '(defmethod *)) 'defmethod))) + (when (or method-p defmethod-p) + (unless (looking-at "\\s ") + (forward-sexp 1)) ; skip over the methodname + (let (qualifiers arglist) + (loop for e = (read (current-buffer)) + until (listp e) do (push e qualifiers) + finally (setq arglist e)) + (if method-p + `(method ,name ,@qualifiers ,arglist) + `(:defmethod ,name ,@qualifiers + ,(slime-arglist-specializers arglist)))))))) + (defun slime-in-expression-p (pattern) "A helper function to determine the current context. The pattern can have the form:

1 0

[slime-devel] keyword symbol completion
by Earl J.Wagner 01 Aug '06

01 Aug '06

Ugh. Here's the fixed patch that works for symbols without specified packages as well. Index: swank.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank.lisp,v retrieving revision 1.387 diff -u -r1.387 swank.lisp --- swank.lisp 24 Jul 2006 14:01:15 -0000 1.387 +++ swank.lisp 1 Aug 2006 19:32:03 -0000 @@ -1270,7 +1270,9 @@ ;; FIXME: deal with #\| etc. hard to do portably. (defun tokenize-symbol (string) (let ((package (let ((pos (position #\: string))) - (if pos (subseq string 0 pos) nil))) + (cond + ((and pos (= pos 0)) "keyword") + (pos (subseq string 0 pos))))) (symbol (let ((pos (position #\: string :from-end t))) (if pos (subseq string (1+ pos)) string))) (internp (search "::" string))) @@ -3089,6 +3091,7 @@ (defun format-completion-result (string internal-p package-name) (let ((prefix (cond (internal-p (format nil "~A::" package-name)) + ((equal package-name "keyword") ":") (package-name (format nil "~A:" package-name)) (t "")))) (values (concatenate 'string prefix string)

1 0

[slime-devel] keyword symbol completion
by Earl J. Wagner 01 Aug '06

01 Aug '06

Hi all, Here is a patch to complete keyword symbols. -Earl Index: swank.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank.lisp,v retrieving revision 1.387 diff -u -r1.387 swank.lisp --- swank.lisp 24 Jul 2006 14:01:15 -0000 1.387 +++ swank.lisp 1 Aug 2006 19:32:03 -0000 @@ -1270,7 +1270,9 @@ ;; FIXME: deal with #\| etc. hard to do portably. (defun tokenize-symbol (string) (let ((package (let ((pos (position #\: string))) - (if pos (subseq string 0 pos) nil))) + (cond + ((= pos 0) "keyword") + (pos (subseq string 0 pos))))) (symbol (let ((pos (position #\: string :from-end t))) (if pos (subseq string (1+ pos)) string))) (internp (search "::" string))) @@ -3089,6 +3091,7 @@ (defun format-completion-result (string internal-p package-name) (let ((prefix (cond (internal-p (format nil "~A::" package-name)) + ((equal package-name "keyword") ":") (package-name (format nil "~A:" package-name)) (t "")))) (values (concatenate 'string prefix string)

1 0

[slime-devel] Problem using paredit mode with REPL
by Ralf Mattes 01 Aug '06

01 Aug '06

Hello list, i'm trying to use paredit-mode in Slime's repl but unfortunately enabling paredit mode results in a dysfunctional repl -- pressing 'enter'/'return' while the pointer is after the closing sexpression only inserts a newline but doesn't send the expression to the lisp process. BTW, i tried both supported types of slime-repl-return-behavior. Cheers Ralf Mattes

2 1