- slime-devel - mailman3.common-lisp.net

[slime-devel] Why is slime breaking READ-SEQUENCE in cmucl ?
by Håkon Alstadheim 08 Mar '04

08 Mar '04

swank-cmucl.lisp contains code which makes cmucl break w.r.t. the ansi cl standard; in that it makes READ-SEQUENCE insist on filling its target buffer. The hyperspec says, in 21.2 under READ-SEQUENCE: If the end of file for stream is reached before copying all elements of the subsequence, then the extra elements near the end of sequence are not updated. swank-cmucl installs its own READ-INTO-SIMPLE-STRING which calls SYSTEM:READ-N-BYTES with the EOF-ERRORP argument true. In addition to being wrong, it does not solve the problem I believe it is trying to solve. At the end of this mail is a patch to remove the buggy version of READ-INTO-SIMPLE-STRING. If this is trying to protect against truncated reads, I believe the solution is to run a loop (possibly with a timeout) until the needed bytes have been read from the socket. If I am mistaken, then the assertion that is already there should suffice, making SYSTEM:READ-N-BYTES throw an error gives us nothing extra. Something like the followint patch would make swank.lisp more robust against slow networks: Index: swank.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank.lisp,v retrieving revision 1.137 diff -u -r1.137 swank.lisp --- swank.lisp 5 Mar 2004 22:51:12 -0000 1.137 +++ swank.lisp 8 Mar 2004 17:44:53 -0000 @@ -572,7 +572,12 @@ (ash (next-byte) 8) (next-byte))) (string (make-string length)) - (pos (read-sequence string stream))) + (pos 0)) + ;; Keep reading in case the connection is slow + (loop for iteration = 1 then (1+ iteration) + do (incf pos (read-sequence string stream :start pos)) + until (or (= pos length) (< 10 iterations )) ;;until length or appx. 1 second + do (sleep 0.1)) ;; at least with cmucl this is multi-proc. friendly (assert (= pos length) () "Short read: length=~D pos=~D" length pos) (let ((form (read-form string))) Here is the patch to remove the bad code from swank-cmucl.lisp: Index: swank-cmucl.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank-cmucl.lisp,v retrieving revision 1.78 diff -u -r1.78 swank-cmucl.lisp --- swank-cmucl.lisp 7 Mar 2004 16:41:11 -0000 1.78 +++ swank-cmucl.lisp 8 Mar 2004 17:46:15 -0000 @@ -4,39 +4,6 @@ (in-package :swank) -(in-package :lisp) - -;; Fix for read-sequence in 18e -#+cmu18e -(progn - (let ((s (find-symbol (string :*enable-package-locked-errors*) :lisp))) - (when s - (setf (symbol-value s) nil))) - - (defun read-into-simple-string (s stream start end) - (declare (type simple-string s)) - (declare (type stream stream)) - (declare (type index start end)) - (unless (subtypep (stream-element-type stream) 'character) - (error 'type-error - :datum (read-char stream nil #\Null) - :expected-type (stream-element-type stream) - :format-control "Trying to read characters from a binary stream.")) - ;; Let's go as low level as it seems reasonable. - (let* ((numbytes (- end start)) - (bytes-read (system:read-n-bytes stream s start numbytes t))) - (if (< bytes-read numbytes) - (+ start bytes-read) - end))) - - (let ((s (find-symbol (string :*enable-package-locked-errors*) :lisp))) - (when s - (setf (symbol-value s) t))) - - ) - -(in-package :swank) - ;;;; TCP server.

2 1

[slime-devel] Daily ChangeLog diff
by Luke Gorrie 08 Mar '04

08 Mar '04

Index: slime/ChangeLog diff -u slime/ChangeLog:1.282 slime/ChangeLog:1.284 --- slime/ChangeLog:1.282 Fri Mar 5 17:55:49 2004 +++ slime/ChangeLog Mon Mar 8 02:15:41 2004 @@ -1,3 +1,37 @@ +2004-03-08 Helmut Eller <e9626484(a)stud3.tuwien.ac.at> + + * slime.el (slime-start-swank-server, slime-maybe-start-lisp): + Translate filenames. + +2004-03-08 Bill Clementson <Bill_Clementson(a)peoplesoft.com> + + * slime.el (slime-insert-balanced-comments) + (slime-remove-balanced-comments, slime-pretty-lambdas): New + functions. + +2004-03-07 Jouni K Seppanen <jks(a)iki.fi> + + * slime.el (sldb-help-summary): New function. + (sldb-mode): Add docstring so that describe-mode is useful. + (sldb-mode-map): Add bindings for sldb-help-summary and + describe-mode. + (define-sldb-invoke-restart-key): Generate docstrings. + (sldb-default-action/mouse, sldb-default-action) + (sldb-eval-in-frame, sldb-pprint-eval-in-frame) + (sldb-inspect-in-frame, sldb-down, sldb-up, sldb-details-up) + (sldb-details-down, sldb-list-locals, sldb-quit, sldb-continue) + (sldb-abort, sldb-invoke-restart, sldb-break-with-default-debugger) + (sldb-step): Add rudimentary docstrings. + +2004-03-07 Helmut Eller <e9626484(a)stud3.tuwien.ac.at> + + * slime.el (slime-complete-symbol*, slime-simple-complete-symbol): + Use the correct block name when returning. + (slime-display-completion-list): Fix typo. + + * swank-cmucl.lisp (frame-locals): Use #:not-available instead of + "<not-available>". + 2004-03-05 Bill Clementson <Bill_Clementson(a)peoplesoft.com> * swank-lispworks.lisp (getpid, emacs-connected): Conditionalize

1 0

[slime-devel] Native Win32 XEmacs w/ cygwin CLisp
by 49gu4n502＠sneakemail.com 08 Mar '04

08 Mar '04

Background: I'm just starting out with SLIME, and it's been just a little bit rough because of my environment, but more promising than ILisp. The complications are: I'm running on WinXP, I've generally used a native version of XEmacs (21.4.13 as of today), I use some Cygwin tools, and since I'm just getting reacquainted with Lisp, I've been trying out various implementations. I tried out Cygwin XEmacs over the last week, but found it less stable overall than the native version, so I've reverted. I did get SLIME going with Cygwin XEmacs and Cygwin CLisp (latest version), no problem. When I switched back to native XEmacs, I had problems with SLIME initialization. XEmacs is sending native file namestrings to CLisp, and the latter chokes on the backslashes. After only a little searching, I found slime-translate-to-lisp-filename-function, and now I define it as follows during XEmacs initialization: (defvar slime-translate-to-lisp-filename-function (function (lambda (s) (replace-in-string s "\\\\" "/")))) However, I have found and fixed two places in slime.el that weren't calling this function. These two changes allow me to get to REPL. The functions that I changed are slime-maybe-start-lisp and slime-start-swank-server. Here's output from cvs diff: diff -r1.228 slime.el 968c968 < (concat slime-path slime-backend))) --- > (slime-to-lisp-filename (concat slime-path sli me-backend)))) 980c980 < (slime-swank-port-file)))) --- > (slime-to-lisp-filename (slime-swank-port-file)) ))) (If there's a better format I can use for showing changes, please tell me how to get it.) Nice code, by the way, it only took a little guesswork to find the hook for translating file names. Very different from my ILisp experience.

2 1

[slime-devel] [PATCH] Help for sldb
by Jouni K Seppanen 07 Mar '04

07 Mar '04

Hi, While I was learning how to use sldb I found myself thinking that it could use some help features. Here are some rudimentary docstrings so that C-h m and C-h k work, and a function (bound to ?) that displays some possible keystrokes, similar to the corresponding function in dired. -- Jouni K Seppänen

2 1

[slime-devel] swank:frame-locals
by Marco Baringer 06 Mar '04

06 Mar '04

i would like to make a change to slime which isn't directly related to slime as an emacs lisp IDE but related to slime's (unexpected) use as a generic debugger interface. The function frame-locals currently returns the name and the value of a frame-local as strings, while this is great for emacs it makes it impossible for me[1] to usefully inspect those values in my debugging interface (built on slime but doesn't use emacs). The change i would like to propose is the make swank:frame-locals return, along with :value-string and :name, a :value and :name-value property. is this ok or is it important that slime remain concentrated on being an emacs interface and not a general common lisp implementation abstraction layer? This particular change would be rather trivial but I can see this being the start of a road slime may not want to take. [1] - i'm pretty sure i'm not the only person using slime without emacs, but i can't remeber who it was who said they were also doing this. -- Marco Ring the bells that still can ring. Forget the perfect offering. There is a crack in everything. That's how the light gets in. -Leonard Cohen

3 3

[slime-devel] Daily ChangeLog diff
by Luke Gorrie 06 Mar '04

06 Mar '04

Index: slime/ChangeLog diff -u slime/ChangeLog:1.280 slime/ChangeLog:1.282 --- slime/ChangeLog:1.280 Thu Mar 4 17:21:55 2004 +++ slime/ChangeLog Fri Mar 5 17:55:49 2004 @@ -1,3 +1,27 @@ +2004-03-05 Bill Clementson <Bill_Clementson(a)peoplesoft.com> + + * swank-lispworks.lisp (getpid, emacs-connected): Conditionalize + for Windows. + +2004-03-05 Helmut Eller <e9626484(a)stud3.tuwien.ac.at> + + * swank.lisp (frame-locals-for-emacs): Bind *print-readably* to + nil. + +2004-03-05 Marco Baringer <mb(a)bese.it> + + * swank.lisp (frame-locals-for-emacs): New function. + + * slime.el (sldb-frame-locals): Use swank::frame-locals-for-emacs + not swank::frame-locals. + (sldb-insert-locals): use the :value property, not the + :value-string property. + + * swank-allegro.lisp, swank-clisp.lisp, swank-cmucl.lisp, + swank-lispworks.lisp, swank-sbcl.lisp (frame-locals): Return lisp + objects, not strings. Use the :value property and not the + :value-string property. + 2004-03-04 Helmut Eller <e9626484(a)stud3.tuwien.ac.at> * slime.el (slime-display-comletion-list): New function. Set

1 0

[slime-devel] Re: Using SLIME with LispWorks on Win2000
by Bill_Clementson＠peoplesoft.com 05 Mar '04

05 Mar '04

Below is a patch that will allow you to use SLIME with the LispWorks WIN32 Windows application on the LispWorks Personal Edition for Windows. You won't be able to start LW via an inferior lisp with "M-x slime"; however, you can use a similar approach to what I described in my earlier post regarding ACL for Windows. Here's the patch: diff -u swank-lispworks-orig.lisp swank-lispworks.lisp --- swank-lispworks-orig.lisp Wed Mar 3 00:08:33 2004 +++ swank-lispworks.lisp Fri Mar 5 10:37:19 2004 @@ -58,7 +58,7 @@ (defimplementation emacs-connected () ;; Set SIGINT handler on Swank request handler thread. - (sys:set-signal-handler +sigint+ (make-sigint-handler mp: *current-process*))) + #-win32 (sys:set-signal-handler +sigint+ (make-sigint-handler mp: *current-process*))) ;;; Unix signals @@ -75,7 +75,8 @@ (lispworks:without-interrupts (funcall fn))) (defmethod getpid () - (system::getpid)) + #+win32 (win32:get-current-process-id) + #-win32 (system::getpid)) (defimplementation lisp-implementation-type-name () "lispworks")

2 1

[slime-devel] SLIME adding its own layer of confusion to error messages
by Peter Seibel 05 Mar '04

05 Mar '04

Here's an error message I got in my *sdb* buffer: #<CONSTANT-POOL-IDX @ #x75b9f21a> cannot be converted to a pathname. [Condition of type TYPE-ERROR] Restarts: 0: [ABORT] Return to SLIME toplevel. 1: [ABORT] Abort entirely from this process. If we look at the backtrace around lines 5 and 6 we see that the real problem was a NO-APPLICABLE-METHOD which is somehow causing SWANK to pass my object to SWANK:PATHNAME-AS-DIRECTORY. Anyone know what that's about. This is with Allegro, FWIW. Backtrace: 0: (SWANK::SWANK-DEBUGGER-HOOK #<TYPE-ERROR @ #x75b9f27a> #<Function SWANK-DEBUGGER-HOOK>) 1: (EXCL::INTERNAL-INVOKE-DEBUGGER "Error" #<TYPE-ERROR @ #x75b9f27a> T) 2: (ERROR TYPE-ERROR :DATUM #1=#<CONSTANT-POOL-IDX @ #x75b9f21a> :EXPECTED-TYPE (OR PATHNAME STREAM STRING) :FORMAT-CONTROL "~s cannot be converted to a pathname." :FORMAT-ARGUMENTS (#1#)) 3: (EXCL::.TYPE-ERROR #1=#<CONSTANT-POOL-IDX @ #x75b9f21a> (OR PATHNAME STREAM STRING) 1 "~s cannot be converted to a pathname." . #1#) 4: (PATHNAME #<CONSTANT-POOL-IDX @ #x75b9f21a>) 5: (SWANK::PATHNAME-AS-DIRECTORY #<CONSTANT-POOL-IDX @ #x75b9f21a>) 6: ((METHOD NO-APPLICABLE-METHOD (#)) #<STANDARD-GENERIC-FUNCTION TAG> #<CONSTANT-POOL-IDX @ #x75b9f21a>) 7: (SYSTEM::..RUNTIME-OPERATION #<STANDARD-GENERIC-FUNCTION NO-APPLICABLE-METHOD> #<STANDARD-GENERIC-FUNCTION TAG> (#<CONSTANT-POOL-IDX @ #x75b9f21a>)) 8: (EXCL::INITIAL-DFUN (#<CONSTANT-POOL-IDX @ #x75b9f21a>) #<STANDARD-GENERIC-FUNCTION TAG>) 9: ((METHOD COM.GIGAMONKEYS.BINARY-DATA::FILL-OBJECT-FROM-STREAM :AFTER (CONSTANT-POOL T)) #<CONSTANT-POOL @ #x75b9eb52> #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>) 10: ((:INTERNAL (:EFFECTIVE-METHOD 2 NIL NIL NIL T) 0) #<CONSTANT-POOL @ #x75b9eb52> #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>) 11: (SYSTEM::..RUNTIME-OPERATION #<Closure (:INTERNAL # 0) @ #x75b9eb7a>) 12: (EXCL::CHECKING-MISS #<STANDARD-GENERIC-FUNCTION COM.GIGAMONKEYS.BINARY-DATA::FILL-OBJECT-FROM-STREAM> (#<CONSTANT-POOL @ #x75b9eb52> #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>) #<Closure (:INTERNAL # 0) @ #x75b9ea3a> #(0 NIL NIL NIL NIL NIL NIL NIL)) 13: ((:INTERNAL EXCL::UPDATE-TO-CHECKING-DFUN 2) #<CONSTANT-POOL @ #x75b9eb52> #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>) 14: ((METHOD READ-OBJECT (SYMBOL T)) CONSTANT-POOL #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>) 15: (SYSTEM::..RUNTIME-OPERATION #<Function (METHOD READ-OBJECT #)> (CONSTANT-POOL #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>)) 16: ((:INTERNAL EXCL::EFFECTIVE-METHOD-EQL 0) CONSTANT-POOL #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>) 17: ((METHOD COM.GIGAMONKEYS.BINARY-DATA::FILL-OBJECT-FROM-STREAM (JAVA-CLASS-FILE T)) #<JAVA-CLASS-FILE @ #x75b9ea12> #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>) 18: ((:INTERNAL (:EFFECTIVE-METHOD 2 NIL NIL NIL T) 0) #<JAVA-CLASS-FILE @ #x75b9ea12> #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>) 19: (SYSTEM::..RUNTIME-OPERATION #<Closure (:INTERNAL # 0) @ #x75b9ea3a> (#<JAVA-CLASS-FILE @ #x75b9ea12> #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>)) 20: (EXCL::INITIAL-DFUN (#<JAVA-CLASS-FILE @ #x75b9ea12> #<EXCL::BINARY-INPUT-FILE-STREAM #p"classfiles/java/lang/String.class" pos 15 @ #x75b9e38a>) #<STANDARD-GENERIC-FUNCTION COM.GIGAMONKEYS.BINARY-DATA::FILL-OBJECT-FROM-STREAM>) -Peter -- Peter Seibel peter(a)javamonkey.com Lisp is the red pill. -- John Fraser, comp.lang.lisp

2 2

[slime-devel] Daily ChangeLog diff
by Luke Gorrie 05 Mar '04

05 Mar '04

Index: slime/ChangeLog diff -u slime/ChangeLog:1.279 slime/ChangeLog:1.280 --- slime/ChangeLog:1.279 Wed Mar 3 15:57:46 2004 +++ slime/ChangeLog Thu Mar 4 17:21:55 2004 @@ -1,3 +1,27 @@ +2004-03-04 Helmut Eller <e9626484(a)stud3.tuwien.ac.at> + + * slime.el (slime-display-comletion-list): New function. Set + syntax table properly. + (slime-complete-symbol*, slime-simple-complete-symbol): Use it. + (slime-update-connection-list): New function. + (slime-draw-connection-list): Simplified. + (slime-connection-list-mode-map): Bind g to update-connection-list. + (slime-open-inspector): Print the primitive type in brackets. + (slime-test-arglist): Add test for empty arglist. + + * swank-allegro.lisp, swank-clisp.lisp, swank-cmucl.lisp, + swank-lispworks.lisp, swank-sbcl.lisp, swank-backend.lisp + (thread-alive-p): Add default implementation. + (describe-primitive-type): Add default implementation. + (inspected-parts): Implemented for Allegro and CLISP. + + * swank.lisp (remove-dead-threads): New function. + (lookup-thread): Use it. + (print-arglist): New function. This time without a custom pretty + print dispatch table. + (format-arglist): Use it. + (inspected-parts): Add method for hash-tables. + 2004-03-03 Helmut Eller <e9626484(a)stud3.tuwien.ac.at> * swank.lisp: Use *emacs-connection*, *active-threads*, and

1 0

[slime-devel] Daily ChangeLog diff
by Luke Gorrie 04 Mar '04

04 Mar '04

Index: slime/ChangeLog diff -u slime/ChangeLog:1.277 slime/ChangeLog:1.279 --- slime/ChangeLog:1.277 Wed Mar 3 02:34:35 2004 +++ slime/ChangeLog Wed Mar 3 15:57:46 2004 @@ -1,5 +1,23 @@ 2004-03-03 Helmut Eller <e9626484(a)stud3.tuwien.ac.at> + * swank.lisp: Use *emacs-connection*, *active-threads*, and + *thread-counter* as thread local dynamic variables. + (init-emacs-connection): Don't set *emacs-connection*. + (create-connection, dispatch-event): Pass the connection object to + newly created threads. + (with-connection): New macro + (handle-request, install-fd-handler, debug-thread): Use it. + + * swank-allegro.lisp, swank-clisp.lisp, swank-cmucl.lisp, + swank-openmcl.lisp, swank-sbcl.lisp (call-with-compilation-hooks): + Bind fewer variables. Most of them are already bound in + swank.lisp. + + * swank.lisp (setup-server, serve-connection): New dont-close + argument to keep the socket open after the first connection. + (start-server, create-swank-server): Update callers. + Reported by Bill Clementson. + * swank-cmucl.lisp (resolve-note-location): Don't be too clever, if there is no context available. The compiler notes buffer is probably more adequate in this situation. @@ -18,8 +36,8 @@ * swank.lisp (find-completions): Deleted. (simple-completions): Use longest-common-prefix instead of longest-completion. - (inspect-in-frame): Moved here from swank-cmucl.lisp. - + (inspect-in-frame): Moved here from swank-cmucl.lisp. + * swank-lispworks.lisp (call-with-debugging-environment): Bind *sldb-top-frame*. (nth-frame): Use *sldb-top-frame*.

1 0