- slime-devel - mailman3.common-lisp.net

[slime-devel] Daily ChangeLog diff
by Helmut Eller 16 Nov '11

16 Nov '11

Index: slime/ChangeLog diff -u slime/ChangeLog:1.2241 slime/ChangeLog:1.2242 --- slime/ChangeLog:1.2241 Sat Nov 12 06:43:01 2011 +++ slime/ChangeLog Wed Nov 16 02:01:18 2011 @@ -1,3 +1,12 @@ +2011-11-16 Stas Boukarev <stassats(a)gmail.com> + + * swank.lisp (open-dedicated-output-stream): Open a stream with + the right coding system. + Change (:open-dedicated-output-stream port) message to + (:open-dedicated-output-stream port coding-system), because Emacs + can no longer determine the coding system based on the main + network streams since they are binary now. + 2011-11-11 Anton Kovalenko <anton(a)sw4me.com> * slime.el (slime-ed): add bytep argument to destructure-case. Index: slime/contrib/ChangeLog diff -u slime/contrib/ChangeLog:1.505 slime/contrib/ChangeLog:1.506 --- slime/contrib/ChangeLog:1.505 Sat Nov 12 06:43:02 2011 +++ slime/contrib/ChangeLog Wed Nov 16 02:01:19 2011 @@ -1,3 +1,8 @@ +2011-11-16 Stas Boukarev <stassats(a)gmail.com> + + * slime-repl.el (slime-open-stream-to-lisp): Set the process coding system + to the right coding system. + 2011-11-12 Nikodemus Siivola <nikodemus(a)random-state.net> Fix DEFMETHOD indentation when the name is a SETF-name, and qualifiers

1 0

[slime-devel] Daily ChangeLog diff
by Helmut Eller 13 Nov '11

13 Nov '11

Index: slime/ChangeLog diff -u slime/ChangeLog:1.2240 slime/ChangeLog:1.2241 --- slime/ChangeLog:1.2240 Tue Nov 8 00:15:34 2011 +++ slime/ChangeLog Sat Nov 12 06:43:01 2011 @@ -1,3 +1,8 @@ +2011-11-11 Anton Kovalenko <anton(a)sw4me.com> + + * slime.el (slime-ed): add bytep argument to destructure-case. + When it's true, position is interpreted as byte offset. + 2011-11-08 Helmut Eller <heller(a)common-lisp.net> Restore old header format. Index: slime/contrib/ChangeLog diff -u slime/contrib/ChangeLog:1.503 slime/contrib/ChangeLog:1.505 --- slime/contrib/ChangeLog:1.503 Mon Oct 31 02:46:16 2011 +++ slime/contrib/ChangeLog Sat Nov 12 06:43:02 2011 @@ -1,3 +1,21 @@ +2011-11-12 Nikodemus Siivola <nikodemus(a)random-state.net> + + Fix DEFMETHOD indentation when the name is a SETF-name, and qualifiers + are present. + + * slime-cl-indent.el (lisp-beginning-of-defmethod-qualifiers): Renamed + from `lisp-beginning-of-defmethod'. Skip the method name as well, since + unlike qualifiers it can be list -- eg. (setf foo). + (lisp-indent-defmethod): Use the above to get the number of skips right. + + * slime-cl-indent-test.txt: Tests 64 and 65. + +2011-11-11 Anton Kovalenko <anton(a)sw4me.com> + + * swank-fancy-inspector.lisp (make-pathname-ispec): Use :position + instead of :charpos, according to slime-ed interface. Add :bytep + t, telling slime-ed to interpret it as byte offset. + 2011-10-31 Nikodemus Siivola <nikodemus(a)random-state.net> * slime-cl-indent.el (common-lisp-run-indentation-tests): Make it

1 0

[slime-devel] :charpos in swank-fancy-inspector vs :position in slime-ed
by Anton Kovalenko 11 Nov '11

11 Nov '11

Hello SLIME developers, Fancy-inspector module provides a feature that I tried to use today: for a stream object, it proposes to visit a file and go to current stream position. Unfortunately, it doesn't work in current SLIME. In swank-fancy-inspector.lisp, make-pathname-ispec passes a :charpos keyword, while in slime.el, slime-ed expects :position. I assume there's a real problem, not just an argument name incompatibility: for common CL implementations, CL:FILE-POSITION is measured in bytes, and slime-ed (that ends up in goto-char) expects character. Assuming unibyte encoding and passing :position argument from fancy inspector makes this feature useful most of the time, though. I'm unsure where the real problem (octets-vs-characters) should be fixed; a problem with argument names looks like a separate one, because what's passed in :charpos is a byte offset. -- Regards, Anton Kovalenko <http://github.com/akovalenko/sbcl-win32-threads/wiki> +7(916)345-34-02 | Elektrostal' MO, Russia

2 1

[slime-devel] Daily ChangeLog diff
by Helmut Eller 08 Nov '11

08 Nov '11

Index: slime/ChangeLog diff -u slime/ChangeLog:1.2239 slime/ChangeLog:1.2240 --- slime/ChangeLog:1.2239 Sun Nov 6 10:34:51 2011 +++ slime/ChangeLog Tue Nov 8 00:15:34 2011 @@ -1,3 +1,10 @@ +2011-11-08 Helmut Eller <heller(a)common-lisp.net> + + Restore old header format. + + * swank-rpc.lisp (parse-header, write-header) + * slime.el (slime-net-decode-length, slime-net-encode-length) + 2011-11-06 Helmut Eller <heller(a)common-lisp.net> * swank-ecl.lisp (accept-connection): Fix buffering arg.

1 0

[slime-devel] New wire format
by Helmut Eller 08 Nov '11

08 Nov '11

I just committed changes to the wire format. The new format is defined on bytes and not characters. Counting characters was problematic, especially with Lisps that use UTF16 internally (Allegro, CMUCL, JVM based Lisps). Emacs counts the length of strings in Unicode code points, while in UTF16 a single code point may occupy either 1 or 2 indexes (code units) and so CL:LENGTH may return something different as Emacs expected. For the same reason we can't use READ-SEQUENCE to read a specified number of code points. The new format looks so: | byte0 | 3 bytes length | | ... payload ... | The 3 bytes length header specify the length of the payload in bytes. The playload is an s-exp encoded as UTF8 text. byte0 is currently always 0; other values are reserved for future use. Robert Brown said he'd like to use compression, so byte0 might come in handy. The change breaks backward compatibility. When upgrading, make sure that both Lisp and Emacs use the new format. I did some light testing with most of the backends and provided a portable version for the utf8 encoding/decoding. I didn't test SCL and CormanCL. Third party backends, for Clojure etc., are obviously broken now. So if you need those, wait until somebody fixes them and the dust has settled. Helmut

4 12

[slime-devel] Shutting down Swank within an Image.
by Andrew Myers 07 Nov '11

07 Nov '11

So I've been looking into the problem of restarting a lisp image saved from Slime. It appears to me that Swank is still blocked on the socket listening for connections in the restarted image in some cases (I'm not sure why it's inconsistent). As a result when the image is restarted it's stuck listening on a connection that will never receive data and can't execute the Swank initialization process to connect to the new socket which Slime has chosen. I was thinking that I would implement swank-backend:save-image to shutdown Swank before dumping the image (or possibly have the restart function shutdown any existing Swank processes) so there's nothing in the way of Swank being re-initialized when the image is loaded again. (Does this sounds like a reasonable thing to do?) I'm not sure how to do this though, there only seem to be methods for shutting down the Swank server, not individual connections. Looking at other implementations of save-image wasn't very illuminating so I seem to be missing something. It looks like the connection struct and the *connections* defvar might have what I need in it, but there is only sanctioned access to the most recently opened connection via `default-connection`. Presumably I would need to close _all_ *connections*? Can anyone point me in the right direction? Thanks, Andrew

4 10

[slime-devel] Daily ChangeLog diff
by Helmut Eller 07 Nov '11

07 Nov '11

Index: slime/ChangeLog diff -u slime/ChangeLog:1.2222 slime/ChangeLog:1.2239 --- slime/ChangeLog:1.2222 Thu Nov 3 11:31:31 2011 +++ slime/ChangeLog Sun Nov 6 10:34:51 2011 @@ -1,3 +1,92 @@ +2011-11-06 Helmut Eller <heller(a)common-lisp.net> + + * swank-ecl.lisp (accept-connection): Fix buffering arg. + * swank-cmucl.lisp (accept-connection): Fix buffering arg. + +2011-11-06 Helmut Eller <heller(a)common-lisp.net> + + * slime.el (slime-run-test): Renamed from slime-run-one-test. + (slime-toggle-test-debug-on-error): New. + ([test] break): Longer timeouts. + +2011-11-06 Helmut Eller <heller(a)common-lisp.net> + + Add portable versions for string-to-utf8 and utf8-to-string. + + * swank-backend.lisp (default-string-to-utf8) + (default-utf8-to-string): New. + (string-to-utf8, utf8-to-string): Use default implementations. + + * swank-lispworks.lisp (make-flexi-stream): Restored. + (utf8-stream): Deleted. The utf8 stuff is now used for the + default implementation of utf8-to-string and would cause name + clashes. + +2011-11-06 Helmut Eller <heller(a)common-lisp.net> + + * swank-allegro.lisp (swank-compile-string): For reader errors + return nil not (values nil nil t). + +2011-11-06 Helmut Eller <heller(a)common-lisp.net> + + New wire format. + + Switch from character streams to binary streams. Counting + characters was error prone because some Lisps use utf-16 + internally and so READ-SEQUENCE can't be used easily. + + The new format looks so: + + | byte0 | 3 bytes length | + | ... payload ... | + + The playload is an s-exp encoded as UTF-8 string. byte0 is + currently always 0; other values are reserved for future use. + + * swank-rpc.lisp (write-message): Use new format. + (write-header, parse-header, asciify, encoding-error): New. + + * swank.lisp (accept-connections): Create a binary stream. + (input-available-p): Can't read-char-no-hang on binary streams. + + * slime.el (slime-net-connect): Use binary as coding system. + (slime-net-send, slime-net-read, slime-net-decode-length) + (slime-net-encode-length, slime-net-have-input-p): Use new format. + (slime-unibyte-string, slime-handle-net-read-error): New. + (featurep): Require 'un-define for XEmacs. + + * swank-sbcl.lisp (input-ready-p): Use sb-sys:wait-until-fd-usable. + +2011-11-06 Helmut Eller <heller(a)common-lisp.net> + + * swank.lisp (close-connection): Fix thinko. + +2011-11-06 Helmut Eller <heller(a)common-lisp.net> + + * swank-backend.lisp (accept-connection): Improve docstring. In + particular say that we want a binary stream if the EXTERNAL-FORMAT + argument is nil. + + * swank-abcl.lisp (accept-connection): Make it so. + * swank-clisp.lisp (accept-connection): Make it so. + * swank-cmucl.lisp (accept-connection): Make it so. + * swank-lispworks.lisp (accept-connection): Make it so. + * swank-sbcl.lisp (accept-connection): Make it so. + * swank-scl.lisp (accept-connection): Make it so. + +2011-11-06 Helmut Eller <heller(a)common-lisp.net> + + * swank-backend.lisp (utf8-to-string, string-to-utf8): New. + + * swank-sbcl.lisp (string-to-utf8, string-to-utf8): Implemented . + * swank-lispworks.lisp (string-to-utf8, string-to-utf8): Implemented. + * swank-cmucl.lisp (string-to-utf8, string-to-utf8): Implemented. + * swank-clisp.lisp (string-to-utf8, string-to-utf8): Implemented. + * swank-ccl.lisp (string-to-utf8, string-to-utf8): Implemented. + * swank-allegro.lisp (string-to-utf8, string-to-utf8): Implemented. + * swank-abcl.lisp (string-to-utf8, string-to-utf8): Implemented. + (octets-to-jbytes, jbytes-to-octets): New helpers. + 2011-11-03 Helmut Eller <heller(a)common-lisp.net> * swank.lisp (close-connection): Be more careful with non-ascii.

1 0

Re: [slime-devel] Shutting down Swank within an Image.
by Andrew Myers 04 Nov '11

04 Nov '11

I'm not aware of a way to do this portably but if there is a way I would be happy to learn. :) Andrew On Fri, Nov 4, 2011 at 12:28 PM, Jeffrey Cunningham <jeffrey(a)jkcunningham.com> wrote: > On Fri, 04 Nov 2011 08:54:34 -0700, Andrew Myers <asm198(a)gmail.com> wrote: > >> I've got an updated version that seems to work quite well: >> >> (defun aux-save-image (image-name) >> (let ((old-restart excl:*restart-init-function*)) >> (setf excl:*restart-init-function* >> (lambda () >> (dolist (connection swank::*connections*) >> (format t "closing ~a~%" connection) >> (swank::close-connection connection nil nil)) >> (when old-restart >> (funcall old-restart)))) >> (excl:dumplisp :name image-name) >> (setf excl:*restart-init-function* old-restart))) >> >> Is there anything wrong with doing things this way? I get the same >> number of threads after I restart an image saved this way (i.e. no >> left overs from prior runs) and things don't hang. If this seems like >> a clean solution I may add a (close-all-swank-connections) method to >> the swank package and make the swank-backend:save-image implementation >> for Allegro do something like this. >> >> Does this sounds like a valid solution to the problem that other >> Lispers would be happy with? >> >> Andrew >> > > > Other than being a solution specific to EXCL it looks reasonable. >

1 0

[slime-devel] Daily ChangeLog diff
by Helmut Eller 04 Nov '11

04 Nov '11

Index: slime/ChangeLog diff -u slime/ChangeLog:1.2220 slime/ChangeLog:1.2222 --- slime/ChangeLog:1.2220 Wed Oct 19 02:47:57 2011 +++ slime/ChangeLog Thu Nov 3 11:31:31 2011 @@ -1,3 +1,15 @@ +2011-11-03 Helmut Eller <heller(a)common-lisp.net> + + * swank.lisp (close-connection): Be more careful with non-ascii. + +2011-11-03 Helmut Eller <heller(a)common-lisp.net> + + Remove dependecy on FLEXI-STREAMS for Lispworks. + + * swank-lispworks.lisp (make-flexi-stream): Deleted. + (utf8-stream): New class to do the transcoding. + (accept-connection): Use it. + 2011-10-19 Andrew Myers <asm198(a)gmail.com> * swank-allegro.lisp (frob-allegro-field-def): Add missing type to

1 0

[slime-devel] Daily ChangeLog diff
by Helmut Eller 01 Nov '11

01 Nov '11

Index: slime/contrib/ChangeLog diff -u slime/contrib/ChangeLog:1.500 slime/contrib/ChangeLog:1.503 --- slime/contrib/ChangeLog:1.500 Sat Oct 29 04:15:15 2011 +++ slime/contrib/ChangeLog Mon Oct 31 02:46:16 2011 @@ -1,3 +1,28 @@ +2011-10-31 Nikodemus Siivola <nikodemus(a)random-state.net> + + * slime-cl-indent.el (common-lisp-run-indentation-tests): Make it + possible to run only a specific test. + +2011-10-31 Nikodemus Siivola <nikodemus(a)random-state.net> + + Improve indentation of comments inside LOOP. + + * slime-cl-indent-test.txt: New tests 54-63. + + * slime-cl-indent.el (common-lisp-loop-type): Deal with comments + at the start of the loop, add simple/split type. + + * slime-cl-indent.el (lisp-indent-loop): Use + common-lisp-loop-part-indentation for simple loops regardless of + the value of lisp-loop-indent-subclauses. + + * slime-cl-indent.el (common-lisp-loop-part-indentation): Handle the + new simple/split type, improve comment indentation logic. + +2011-10-31 Nikodemus Siivola <nikodemus(a)random-state.net> + + * slime-cl-indent.el (style "sbcl"): Indentation for !DEF-TYPE-TRANSLATOR. + 2011-10-29 Nikodemus Siivola <nikodemus(a)random-state.net> Two patches by Tomohiro Matsuyama <tomo(a)cx4a.org>.

1 0