Brian Downing wrote:
On Wed, Nov 24, 2004 at 05:09:08AM -0600, Chris Capel wrote:
My previous patch fixed the arglist code, but the function that returns macro indention was still broken. (In more ways than one, actually--it didn't treat &body and &rest equivalently. That problem turned out to be the actual problem with the indentation macro that led me on this adventure in the first place. Go figure.) This patch fixes that quite nicely, I believe.
I believe that only indenting &body as code was intentional. Even the Hyperspec hints that it should be used that way (as opposed to &rest) in 3.4.4:
&body is identical in function to &rest, but it can be used to inform certain output-formatting and editing functions that the remainder of the form is treated as a body, and should be indented accordingly.
I would think that any user code that used &rest where a body was expected was the broken code.
I see. This certainly makes sense. I'll inform the maintainer of the macro :-).
I think I agree in spirit with the removal of &aux and &whole for the reasons you gave, but it should be an option (perhaps default, but an option nonetheless).
I suppose it wouldn't be too difficult to arrange, but ... why? I really can't see a situation in the current slime where that would be useful. I put the code to remove those parts of the arglist as high up as I could, so that their effect would be localized to 1) the macro indentation function, and 2) "Print the list ARGLIST for display in the echo area." Any other code is unaffected by these changes.