[slime-devel] future of slime-indentation contrib

Currently slime-indentation contrib has a (patched?) copy of a 1995 vintage cl-indent.el inlined at the tail of slime-indentation.el. I propose the following: * Copy GNU Emacs' current cl-indent.el as contrib/slime-cl-indent.el * Make slime-indentation.el load this file. * Patch this file directly to improve indentation. * Those feeling energetic can send patches to Emacs/XEmacs. In the spirit of doing it rather than talking about it, I pushed a "slime-indentation" branch onto my git tree for review: https://github.com/nikodemus/Slime/tree/slime-indentation It incorporates Didier Verna's recent improvements, and fixes two pet hates of mine. (Distinguish "default" from "def.*" and indent PROG correctly.) I haven't lived with these changes for very long yet though, but so far they seem OK. Unless others feel uncomfortable with this approach, I would like to merge this stuff into the CVS. Cheers, -- Nikodemus

2011/5/8 Nikodemus Siivola
Currently slime-indentation contrib has a (patched?) copy of a 1995 vintage cl-indent.el inlined at the tail of slime-indentation.el.
I propose the following:
* Copy GNU Emacs' current cl-indent.el as contrib/slime-cl-indent.el
The only reservation I have regarding this is if it works with older versions of Emacs and XEmacs.
* Make slime-indentation.el load this file.
* Patch this file directly to improve indentation.
* Those feeling energetic can send patches to Emacs/XEmacs.
In the spirit of doing it rather than talking about it, I pushed a "slime-indentation" branch onto my git tree for review:
https://github.com/nikodemus/Slime/tree/slime-indentation
It incorporates Didier Verna's recent improvements, and fixes two pet hates of mine. (Distinguish "default" from "def.*" and indent PROG correctly.) I haven't lived with these changes for very long yet though, but so far they seem OK.
Unless others feel uncomfortable with this approach, I would like to merge this stuff into the CVS.
Best regards, Paulo Madeira

Paulo Madeira <acelent@gmail.com> wrote:
The only reservation I have regarding this is if it works with older versions of Emacs and XEmacs.
I don't think that the code in cl-indent.el is so fancy that it would depend on non-backward-compatible stuff. -- Resistance is futile. You will be jazzimilated. Scientific site: http://www.lrde.epita.fr/~didier Music (Jazz) site: http://www.didierverna.com

Absent complaints will start merging my stuff to slime-indentation contrib next week. Cheers, -- Nikodemus

On 11 May 2011 13:13, Nikodemus Siivola <nikodemus@random-state.net> wrote:
Absent complaints will start merging my stuff to slime-indentation contrib next week.
Hum, I actually just did that. Sunday this week is early next week, right? Add slime-indentation to your slime-setup call, and enjoy. :) Cheers, -- nikodemus

Nikodemus Siivola wrote:
* Those feeling energetic can send patches to Emacs/XEmacs.
FYI, you can send patches to me directly, in which case I will apply them to the XEmacs version. In fact, cl-indent.el does not belong to the core of XEmacs but to an external (read: sold separately) package named prog-modes. Our package maintainer is usually very reactive which means that there's usually no more than a few days between a package commit and a new official release of the package in question.
In the spirit of doing it rather than talking about it, I pushed a "slime-indentation" branch onto my git tree for review:
I'll take a look. -- Resistance is futile. You will be jazzimilated. Scientific site: http://www.lrde.epita.fr/~didier Music (Jazz) site: http://www.didierverna.com
participants (3)
-
Didier Verna
-
Nikodemus Siivola
-
Paulo Madeira