[slime-devel] minor patch to

The patch below alters the lisp-version-string to accommodate 64 bit Allegro and 64 bit OpenMCL. Any comments... Index: swank-loader.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank-loader.lisp,v retrieving revision 1.59 diff -u -w -r1.59 swank-loader.lisp --- swank-loader.lisp 13 Apr 2006 10:41:59 -0000 1.59 +++ swank-loader.lisp 7 Aug 2006 14:30:26 -0000 @@ -66,12 +66,15 @@ #+scl (lisp-implementation-version) #+sbcl (lisp-implementation-version) #+ecl (lisp-implementation-version) - #+openmcl (format nil "~d.~d" + #+openmcl (format nil "~d.~d~@[-~d~]" ccl::*openmcl-major-version* - ccl::*openmcl-minor-version*) + ccl::*openmcl-minor-version* + #+ppc64-target 64 + #-ppc64-target nil) #+lispworks (lisp-implementation-version) #+allegro (concatenate 'string (if (eq 'h 'H) "A" "M") ; ANSI vs MoDeRn - excl::*common-lisp-version-number*) + excl::*common-lisp-version-number* + #+64bit "-64") #+clisp (let ((s (lisp-implementation-version))) (subseq s 0 (position #\space s))) #+armedbear (lisp-implementation-version) thanks, -- Gary Warren King metabang.com [http://www.metabang.com/] (413) 885 9127 * (206) 338-4052 [Fax] gwking on #lisp (occasionally)

On Mon, 7 Aug 2006 10:46:11 -0400, Gary King said: Delivered-To: slime-devel@common-lisp.net
The patch below alters the lisp-version-string to accommodate 64 bit Allegro and 64 bit OpenMCL.
Any comments...
Maybe it would be better to handle this by *architecture-features*? -- Martin Simmons LispWorks Ltd http://www.lispworks.com/
Index: swank-loader.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank-loader.lisp,v retrieving revision 1.59 diff -u -w -r1.59 swank-loader.lisp --- swank-loader.lisp 13 Apr 2006 10:41:59 -0000 1.59 +++ swank-loader.lisp 7 Aug 2006 14:30:26 -0000 @@ -66,12 +66,15 @@ #+scl (lisp-implementation-version) #+sbcl (lisp-implementation-version) #+ecl (lisp-implementation-version) - #+openmcl (format nil "~d.~d" + #+openmcl (format nil "~d.~d~@[-~d~]" ccl::*openmcl-major-version* - ccl::*openmcl-minor-version*) + ccl::*openmcl-minor-version* + #+ppc64-target 64 + #-ppc64-target nil) #+lispworks (lisp-implementation-version) #+allegro (concatenate 'string (if (eq 'h 'H) "A" "M") ; ANSI vs MoDeRn - excl::*common-lisp-version-number*) + excl::*common-lisp-version-number* + #+64bit "-64") #+clisp (let ((s (lisp-implementation-version))) (subseq s 0 (position #\space s))) #+armedbear (lisp-implementation-version)
thanks, -- Gary Warren King metabang.com [http://www.metabang.com/] (413) 885 9127 * (206) 338-4052 [Fax] gwking on #lisp (occasionally)

Hi Martin, My understanding is that *architecture-features* tells me about the processor but that since I can still run 32-bit lisps on a 64-bit processor, I need to add this additional test to differentiate a home directory... Yes? No? On Aug 7, 2006, at 12:25 PM, Martin Simmons wrote:
On Mon, 7 Aug 2006 10:46:11 -0400, Gary King said: Delivered-To: slime-devel@common-lisp.net
The patch below alters the lisp-version-string to accommodate 64 bit Allegro and 64 bit OpenMCL.
Any comments...
Maybe it would be better to handle this by *architecture-features*?
-- Martin Simmons LispWorks Ltd http://www.lispworks.com/
Index: swank-loader.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank-loader.lisp,v retrieving revision 1.59 diff -u -w -r1.59 swank-loader.lisp --- swank-loader.lisp 13 Apr 2006 10:41:59 -0000 1.59 +++ swank-loader.lisp 7 Aug 2006 14:30:26 -0000 @@ -66,12 +66,15 @@ #+scl (lisp-implementation-version) #+sbcl (lisp-implementation-version) #+ecl (lisp-implementation-version) - #+openmcl (format nil "~d.~d" + #+openmcl (format nil "~d.~d~@[-~d~]" ccl::*openmcl-major-version* - ccl::*openmcl-minor-version*) + ccl::*openmcl-minor-version* + #+ppc64-target 64 + #-ppc64-target nil) #+lispworks (lisp-implementation-version) #+allegro (concatenate 'string (if (eq 'h 'H) "A" "M") ; ANSI vs MoDeRn - excl::*common-lisp-version-number*) + excl::*common-lisp-version-number* + #+64bit "-64") #+clisp (let ((s (lisp-implementation-version))) (subseq s 0 (position #\space s))) #+armedbear (lisp-implementation-version)
thanks, -- Gary Warren King metabang.com [http://www.metabang.com/] (413) 885 9127 * (206) 338-4052 [Fax] gwking on #lisp (occasionally)
-- Gary Warren King metabang.com [http://www.metabang.com/] (413) 885 9127 * (206) 338-4052 [Fax] gwking on #lisp (occasionally)

On Mon, 7 Aug 2006 14:25:14 -0400, Gary King said:
Hi Martin,
My understanding is that *architecture-features* tells me about the processor but that since I can still run 32-bit lisps on a 64-bit processor, I need to add this additional test to differentiate a home directory...
Yes? No?
I was assuming that a 32-bit lisp on a 64-bit processor can share fasls with the same 32-bit lisp on a 32-bit processor. Maybe that's not true for all lisps? The keywords in *ARCHITECTURE-FEATURES* are those found in *FEATURES*, but it would seem strange to me(*) if a Lisp implementation modifies *FEATURES* on startup according to the actual processor being used, because it wouldn't affect any code already loaded with #+/#-. (*) Well, LispWorks doesn't anyway :-) -- Martin Simmons LispWorks Ltd http://www.lispworks.com/
On Aug 7, 2006, at 12:25 PM, Martin Simmons wrote:
> On Mon, 7 Aug 2006 10:46:11 -0400, Gary King said: Delivered-To: slime-devel@common-lisp.net
The patch below alters the lisp-version-string to accommodate 64 bit Allegro and 64 bit OpenMCL.
Any comments...
Maybe it would be better to handle this by *architecture-features*?
-- Martin Simmons LispWorks Ltd http://www.lispworks.com/
Index: swank-loader.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank-loader.lisp,v retrieving revision 1.59 diff -u -w -r1.59 swank-loader.lisp --- swank-loader.lisp 13 Apr 2006 10:41:59 -0000 1.59 +++ swank-loader.lisp 7 Aug 2006 14:30:26 -0000 @@ -66,12 +66,15 @@ #+scl (lisp-implementation-version) #+sbcl (lisp-implementation-version) #+ecl (lisp-implementation-version) - #+openmcl (format nil "~d.~d" + #+openmcl (format nil "~d.~d~@[-~d~]" ccl::*openmcl-major-version* - ccl::*openmcl-minor-version*) + ccl::*openmcl-minor-version* + #+ppc64-target 64 + #-ppc64-target nil) #+lispworks (lisp-implementation-version) #+allegro (concatenate 'string (if (eq 'h 'H) "A" "M") ; ANSI vs MoDeRn - excl::*common-lisp-version-number*) + excl::*common-lisp-version-number* + #+64bit "-64") #+clisp (let ((s (lisp-implementation-version))) (subseq s 0 (position #\space s))) #+armedbear (lisp-implementation-version)
thanks, -- Gary Warren King metabang.com [http://www.metabang.com/] (413) 885 9127 * (206) 338-4052 [Fax] gwking on #lisp (occasionally)
-- Gary Warren King metabang.com [http://www.metabang.com/] (413) 885 9127 * (206) 338-4052 [Fax] gwking on #lisp (occasionally)

Oh, that would make sense but I'm not sure. I'm pretty positive that it's not the case with OpenMCL and Allegro but I'll check. On Aug 8, 2006, at 6:36 PM, Martin Simmons wrote:
I was assuming that a 32-bit lisp on a 64-bit processor can share fasls with the same 32-bit lisp on a 32-bit processor. Maybe that's not true for all lisps?
thanks, -- Gary Warren King metabang.com [http://www.metabang.com/] (413) 885 9127 * (206) 338-4052 [Fax] gwking on #lisp (occasionally)
participants (2)
-
Gary King
-
Martin Simmons