[slime-devel] Daily ChangeLog diff
Index: slime/ChangeLog diff -u slime/ChangeLog:1.2066 slime/ChangeLog:1.2067 --- slime/ChangeLog:1.2066 Thu Apr 15 14:01:13 2010 +++ slime/ChangeLog Sat Apr 17 14:10:20 2010 @@ -1,3 +1,16 @@ +2010-04-17 Stas Boukarev <stassats@gmail.com> + + * slime.el (slime-threads-update-interval): New customization + variable, if set to a number the threads buffer will + updated with this interval. + (slime-with-popup-buffer): Rename modes option to mode, + for a major mode. Enabling minor modes from within the body + doesn't cause troubles. End that way it is compatible with XEmacs + since it doesn't need to use minor-mode-list to distinguish + between minor and major modes. + + * swank.lisp (list-threads): Delete the current thread from the listing. + 2010-04-15 Tobias C. Rittweiler <tcr@freebits.de> * slime.el (sldb-mode): Include some more commands in its help. Index: slime/contrib/ChangeLog diff -u slime/contrib/ChangeLog:1.370 slime/contrib/ChangeLog:1.371 --- slime/contrib/ChangeLog:1.370 Tue Apr 6 09:24:29 2010 +++ slime/contrib/ChangeLog Sat Apr 17 21:35:10 2010 @@ -1,3 +1,11 @@ +2010-04-18 Stas Boukarev <stassats@gmail.com> + + * slime-presentations.el + (slime-repl-grab-old-output,slime-copy-or-inspect-presentation-at-mouse): + If the presentation at point is no longer available, remove + presentation properties from the object. + * swank-presentations.lisp (lookup-presented-object): defun->defslimefun. + 2010-04-06 Stas Boukarev <stassats@gmail.com> * slime-c-p-c.el (slime-complete-symbol*-fancy-bit): There is no
Index: slime/ChangeLog diff -u slime/ChangeLog:1.2066 slime/ChangeLog:1.2067 --- slime/ChangeLog:1.2066 Thu Apr 15 14:01:13 2010 +++ slime/ChangeLog Sat Apr 17 14:10:20 2010 @@ -1,3 +1,16 @@ +2010-04-17 Stas Boukarev <stassats@gmail.com> + + * slime.el (slime-threads-update-interval): New customization + variable, if set to a number the threads buffer will + updated with this interval.
1. Because no :group keyword value was specified, the value for the 'Groups' field in the *Customize* buffer is 'Slime Debugger'. This default could be changed by specifying 'slime-ui for the :group keyword value in the definition of `slime-threads-update-interval'. 2. If a :type keyword value of 'integer is specified in the definition of `slime-threads-update-interval', then the *Customize* buffer will prevent the setting of the variable's value to a non-integer. This would need to be combined with setting the default value for the variable to zero instead of nil, and with a change to the code that uses the variable, in the function `slime-list-threads'. Here is a suggested patch for these changes to slime.el, revision 1.1302.
Mark Harig <idirectscm@aim.com> writes:
Index: slime/ChangeLog diff -u slime/ChangeLog:1.2066 slime/ChangeLog:1.2067 --- slime/ChangeLog:1.2066 Thu Apr 15 14:01:13 2010 +++ slime/ChangeLog Sat Apr 17 14:10:20 2010 @@ -1,3 +1,16 @@ +2010-04-17 Stas Boukarev <stassats@gmail.com> + + * slime.el (slime-threads-update-interval): New customization + variable, if set to a number the threads buffer will + updated with this interval.
1. Because no :group keyword value was specified, the value for the 'Groups' field in the *Customize* buffer is 'Slime Debugger'. This default could be changed by specifying 'slime-ui for the :group keyword value in the definition of `slime-threads-update-interval'. Oh, I left it to figure out what section I need later and forgot about it. Thanks!
2. If a :type keyword value of 'integer is specified in the definition of `slime-threads-update-interval', then the *Customize* buffer will prevent the setting of the variable's value to a non-integer. This would need to be combined with setting the default value for the variable to zero instead of nil, and with a change to the code that uses the variable, in the function `slime-list-threads'. I changed type to (choice (number :value 0.5) (const nil))
number, because it takes not only integers. P.S. Could you send unified diffs (-u option), it's much easier to read. -- With Best Regards, Stas.
P.S. Could you send unified diffs (-u option), it's much easier to
read.
I have been sending "context" difference listings because that is what is specified for patches in the Emacs manual: M-: (info "(emacs) Sending Patches") * Use `diff -c' to make your diffs. Diffs without context are hard to install reliably. More than that, they are hard to study; we must always study a patch to decide whether we want to install it. Unidiff format is better than contextless diffs, but not as easy to read as `-c' format. Unfortunately, the SLIME manual does not document the preferred format for difference listings in patches. Could the primary developers come to an agreement on what they prefer and add that to slime.texi?
* Mark Harig [2010-04-18 19:29+0200] writes:
P.S. Could you send unified diffs (-u option), it's much easier to
read.
I have been sending "context" difference listings because that is what is specified for patches in the Emacs manual:
M-: (info "(emacs) Sending Patches")
* Use `diff -c' to make your diffs. Diffs without context are hard to install reliably. More than that, they are hard to study; we must always study a patch to decide whether we want to install it. Unidiff format is better than contextless diffs, but not as easy to read as `-c' format.
Unfortunately, the SLIME manual does not document the preferred format for difference listings in patches. Could the primary developers come to an agreement on what they prefer and add that to slime.texi?
It's in the file HACKING. Helmut
On 4/18/2010 1:17 PM, Stas Boukarev wrote:
2. If a :type keyword value of 'integer is specified in the definition of `slime-threads-update-interval', then the *Customize* buffer will prevent the setting of the variable's value to a non-integer. This would need to be combined with setting the default value for the variable to zero instead of nil, and with a change to the code that uses the variable, in the function `slime-list-threads'.
I changed type to (choice (number :value 0.5) (const nil))
number, because it takes not only integers.
Please note that when this is combined with the code in the function `slime-list-threads':
(when slime-threads-update-interval ...
the code allows negative values to be passed to `run-with-timer' (and eventually flagged as invalid in the function `run-at-time'). If the user-interface code in SLIME catches the invalid value before it is passed down the call chain to the timer code, then it should be clearer to the user where s/he made the error.
Mark Harig <idirectscm@aim.com> writes:
On 4/18/2010 1:17 PM, Stas Boukarev wrote:
2. If a :type keyword value of 'integer is specified in the definition of `slime-threads-update-interval', then the *Customize* buffer will prevent the setting of the variable's value to a non-integer. This would need to be combined with setting the default value for the variable to zero instead of nil, and with a change to the code that uses the variable, in the function `slime-list-threads'.
I changed type to (choice (number :value 0.5) (const nil))
number, because it takes not only integers.
Please note that when this is combined with the code in the function `slime-list-threads':
(when slime-threads-update-interval ...
the code allows negative values to be passed to `run-with-timer' (and eventually flagged as invalid in the function `run-at-time'). If the user-interface code in SLIME catches the invalid value before it is passed down the call chain to the timer code, then it should be clearer to the user where s/he made the error.
I don't see an easy way to restrict that number in defcustom. And it's clear from the backtrace where the negative value is coming from. If the user is willing to shoot himslef in the foot, let him do it. -- With Best Regards, Stas.
On 4/18/2010 2:47 PM, Stas Boukarev wrote:
I don't see an easy way to restrict that number in defcustom.
As far as I can tell from the Emacs Lisp manual, I cannot see one either. Someone on the mailing list may have a suggestion. But, given that any user can mistakenly set the value of the variable using `setq', the (often overlooked) *Customize* buffer cannot be relied on to identify all user-entered data errors in any case.
And it's clear from the backtrace where the negative value is coming from. If the user is willing to shoot himslef in the foot, let him do it.
OK. Consider a web interface that asks for a telephone number, but then allows non-numeric characters to be accepted without complaint when the user moves to the next field or when the user submits the form. The web application could pass the invalid data on to other code and, possibly, end up displaying a backtrace in the web browser for the user. Many would consider this to be a sub-optimal solution. The web application won't necessarily verify that a digits-only telephone number is the correct number for the person entering it, but it can (and should) verify that it is a valid telephone number.
Index: slime/ChangeLog diff -u slime/ChangeLog:1.2066 slime/ChangeLog:1.2067 --- slime/ChangeLog:1.2066 Thu Apr 15 14:01:13 2010 +++ slime/ChangeLog Sat Apr 17 14:10:20 2010 @@ -1,3 +1,16 @@ +2010-04-17 Stas Boukarev <stassats@gmail.com> + + * slime.el (slime-threads-update-interval): New customization + variable, if set to a number the threads buffer will + updated with this interval. + (slime-with-popup-buffer): Rename modes option to mode, + for a major mode. Enabling minor modes from within the body + doesn't cause troubles. End that way it is compatible with XEmacs + since it doesn't need to use minor-mode-list to distinguish + between minor and major modes. In slime-clipboard.el, revision 1.5, the definition of the function `slime-clipboard-display-entries' was changed to include a keyword in the call to the function `slime-with-popup-buffer'. The keyword ':modes' is missing the trailing 's'. Line 68 in contrib/slime-clipboard.el.
Index: slime/ChangeLog diff -u slime/ChangeLog:1.2066 slime/ChangeLog:1.2067 --- slime/ChangeLog:1.2066 Thu Apr 15 14:01:13 2010 +++ slime/ChangeLog Sat Apr 17 14:10:20 2010 @@ -1,3 +1,16 @@ +2010-04-17 Stas Boukarev <stassats@gmail.com> + + * slime.el (slime-threads-update-interval): New customization + variable, if set to a number the threads buffer will + updated with this interval. + (slime-with-popup-buffer): Rename modes option to mode, + for a major mode. Enabling minor modes from within the body + doesn't cause troubles. End that way it is compatible with XEmacs + since it doesn't need to use minor-mode-list to distinguish + between minor and major modes.
In slime-clipboard.el, revision 1.5, the definition of the function `slime-clipboard-display-entries' was changed to include a keyword in the call to the function `slime-with-popup-buffer'. The keyword ':modes' is missing the trailing 's'. Line 68 in contrib/slime-clipboard.el.
Also, in the file contrib/slime-compiler-notes-tree.el, revision 1.4, the definition of the function `slime-list-compiler-notes' was changed to include a keyword in the call to to the function `slime-with-popup-buffer'. The keyword ':modes' is missing the trailing 's'. Line 29 in contrib/slime-compiler-notes-tree.el.
In slime-clipboard.el, revision 1.5, the definition of the function `slime-clipboard-display-entries' was changed to include a keyword
in
the call to the function `slime-with-popup-buffer'. The keyword ':modes' is missing the trailing 's'. Line 68 in contrib/slime-clipboard.el.
Also, in the file contrib/slime-compiler-notes-tree.el, revision 1.4, the definition of the function `slime-list-compiler-notes' was changed to include a keyword in the call to to the function `slime-with-popup-buffer'. The keyword ':modes' is missing the trailing 's'. Line 29 in contrib/slime-compiler-notes-tree.el.
Please disregard the previous two messages. The function `slime-with-popup-buffer' does, in fact, spell the keyword ':mode' with no trailing 's' on line 876 of slime.el, revision 1.1307. (Something odd is going on with macro processing in my Emacs.)
Mark Harig <idirectscm@aim.com> writes:
Index: slime/ChangeLog diff -u slime/ChangeLog:1.2066 slime/ChangeLog:1.2067 --- slime/ChangeLog:1.2066 Thu Apr 15 14:01:13 2010 +++ slime/ChangeLog Sat Apr 17 14:10:20 2010 @@ -1,3 +1,16 @@ +2010-04-17 Stas Boukarev <stassats@gmail.com> + + * slime.el (slime-threads-update-interval): New customization + variable, if set to a number the threads buffer will + updated with this interval. + (slime-with-popup-buffer): Rename modes option to mode, + for a major mode. Enabling minor modes from within the body + doesn't cause troubles. End that way it is compatible with XEmacs + since it doesn't need to use minor-mode-list to distinguish + between minor and major modes.
In slime-clipboard.el, revision 1.5, the definition of the function `slime-clipboard-display-entries' was changed to include a keyword in the call to the function `slime-with-popup-buffer'. The keyword ':modes' is missing the trailing 's'. Line 68 in contrib/slime-clipboard.el.
That's right, the definition of slime-with-popup-buffer has been changed too, as stated in this ChangeLog entry. -- With Best Regards, Stas.
participants (3)
-
Helmut Eller -
Mark Harig -
Stas Boukarev