[slime-devel] Daily ChangeLog diff
Index: slime/ChangeLog diff -u slime/ChangeLog:1.1001 slime/ChangeLog:1.1002 --- slime/ChangeLog:1.1001 Sun Nov 12 06:18:57 2006 +++ slime/ChangeLog Sun Nov 19 16:25:15 2006 @@ -1,3 +1,35 @@ +2006-11-19 Helmut Eller <heller@common-lisp.net> + + * slime.el (slime-compile-file): Let the Lisp side choose the + coding system. + (slime-coding): Deleted. + + * swank.lisp (compile-file-for-emacs): Use guess-external-format. + + * swank-backend.lisp (find-external-format) + (guess-external-format): New. + (swank-compile-file): The external-format argument is now a + backend specific value returned by find-external-format. + + * swank-cmucl.lisp, swank-sbcl.lisp, swank-clisp, + swank-lispworks.lisp, swank-allegro.lisp, swank-corman.lisp, + swank-ecl.lisp, swank-scl.lisp, swank-abcl.lisp, swank-openmcl: + Update implementations accordingly. + + * swank-source-file-cache.lisp (read-file): Use guess-external-format. + + * swank.lisp (*swank-wire-protocol-version*): Is now initialized + by the loader. + (wire-protocol-version): Removed, because it contained a reference + to swank-loader::*source-directory*. + + * slime.el (slime-set-connection-info): On protocol version + mismatch, ask the user how to proceed. + (slime-protocol-version): New variable. Initialize it at compile + time to detect stale elc files. + + * swank-loader.lisp (load-swank): Set the protocol version. + 2006-11-12 Marco Baringer <mb@bese.it> * slime.el (slime-make-tramp-file-name): Added (require 'tramp) @@ -10695,3 +10727,5 @@ ;; Local Variables: ;; coding: latin-1 ;; End: + +This file has been placed in the public domain.
"MB" == Marco Baringer <mbaringer@common-lisp.net> writes:
MB> Index: slime/ChangeLog MB> diff -u slime/ChangeLog:1.1001 slime/ChangeLog:1.1002 MB> --- slime/ChangeLog:1.1001 Sun Nov 12 06:18:57 2006 MB> +++ slime/ChangeLog Sun Nov 19 16:25:15 2006 MB> @@ -1,3 +1,35 @@ MB> +2006-11-19 Helmut Eller <heller@common-lisp.net> [...] MB> + * swank-backend.lisp (find-external-format) MB> + (guess-external-format): New. MB> + (swank-compile-file): The external-format argument is now a MB> + backend specific value returned by find-external-format. MB> + MB> + * swank-cmucl.lisp, swank-sbcl.lisp, swank-clisp, MB> + swank-lispworks.lisp, swank-allegro.lisp, swank-corman.lisp, MB> + swank-ecl.lisp, swank-scl.lisp, swank-abcl.lisp, swank-openmcl: MB> + Update implementations accordingly. MB> + [...] Not sure if these changes caused my problems but it seems likely. I only infrequently update my local copy of slime from CVS (usually when a new SBCL is installed) and yesterday was such a day. After that, slime wouldn't start up again failing with some unknown encoding format :ISO-LATIN-1-UNIX. After some digging I came up with the patch below and things are working again. (Summary: find-external-format is being passed a symbol but seems to expect a string.) Holger --- swank-sbcl.lisp 19 Nov 2006 21:33:03 -0000 1.171 +++ swank-sbcl.lisp 21 Nov 2006 10:18:19 -0000 @@ -138,8 +138,11 @@ (:us-ascii "us-ascii" "us-ascii-unix"))) (defimplementation find-external-format (coding-system) - (car (rassoc-if (lambda (x) (member coding-system x :test #'equal)) - *external-format-to-coding-system*))) + (let ((coding-system (if (symbolp coding-system) + (string-downcase (symbol-name coding-system)) + coding-system))) + (car (rassoc-if (lambda (x) (member coding-system x :test #'equal)) + *external-format-to-coding-system*)))) (defun make-socket-io-stream (socket external-format buffering) (sb-bsd-sockets:socket-make-stream socket
* Holger Duerer [2006-11-21 12:10+0100] writes:
Not sure if these changes caused my problems but it seems likely.
Yes, you're right.
After some digging I came up with the patch below and things are working again. (Summary: find-external-format is being passed a symbol but seems to expect a string.)
find-external-format should be called with a string as argument not with a keyword. I.e. the old code was fine. The problem was, that I forgot to update swank:*coding-system*. I've done it now. Helmut.
Helmut Eller <heller@common-lisp.net> writes:
* Holger Duerer [2006-11-21 12:10+0100] writes:
Not sure if these changes caused my problems but it seems likely.
Yes, you're right.
After some digging I came up with the patch below and things are working again. (Summary: find-external-format is being passed a symbol but seems to expect a string.)
find-external-format should be called with a string as argument not with a keyword. I.e. the old code was fine. The problem was, that I forgot to update swank:*coding-system*. I've done it now. Well I just had to apply this patch for the cvs from 2006-12-17 to get it working again in SBCL
Regards Friedrich
Friedrich Dominicus <frido@q-software-solutions.de> writes:
Helmut Eller <heller@common-lisp.net> writes:
* Holger Duerer [2006-11-21 12:10+0100] writes:
Not sure if these changes caused my problems but it seems likely.
Yes, you're right.
After some digging I came up with the patch below and things are working again. (Summary: find-external-format is being passed a symbol but seems to expect a string.)
find-external-format should be called with a string as argument not with a keyword. I.e. the old code was fine. The problem was, that I forgot to update swank:*coding-system*. I've done it now. Well I just had to apply this patch for the cvs from 2006-12-17 to get it working again in SBCL Oh, great it must have been some old code hanging around in my XEmacs. sorry for making this noise.
Regards Friedrich
participants (4)
-
Friedrich Dominicus -
Helmut Eller -
Holger Duerer -
mbaringer＠common-lisp.net