[slime-devel] Repl-test test case, save-recursion in slime-wait-condition
Hello Helmut, the save-excursion before the call to slime-accept-process-output in slime-wait-condition in slime-sync-to-top-level makes the (test point) in the repl-test test case fail. Slime-sync-to-top-level is called from within the slime repl, and during the slime-accept-process-output the REPL's point is supposed to be placed at the new prompt's input marker, but the save-excursion prevents that. Removing the save-excursion makes repl-test go through, and does not introduce any new regression as far as I can see. Can you still remember why you added it? -T.
* Tobias C. Rittweiler [2009-03-04 09:16+0100] writes:
Hello Helmut,
the save-excursion before the call to slime-accept-process-output in slime-wait-condition in slime-sync-to-top-level makes the (test point) in the repl-test test case fail.
Slime-sync-to-top-level is called from within the slime repl, and during the slime-accept-process-output the REPL's point is supposed to be placed at the new prompt's input marker, but the save-excursion prevents that.
Removing the save-excursion makes repl-test go through, and does not introduce any new regression as far as I can see. Can you still remember why you added it?
No, I don't remember. save-current-buffer would make more sense, but it's probably also not needed. Helmut.
participants (2)
-
Helmut Eller -
Tobias C. Rittweiler