Here's a few minor nits:
2004-09-01 John Paul Wallington jpw@gnu.org
* slime.el (slime-oneliner): Don't use free variable. (slime-recenter-window): Likewise. (slime-connect): Tidy up handshake `message' call.
Index: slime.el =================================================================== RCS file: /project/slime/cvsroot/slime/slime.el,v retrieving revision 1.395 diff -u -r1.395 slime.el --- slime.el 30 Aug 2004 22:23:53 -0000 1.395 +++ slime.el 1 Sep 2004 08:46:40 -0000 @@ -965,9 +965,9 @@
(defun slime-oneliner (string) "Return STRING truncated to fit in a single echo-area line." - (substring msg 0 (min (length msg) - (or (position ?\n msg) most-positive-fixnum) - (1- (frame-width))))) + (substring string 0 (min (length string) + (or (position ?\n string) most-positive-fixnum) + (1- (frame-width)))))
;; Interface (defun slime-set-truncate-lines () @@ -1178,7 +1178,7 @@ (message "Connecting to Swank on port %S.." port) (let* ((process (slime-net-connect host port)) (slime-dispatching-connection process)) - (message "Initial handshake..." port) + (message "Initial handshake...") (slime-setup-connection process) (slime-hide-inferior-lisp-buffer) (message "Connected. %s" (slime-random-words-of-encouragement)))) @@ -5947,7 +5947,7 @@ (start (save-excursion (loop repeat line do (forward-line -1)) (point)))) - (set-window-start w start))) + (set-window-start window start)))
(defun sldb-highlight-sexp (&optional start end) "Highlight the first sexp after point."
John Paul Wallington jpw@gnu.org writes:
Here's a few minor nits:
Thanks. Patch committed.
There where quite a few uses of free variables, almost 10 :-)
Helmut.