* trittweiler [2007-08-15 15:45+0200] writes:
Make `M-.' work on definitions outside the current restriction. `M-,' will also properly restore the narrowing as of before the jump. Similiarly for quiting from the compilation notes buffer and the Xref buffers.
- slime.el (slime-narrowing-configuration, slime-emacs-snapshot), (current-slime-narrowing-configuration), (set-slime-narrowing-configuration), (current-slime-emacs-snapshot), (set-slime-emacs-snapshot), (current-slime-emacs-snapshot-fingerprint): New. Emacs' window configurations do not restore narrowing, so introduce a snapshot facility that contains the necessary information.
This is quite a heavy abstraction. Can we at least agree to use "slime" as prefix in ELisp code please?
May I also point out that "slime-emacs-snapshot" is a rather unspecific term? Perhaps something like "slime-window-config" would be more suggestive. Or at least drop the "emacs" part.
Helmut.
Helmut Eller heller@common-lisp.net writes:
- trittweiler [2007-08-15 15:45+0200] writes:
Make `M-.' work on definitions outside the current restriction. `M-,' will also properly restore the narrowing as of before the jump. Similiarly for quiting from the compilation notes buffer and the Xref buffers.
- slime.el (slime-narrowing-configuration, slime-emacs-snapshot), (current-slime-narrowing-configuration), (set-slime-narrowing-configuration), (current-slime-emacs-snapshot), (set-slime-emacs-snapshot), (current-slime-emacs-snapshot-fingerprint): New. Emacs' window configurations do not restore narrowing, so introduce a snapshot facility that contains the necessary information.
This is quite a heavy abstraction. Can we at least agree to use "slime" as prefix in ELisp code please?
It's based upon `current-window-configuration' and `set-window-configuration' --- I wasn't quite sure if I should name them this way or the way you suggest (actually I'd have liked to drop the slime part alltogether.)
May I also point out that "slime-emacs-snapshot" is a rather unspecific term? Perhaps something like "slime-window-config" would be more suggestive. Or at least drop the "emacs" part.
It represents a snapshot of current Emacs' state. So I wouldn't say it's rather unspecific. Further suggestions besides your "slime-window-config" would be "slime-emacs-state" or "slime-state-snapshot." Anything else? Any favorite?
-T.
* Tobias C. Rittweiler [2007-08-16 01:39+0200] writes:
It represents a snapshot of current Emacs' state. So I wouldn't say it's rather unspecific. Further suggestions besides your "slime-window-config" would be "slime-emacs-state" or "slime-state-snapshot." Anything else? Any favorite?
Thinking a bit more about this issue: do we need to restore restrictions? Wouldn't a simple widen be enough?
Helmut Eller heller@common-lisp.net writes:
- Tobias C. Rittweiler [2007-08-16 01:39+0200] writes:
It represents a snapshot of current Emacs' state. So I wouldn't say it's rather unspecific. Further suggestions besides your "slime-window-config" would be "slime-emacs-state" or "slime-state-snapshot." Anything else? Any favorite?
Thinking a bit more about this issue: do we need to restore restrictions? Wouldn't a simple widen be enough?
Perhaps. But it's hard to tell, as it's been with saving and restoring window configuration (which will specifically also restore the old value of point and mark) --- often it's just the thing you want, sometimes it isn't.
As you brought up narrowing as an simple man's alternative to multiple files, I thought that restoring it would be appropriate in that context.
-T.
"Tobias C. Rittweiler" tcr@freebits.de writes:
Helmut Eller heller@common-lisp.net writes:
- trittweiler [2007-08-15 15:45+0200] writes:
- slime.el (slime-narrowing-configuration, slime-emacs-snapshot), (current-slime-narrowing-configuration), (set-slime-narrowing-configuration), (current-slime-emacs-snapshot), (set-slime-emacs-snapshot), (current-slime-emacs-snapshot-fingerprint): New. Emacs' window configurations do not restore narrowing, so introduce a snapshot facility that contains the necessary information.
This is quite a heavy abstraction. Can we at least agree to use "slime" as prefix in ELisp code please?
It's based upon `current-window-configuration' and `set-window-configuration' --- I wasn't quite sure if I should name them this way or the way you suggest (actually I'd have liked to drop the slime part alltogether.)
I don't want to comment on the rest of the naming or design of these functions, but using the package prefix "slime-" is an important Emacs convention that should not be violated. Please fix that.
Matthias
-
Helmut Eller -
Matthias Koeppe -
Tobias C. Rittweiler