Here's another tiny patch. It seems that the function SWANK:LIST-ALL-PACKAGE-NAMES is only used for slime-read-package-name. What about extending it such that nicknames can also be entered? See below.
Cheers, Edi.
Edi Weitz wrote:
;; is PACKAGE-NICKNAMES required to return a fresh list so we ;; can use NCONC instead of APPEND?
It's not explicitly stated, and the implementations I tested on don't so I think NCONC is out.
On Tue, 20 Apr 2004 23:12:11 +0100, Lawrence Mitchell wence@gmx.li wrote:
Edi Weitz wrote:
;; is PACKAGE-NICKNAMES required to return a fresh list so we ;; can use NCONC instead of APPEND?
It's not explicitly stated, and the implementations I tested on don't so I think NCONC is out.
Yes, I could have tested this myself, of course... :)
edi@bird:~ > cmucl ; Loading #p"/home/edi/.cmucl-init". ; loading system definition from /usr/local/lisp/Registry/asdf-install.asd into ; #<The ASDF1015 package, 0/9 internal, 0/9 external> ; registering #<SYSTEM ASDF-INSTALL {485141CD}> as ASDF-INSTALL CMU Common Lisp 18e, running on bird With core: /usr/local/lib/cmucl/lib/lisp.core Dumped on: Thu, 2003-04-03 15:47:12+02:00 on orion See http://www.cons.org/cmucl/ for support information. Loaded subsystems: Python 1.1, target Intel x86 CLOS 18e (based on PCL September 16 92 PCL (f)) * (eq (package-nicknames :cl) (package-nicknames :cl))
T
Lawrence Mitchell wence@gmx.li writes:
Edi Weitz wrote:
;; is PACKAGE-NICKNAMES required to return a fresh list so we ;; can use NCONC instead of APPEND?
It's not explicitly stated, and the implementations I tested on don't so I think NCONC is out.
For SLIME patches I recommend using APPEND and generally endulging in writing easy/fun/cute code without caring a hoot about efficiency unless and until it's observably slow.
Be warned, I have a history of rewriting carefully optimised code to be more cutely inefficient whenever the actual speed difference isn't perceptible. Better to have the fun yourself :-)
Cheers, Luke
P.S., I just got back from out of town and found more SLIME email than work email. There're a shirtload of us these days, very cool!
-
Edi Weitz -
Lawrence Mitchell -
Luke Gorrie