* CVS User sboukarev [2010-04-04 23:47+0200] writes:
Update of /project/slime/cvsroot/slime In directory cl-net:/tmp/cvs-serv26315
Modified Files: ChangeLog slime.el Log Message:
- slime.el (slime-with-popup-buffer): Make &optional parameters
&key parameters, add modes parameter. slime-with-popup-buffer sets up some buffer local variables, but enabling major modes kills all buffer locals, so modes should be enabled before setting them. Adopt changes to slime-with-popup-buffer where needed. This fixes several bugs with popup buffers on non-default connections.
What bugs are you talking about? The old version set the variables variables are set before and after executing body.
Helmut
Helmut Eller heller@common-lisp.net writes:
- CVS User sboukarev [2010-04-04 23:47+0200] writes:
Update of /project/slime/cvsroot/slime In directory cl-net:/tmp/cvs-serv26315
Modified Files: ChangeLog slime.el Log Message:
- slime.el (slime-with-popup-buffer): Make &optional parameters
&key parameters, add modes parameter. slime-with-popup-buffer sets up some buffer local variables, but enabling major modes kills all buffer locals, so modes should be enabled before setting them. Adopt changes to slime-with-popup-buffer where needed. This fixes several bugs with popup buffers on non-default connections.
What bugs are you talking about? The old version set the variables variables are set before and after executing body.
In `slime-list-threads' the body executes a mode command and `slime-update-threads-buffer', which talks to lisp, but `slime-buffer-connection' is already killed at that point. Calling `slime-thread-control-mode' after `slime-update-threads-buffer' doesn't solve it because the latter now sets header-line-format, which would be killed.
Helmut Eller heller@common-lisp.net writes:
- CVS User sboukarev [2010-04-04 23:47+0200] writes:
Update of /project/slime/cvsroot/slime In directory cl-net:/tmp/cvs-serv26315
Modified Files: ChangeLog slime.el Log Message:
- slime.el (slime-with-popup-buffer): Make &optional parameters
&key parameters, add modes parameter. slime-with-popup-buffer sets up some buffer local variables, but enabling major modes kills all buffer locals, so modes should be enabled before setting them. Adopt changes to slime-with-popup-buffer where needed. This fixes several bugs with popup buffers on non-default connections.
What bugs are you talking about? The old version set the variables variables are set before and after executing body.
And for setting them after the body, it also turns on slime-popup-buffer-mode again, which otherwise will be turned off by the major modes, but slime-edit-value wants to disable slime-popup-buffer-mode.