It seems that the doc-type in the (setf documentation) call should be `variable' rather than `symbol'. Also, it doesn't seem necessary to quote `doc'. WDYT ?
2004-09-06 John Paul Wallington jpw@gnu.org
* swank.lisp (define-special): Make the doc-type `variable' rather than `symbol'. Don't quote `doc'.
Index: swank.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank.lisp,v retrieving revision 1.227 diff -u -r1.227 swank.lisp --- swank.lisp 3 Sep 2004 21:12:00 -0000 1.227 +++ swank.lisp 6 Sep 2004 03:15:30 -0000 @@ -905,7 +905,7 @@ This is like defvar, but NAME will not initialized." `(progn (defvar ,name) - (setf (documentation ',name 'symbol) ',doc))) + (setf (documentation ',name 'variable) ,doc)))
(define-special *buffer-package* "Package corresponding to slime-buffer-package.
Hi!
Could someone take a quick squizz at this little fix ?
It seems that the doc-type in the (setf documentation) call should be `variable' rather than `symbol'.
For instance,
SBCL (0.8.13.77) says: WARNING: discarding unsupported DOCUMENTATION of type SYMBOL for object SYMBOL
GCL says: SYMBOL is an illegal documentation type. and goes into the break loop.
Also, it doesn't seem necessary to quote `doc'.
Furthermore, I would like to add a doc fix too.
How about:
2004-09-13 John Paul Wallington jpw@gnu.org
* swank.lisp (define-special): Make the doc-type `variable' rather than `symbol'. Don't quote `doc'. Doc fix.
Index: swank.lisp =================================================================== RCS file: /project/slime/cvsroot/slime/swank.lisp,v retrieving revision 1.230 diff -u -r1.230 swank.lisp --- swank.lisp 13 Sep 2004 00:14:47 -0000 1.230 +++ swank.lisp 13 Sep 2004 08:20:12 -0000 @@ -902,10 +902,10 @@
(defmacro define-special (name doc) "Define a special variable NAME with doc string DOC. -This is like defvar, but NAME will not initialized." +This is like defvar, but NAME will not be initialized." `(progn (defvar ,name) - (setf (documentation ',name 'symbol) ',doc))) + (setf (documentation ',name 'variable) ,doc)))
(define-special *buffer-package* "Package corresponding to slime-buffer-package.
John Paul Wallington jpw@gnu.org writes:
Hi!
Could someone take a quick squizz at this little fix ?
Yes, committed. Thank you for the patch.
Helmut.