I recommend the following change to SLIME-GLOBAL-VARIABLE-NAME-P so that package-qualified global variables are recognized.
(defun slime-global-variable-name-p (name) "Is NAME a global variable? Globals are recognised purely by *this-naming-convention*." ;(string-match "^\*.*\*$" name) ;; LHQ Sat Nov 27 2004 -- allow optional <package-name>: or <package-name>:: (string-match "^\(.*::?\)?\*.*\*$" name) )
Lynn Quam quam@ai.sri.com writes:
I recommend the following change to SLIME-GLOBAL-VARIABLE-NAME-P so that package-qualified global variables are recognized.
Good idea. Change applied.
Helmut.
"Lynn" == Lynn Quam quam@ai.sri.com writes:
Lynn> I recommend the following change to SLIME-GLOBAL-VARIABLE-NAME-P Lynn> so that package-qualified global variables are recognized.
Lynn> (defun slime-global-variable-name-p (name) Lynn> "Is NAME a global variable? Lynn> Globals are recognised purely by *this-naming-convention*." Lynn> ;(string-match "^\*.*\*$" name) Lynn> ;; LHQ Sat Nov 27 2004 -- allow optional <package-name>: or <package-name>:: Lynn> (string-match "^\(.*::?\)?\*.*\*$" name) Lynn> )
I am a bit unsure where `slime-global-variable-name-p' is actually used but shouldn't we include the global constant naming convention such that we have something like this:
(string-match "^\(.*::?\)?[*+].*[*+]$" name)
instead? (This will of course also match "+name*" and vice versa but I see no harm in that).
------------------------+----------------------------------------------------- Christian Lynbech | christian #@ defun #. dk ------------------------+----------------------------------------------------- Hit the philistines three times over the head with the Elisp reference manual. - petonic@hal.com (Michael A. Petonic)
Christian Lynbech christian.lynbech@ericsson.com writes:
I am a bit unsure where `slime-global-variable-name-p' is actually used but shouldn't we include the global constant naming convention such that we have something like this:
(string-match "^\\(.*::?\\)?[*+].*[*+]$" name)instead? (This will of course also match "+name*" and vice versa but I see no harm in that).
Sounds reasonable. I applied the change.
Helmut.
-
Christian Lynbech -
Helmut Eller -
Lynn Quam