I use SLIME for work (at Google, on ITA Software's QPX) and would like to submit improvements. In particular, we'd like to be able to use slime-cl-indent for Common Lisp indentation without any custom patches related to loop indentation, but we need a few more customization options.
So two things:
1. Revision 1.68 of slime-cl-indent ( http://common-lisp.net/viewvc/slime/slime/contrib/slime-cl-indent.el?r1=1.67...) breaks many tests. I think that should be reverted (or at least replaced with something that has the expected behavior).
2. I'd like to submit the attached patch. It introduces a few customization options we want, makes the common-lisp-body-introducing-loop-macro-keyword and common-lisp-indent-indented-loop-macro-keyword regexps more comprehensive, and includes tests for the new customization options (all new tests pass without reverting 1.68, though a bunch of old tests still fail unless 1.68 is reverted).
Peace, -Sam
Anybody there? I'd really like to have the tests working for this, and I and my colleagues would really like to be able to use slime-cl-indent as is without our own custom patching.
If someone wants to grant me commit access, I'd be happy to submit the code myself. But if that's unacceptable, I'd really appreciate a response.
Peace, -Sam
On Tue, Nov 12, 2013 at 3:24 PM, Samuel Freilich sfreilich@google.comwrote:
I use SLIME for work (at Google, on ITA Software's QPX) and would like to submit improvements. In particular, we'd like to be able to use slime-cl-indent for Common Lisp indentation without any custom patches related to loop indentation, but we need a few more customization options.
So two things:
- Revision 1.68 of slime-cl-indent (
http://common-lisp.net/viewvc/slime/slime/contrib/slime-cl-indent.el?r1=1.67...) breaks many tests. I think that should be reverted (or at least replaced with something that has the expected behavior).
- I'd like to submit the attached patch. It introduces a few
customization options we want, makes the common-lisp-body-introducing-loop-macro-keyword and common-lisp-indent-indented-loop-macro-keyword regexps more comprehensive, and includes tests for the new customization options (all new tests pass without reverting 1.68, though a bunch of old tests still fail unless 1.68 is reverted).
Peace, -Sam
Hello Samuel,
On Fri, Dec 6, 2013 at 6:31 PM, Samuel Freilich sfreilich@google.com wrote:
Anybody there? I'd really like to have the tests working for this, and I and my colleagues would really like to be able to use slime-cl-indent as is without our own custom patching.
Your patch has been committed here: https://github.com/slime/slime/commit/78e649fad97cc4b63114b3996ebe0f8a3cc215f7
Cheers,