- tbnl-devel@common-lisp.net - mailman3.common-lisp.net

Re: [mod-lisp-devel] Re: [tbnl-devel] Odd behavior (socket leak)
by Edi Weitz 17 Jul '04

17 Jul '04

Hi Marc! On Sat, 17 Jul 2004 13:04:06 +0200, "Marc Battyani" <marc.battyani(a)fractalconcept.com> wrote: > in OpenLispSocket: > > If there is a socket in cfg->LispSocket and that socket is not > unsafe (cfg->UnsafeLispSocket) then I return this socket. I don't > create a new one. Re-using the socket is much faster. > > if (cfg->LispSocket) > if (cfg->UnsafeLispSocket) > { > ap_pclosesocket(SocketPool, cfg->LispSocket); > cfg->LispSocket = 0; > cfg->UnsafeLispSocket = 0; > } > else > return cfg->LispSocket; > > Or did I mis-read your question ? No, you didn't, it was just an oversight of mine. Sorry for the noise, Edi.

1 0

Re: [tbnl-devel] Odd behavior (socket leak)
by Edi Weitz 17 Jul '04

17 Jul '04

[Looks like it didn't work the first time with common-lisp.net - maybe due to my misconfiguration of SquirrelMail. I'll try it again. Note that Peter has already pointed out my mistaken assumption.] I'm sitting in a train and trying to send this via my cell phone. Let's see if it works... :) I've looked at the source code of mod_lisp.c (version 2.33) and Apache (1.3.29) and I'm beginning to ask myself whether the "Keep-Socket" option makes any sense at all. What I see with my limited knowledge of Apache is the following: 1. The actual content handler in mod_lisp.c which is called each time a new request comes in (from the client) is the function lisp_handler. 2. To get a socket, lisp-handler calls OpenLispSocket. 3. OpenLispSocket uses ap_psocket (using the global variable SocketPool) to get a socket from Apache. 4. ap_psocket is defined in Apache's src/main/alloc.c and basically just calls ap_psocket_ex. 5. ap_socket_ex always unconditionally acquires a new socket via socket(7). The pool which is its first argument (and which is SocketPool from above) is only used for cleanup purposes. So, as a consequence, I cannot understand if and how the socket used by lisp_handler is ever going to be re-used. I'm sending a copy of this email to mod-lisp-devel because Marc is the authoritative source for this kind of questions... :) Cheers, Edi.

1 0

Re: [tbnl-devel] Odd behavior (socket leak)
by pete-tbnl-dev＠kazmier.com 16 Jul '04

16 Jul '04

On Fri, Jul 16, 2004 at 12:37:49PM +0200, edi@miles wrote: > I'm sitting in a train and trying to send this via my cell > phone. Let's see if it works... :) Nice :-) > I've looked at the source code of mod_lisp.c (version 2.33) and Apache > (1.3.29) and I'm beginning to ask myself whether the "Keep-Socket" > option makes any sense at all. What I see with my limited knowledge of > Apache is the following: You missed one key part of the process. > 2. To get a socket, lisp-handler calls OpenLispSocket. > > 3. OpenLispSocket uses ap_psocket (using the global variable > SocketPool) to get a socket from Apache. OpenLispSocket only fetches a new socket if and only if one has not already established and is safe to use (see here): if (cfg->LispSocket) if (cfg->UnsafeLispSocket) { ap_pclosesocket(SocketPool, cfg->LispSocket); cfg->LispSocket = 0; cfg->UnsafeLispSocket = 0; } else { return cfg->LispSocket; } This is the step that bypasses the creation of a new socket. Thus, Keep-Socket does make sense. I'll continue looking at the TBNL and mod_Lisp interaction to see if I can find anything else. Thanks, Pete

1 0

Re: [tbnl-devel] Last-Modified / If-Modified-Since Headers
by Edi Weitz 14 Jul '04

14 Jul '04

On Wed, 14 Jul 2004 01:14:35 -0400, pete-tbnl-dev(a)kazmier.com wrote: > Just to make sure I understand what you are saying: > > - If the user does not assign a handler to the special variable, > then TBNL should not make any assumptions on the intention of the > coder and thus not send any Last-Modified header and never send a > 304 reply in response to a client's If-Modified-Since header. Yes. The default value should be a function which always returns NIL. > - If the user does assign a handler and it returns a non-nil value, > then TBNL should use this universal-time as the value of the > Last-Modified header or the value to compare to a client's > If-Modified-Since header. > > - If the user does assign a handler and it returns a nil value, then > TBNL should not send any Last-Modified header and never send a 304 > reply in response to a client's If-Modified-Since header because the > coder has indicated that the last modified time is not known for > this request. Yes and yes. > I'd be happy to send a patch. I probably won't get to this right > away as I'm busy trying to get other parts of my new site working > and just trying to learn lisp in general. However, at some point > I'll probably need the functionality at which point I'll submit a > patch. That's fine. No need to hurry. > I've built sites that use template engines that are backed by a > "data miner" that refreshes the context used to fill templates on a > periodic basis. Web-based reporting interfaces can take advantage > of this scenario. But why then don't you serve these pages statically directly from Apache? Cheers, Edi.

2 1

[tbnl-devel] Last-Modified / If-Modified-Since Headers
by pete-tbnl-dev＠kazmier.com 13 Jul '04

13 Jul '04

Is there any interest in adding functionality that enables TBNL to automatically send a "304 Not Modified" in response to content that has not changed? For example, in the Java Servlet world, a servlet author can define getLastModified(). What does this buy the servlet author? Automatic client-side caching. For those not familiar with the "Last-Modified/If-Modified-Since" headers, here's a brief overview. The first time client A visits our servlet page, our servlet is called to generate some HTML output. If a servlet author has implemented getLastModified(), the servlet container invokes this method and inserts a "Last-Modified" header in the response to the client. The value of this header is a date specifying when the page was last modified. This value is cached in the client's browser. The next time client A visits our servlet page, in the HTTP request, the client's browser includes a "If-Modified-Since" header with the value that our servlet had previously sent. When our servlet receives the request, it notices the "If-Modified-Since" header, and thus invokes our servlet's getLastModified() method (if defined). When the time returned by this method is newer than the time the client sent, the servlet container proceeds to dispatch the request to our servlet for processing and generation of output. Things are more interesting when the value returned from getLastModified() is the not newer than the value of the "If-Modified-Since" header. In this case, the servlet container bypasses our servlet and simply sends a "304 Not Modified" back to the client which instructs the browser to display the cached content. It is important to note that this servlet container did not dispatch to our code to generate HTML output, it is completely bypassed and all handled by the container. This is the functionality that I would like to add to TBNL. I'm going to do it for myself even if its not part of the core; however, I thought it would be useful for others as well, and thus this post. How would one implement this within TBNL? Would the same approach the Java folks used suffice? Provide a special variable, *last-modified-handler*, that users can set to return a timestamp? From within that method, users would have access to *request* so they could return specific times for various URIs. This is what I need it for, my entire site will be served by HTML-TEMPLATEs and I'll use the last time the template file was modified as my timestamp. Thoughts? Thanks, Pete

2 1

[tbnl-devel] Apache 2.0 support
by Edi Weitz 30 Jun '04

30 Jun '04

The attached email was sent to tbnl-devel when common-lisp.net was down. I'm resending it now because I think it's interesting for people who want to try out TBNL with Apache 2.0.

1 0

Re: [tbnl-devel] Problem with my tests
by Edi Weitz 15 Jun '04

15 Jun '04

On Tue, 15 Jun 2004 10:29:09 -0400, Nicolas Lamirault <lam(a)tuxfamily.org> wrote: > for tbnl i make this now : > >> (defun clwl-start () >> "Load configuration file, create a SQL database handler, >> and initialize the tbnl dispatcher for Clwl" >> (setf *conf* (load-config "/home/nlamirault/src/clwl/clwl.conf")) >> (setf *db* (get-database-connection *conf*)) >> (setf *dispatch-table* >> (nconc >> (mapcar (lambda (args) >> (apply #'create-prefix-dispatcher args)) >> '(("/tnbl/clwl/login.html" login) >> ("/tbnl/clwl/about.html" about) >> ("/tbnl/clwl/" main) >> )) >> (list #'default-dispatcher))) >> (start-tbnl)) > >> (defun clwl-stop () >> (setf *conf* nil) >> (setf *db* nil) >> (setf *dispatch-table* nil) >> (stop-tbnl)) > > so i can load clwl very quickly with asdf operations and > (clwl:clwl-start) > > i use html-template to load the html template file, and create my > web page (with data contained in sql database) but in fact i have a > problem of CSS ... > > for exemple this page : http://localhost/tbnl/clwl/index.html this > page is correcte but css isn't load > > i have this on the HTML template : > > <link rel="stylesheet" type="text/css" href="templates/advogato.css" /> > > and my architecture is like this : > > ~/src/clwl/ > *.lisp > templates/ > *.css > *.html > > > ~/public_html/tbnl/clwl <-- a link towards : ~/src/clwl/ > > > i a write this in the template : > <link rel="stylesheet" type="text/css" href="templates/advogato.css" /> > > there is no change :( > i don't really understand > any help ? I suppose you have Apache configured to delegate all pages below /tbnl/ to TBNL. As index.html is at /tbnl/clwl/index.html the address of the style sheet resolves to /tbnl/clwl/templates/advogato.css which is fed through TBNL which serves MAIN. (You can verify this with something like Ethereal. Or you can add a LOG-MESSAGE form to the MAIN function which logs the SCRIPT-NAME the browser requested.) The easiest way to solve this problem is to give static pages their own root independently of TBNL, something like this: <link rel="stylesheet" type="text/css" href="/static/templates/advogato.css" /> > Ps : i'm on #lisp, nickname : lam I usually don't have time for IRC... :) (If I'm there - very rarely - I'm nhabedi.) Cheers, Edi.

1 0

[tbnl-devel] Problem with my tests
by Nicolas Lamirault 15 Jun '04

15 Jun '04

hello, il make some tests with tbnl, and i have some problems this is how i proceed : ; SLIME 2004-04-28 CL-USER> (push "/home/nlamirault/src/cl-ini/" asdf:*central-registry*) ("/home/nlamirault/src/cl-ini/" #p"/usr/share/common-lisp/systems/" (MERGE-PATHNAMES #p".clc/systems/" (USER-HOMEDIR-PATHNAME)) *DEFAULT-PATHNAME-DEFAULTS*) CL-USER> (push "/home/nlamirault/src/url-rewrite/" asdf:*central-registry*) ("/home/nlamirault/src/url-rewrite/" "/home/nlamirault/src/cl-ini/" #p"/usr/share/common-lisp/systems/" (MERGE-PATHNAMES #p".clc/systems/" (USER-HOMEDIR-PATHNAME)) *DEFAULT-PATHNAME-DEFAULTS*) CL-USER> (push "/home/nlamirault/src/tbnl-0.2.3/" asdf:*central-registry*) ("/home/nlamirault/src/tbnl-0.2.3/" "/home/nlamirault/src/url-rewrite/" "/home/nlamirault/src/cl-ini/" #p"/usr/share/common-lisp/systems/" (MERGE-PATHNAMES #p".clc/systems/" (USER-HOMEDIR-PATHNAME)) *DEFAULT-PATHNAME-DEFAULTS*) CL-USER> (push "/home/nlamirault/src/clwl/" asdf:*central-registry*) ("/home/nlamirault/src/clwl/" "/home/nlamirault/src/tbnl-0.2.3/" "/home/nlamirault/src/url-rewrite/" "/home/nlamirault/src/cl-ini/" #p"/usr/share/common-lisp/systems/" (MERGE-PATHNAMES #p".clc/systems/" (USER-HOMEDIR-PATHNAME)) *DEFAULT-PATHNAME-DEFAULTS*) CL-USER> (asdf:operate 'asdf:load-op :clwl) [...] CL-USER> (tbnl:start-tbnl) #<KMRCL:LISTENER port 3000> i have defined this on clwl.lisp : (setq *dispatch-table* (nconc (mapcar (lambda (args) (apply #'create-prefix-dispatcher args)) '(("/tbnl/clwl" main) ("/tnbl/clwl/login.html" login) ("/tbnl/clwl/about.html" about))) (list #'default-dispatcher))) on url : http://localhost/tbnl/clwl/index.html, i obtain the tbnl's default page : > TBNL Default Page > This the TBNL default page. You're most likely seeing it because the > server administrator hasn't set up his own default page yet. > TBNL is a toolkit for building dynamic websites with Common Lisp and > Apache. More info about TBNL can be found at http://weitz.de/tbnl/. I think that it is comportement normal because : CL-USER> tbnl:*dispatch-table* (TBNL:DEFAULT-DISPATCHER) i have create an init function : > (defun clwl () > (setf *conf* (load-config "/home/nlamirault/src/clwl/clwl.conf")) > (setf *db* (get-database-connection *conf*)) > (setf *dispatch-table* > (nconc > (mapcar (lambda (args) > (apply #'create-prefix-dispatcher args)) > '(("/tbnl/clwl" main) > ("/tnbl/clwl/login.html" login) > ("/tbnl/clwl/about.html" about))) > (list #'default-dispatcher)))) CL-USER> (clwl:clwl) ; [GC threshold exceeded with 17,686,392 bytes in use. Commencing GC.] ; [GC completed with 5,849,408 bytes retained and 11,836,984 bytes freed.] ; [GC will next occur when at least 17,849,408 bytes are in use.] (#<Closure Over Function "DEFUN CREATE-PREFIX-DISPATCHER" {4809FD51}> #<Closure Over Function "DEFUN CREATE-PREFIX-DISPATCHER" {4809FD69}> #<Closure Over Function "DEFUN CREATE-PREFIX-DISPATCHER" {4809FD81}> #<Function TBNL:DEFAULT-DISPATCHER {4911B8B1}>) after this call, the URL http://localhost/tbnl/clwl show what i want it's ok the logs : [Tue Jun 15 15:08:26 2004] [warn] [TBNL] New template printer for #p"templates/blog.html" created so i would like to view the about page with this URL : http://localhost/tbnl/clwl/about.html, but i have a "loop", and after i come back to the home page :( this is what i have on the apache logs : [Tue Jun 15 15:08:43 2004] [error] [TBNL] Main [Tue Jun 15 15:08:44 2004] [error] [TBNL] Main [Tue Jun 15 15:08:45 2004] [error] [TBNL] Main [Tue Jun 15 15:08:46 2004] [error] [TBNL] Main [Tue Jun 15 15:08:46 2004] [error] [TBNL] Main [Tue Jun 15 15:08:47 2004] [error] [TBNL] Main [Tue Jun 15 15:08:47 2004] [error] [TBNL] Main [Tue Jun 15 15:08:48 2004] [error] [TBNL] Main PS : i have this on my functions : (defun main () (log-message :error "Main") ...) (defun login () (log-message :error "Login") ...) (defun about () (log-message :error"About clwl") ...) any idea about my pb ? thanks for any help -- Nicolas Lamirault

2 2

[tbnl-devel] Re: tbnl bug
by Edi Weitz 12 Jun '04

12 Jun '04

On Sat, 12 Jun 2004 15:35:12 +0900, KMP Developer <jc(a)itsec.co.kr> wrote: > I traced the problem and I found who's throwing. In (defmethod > initialize-instance :after ((request request) &rest init-args)) : > (form-url-encoded-list-to-alist > (cl-ppcre:split "&" "abc=1&def=2")) ; OK > > (form-url-encoded-list-to-alist > (cl-ppcre:split "&" "???abc")) ; Throws an exception Ah, now I see it! You didn't mention which Lisp you were using and I only tested against AllegroCL which doesn't expose this problem. I've now tested with CMUCL and see what's going wrong. I've uploaded a new version (0.2.3) which should fix this. > I found my original message is not good enough as a bug > report. Sorry about that No problem. Thanks for finding the bug! >>Please use the mailing list for bug reports, thanks. >> > I'll do that next time. You could have started with this reply... :) Thanks and have a nice weekend, Edi.

1 0

[tbnl-devel] New release 0.2.3
by Edi Weitz 12 Jun '04

12 Jun '04

Hi! A new release is available from <http://weitz.de/files/tbnl.tgz>. Here's the relevant part from the changelog: Version 0.2.3 2004-06-12 Bugfix for FORM-URL-ENCODED-LIST-TO-ALIST (bug caught by Jong-won Choi) Have fun, Edi.

1 0