I know that for production installations, it is not advisable to have *CATCH-ERRORS-P* to be set to NIL. But it is often necessary to debug of remote server. Attached is my patch that simplifies this process. It limits the number of active calls invoke-debugger and destroys debugging threads after closing the connection with a swank-server.
Andrey
Hi Andrey,
I like your patch, but can you enhance it so that it works when swank is not available?
Some review comments:
If you could change
(find-symbol "ADD-HOOK" :swank)
to something like
(find-symbol (string '#:add-hook) :swank)
it'd be nicer towards users of non-standard readtable case settings.
We generally follow the rule to always use the most specific operator, so if you could change the LOOP in KILL-ALL-DEBUGGING-THREADS to DOLIST, it'd be more in line with the rest of the code. If you really love loop, you could remove the do from the LOOP and use the WHEN LOOP clause
Thanks again, Hans
On Sun, Mar 7, 2010 at 02:15, Andrey Moskvitin archimag@gmail.com wrote:
I know that for production installations, it is not advisable to have *CATCH-ERRORS-P* to be set to NIL. But it is often necessary to debug of remote server. Attached is my patch that simplifies this process. It limits the number of active calls invoke-debugger and destroys debugging threads after closing the connection with a swank-server.
Andrey
tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
I like your patch, but can you enhance it so that it works when swank is not available?
Unfortunately, swank does not modify * features *. I use to check for swank: (when (find-package: swank) ...). I added ignore-errors in case of any other swank.
If you really love loop
In my code I always use iterate:)
I modified the code in line with your comments.
Andrey
Andrey,
I committed your patch, thank you!
-Hans
On Sun, Mar 7, 2010 at 09:37, Andrey Moskvitin archimag@gmail.com wrote:
I like your patch, but can you enhance it so that it works when swank is not available?
Unfortunately, swank does not modify * features *. I use to check for swank: (when (find-package: swank) ...). I added ignore-errors in case of any other swank.
If you really love loop
In my code I always use iterate:) I modified the code in line with your comments. Andrey
tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
Hi,
Thanks for the patch, but please add a patch for the HTML documentation as well and add periods at the end of the docstrings. Patch guidelines are here:
The HTML documentation should maybe also contain a few sentences about how this new feature is to be used.
Cheers, Edi (who will be out of town until mid-March).
On Sun, Mar 7, 2010 at 9:37 AM, Andrey Moskvitin archimag@gmail.com wrote:
I like your patch, but can you enhance it so that it works when swank is not available?
Unfortunately, swank does not modify * features *. I use to check for swank: (when (find-package: swank) ...). I added ignore-errors in case of any other swank.
If you really love loop
In my code I always use iterate:) I modified the code in line with your comments. Andrey
tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
Thanks for the patch, but please add a patch for the HTML documentation as well and add periods at the end of the docstrings.
Oh, I can write lisp-code, I can write a simple letter (via Google Translate), but for writing documentation, my English is very terrible :( I can try, but someone will have to correct me: (
Andrey
Hi Andrey,
I did not recognize your english as being bad until you wrote that it is :)
The documentation needs to have information about the debug-mode-on and -off functions as well as the *max-debugging-threads* variable. You don't need to write a novel, just a description of what they do and how they're meant to be used. You should also mention that the special behavior is useful together with Slime. I'm going to review what you send and try to iron out any language issues that I find before committing.
-Hans
On Sun, Mar 7, 2010 at 13:31, Andrey Moskvitin archimag@gmail.com wrote:
Thanks for the patch, but please add a patch for the HTML documentation as well and add periods at the end of the docstrings.
Oh, I can write lisp-code, I can write a simple letter (via Google Translate), but for writing documentation, my English is very terrible :( I can try, but someone will have to correct me: ( Andrey
tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
I did not recognize your english as being bad until you wrote that it is
:)
Yes, I noticed that Google Translate has become much better over the last year :)
The documentation needs to have information about the debug-mode-on and -off functions as well as the *max-debugging-threads* variable.
Ok, I'll do it in the next few days.
Andrey
2010/3/7 Hans Hübner hans.huebner@gmail.com
Hi Andrey,
I did not recognize your english as being bad until you wrote that it is :)
The documentation needs to have information about the debug-mode-on and -off functions as well as the *max-debugging-threads* variable. You don't need to write a novel, just a description of what they do and how they're meant to be used. You should also mention that the special behavior is useful together with Slime. I'm going to review what you send and try to iron out any language issues that I find before committing.
-Hans
The documentation needs to have information about the debug-mode-on and -off functions as well as the *max-debugging-threads* variable.
I wrote this. See attachment. In addition, I attached a patch to fix typos in my code and a link to a supported me repository Hunchentoot on github.com .
Andrey
Hi Andrey,
I committed your patches - after editing - to the svn repository.
Cheers, Hans
On Tue, Mar 9, 2010 at 12:49, Andrey Moskvitin archimag@gmail.com wrote:
The documentation needs to have information about the debug-mode-on and -off functions as well as the *max-debugging-threads* variable.
I wrote this. See attachment. In addition, I attached a patch to fix typos in my code and a link to a supported me repository Hunchentoot on github.com.
Andrey _______________________________________________ tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
Hi,
I've just removed this patch as it breaks the LispWorks version. Feel free to re-submit a cleaned-up version.
Thanks, Edi.
On Tue, Mar 9, 2010 at 8:04 PM, Andrey Moskvitin archimag@gmail.com wrote:
Hi,
I committed your patches - after editing - to the svn repository.
Great! Thank you very much :) Andrey
tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
-
Andrey Moskvitin -
Edi Weitz -
Hans Hübner