[hunchentoot-devel] favicon.ico patch for test.lisp
Some time ago I added two lines to test.lisp which add a favicon to the "menu" page. Maybe someone here will find it useful in a Google search. You don't actually need the patch, but it is the shortest method of explaining what to add where. -- "Cut your own wood and it will warm you twice"
Yoni Rabkin Katzenell <yoni-r@actcom.com> writes:
Some time ago I added two lines to test.lisp which add a favicon to the "menu" page. Maybe someone here will find it useful in a Google search.
You don't actually need the patch, but it is the shortest method of explaining what to add where.
OK... So that did not work. Sorry for the wierd attachment. I'll just paste it right into the mail this time: --- test_original.lisp 2007-01-14 10:56:18.000000000 +0200 +++ test.lisp 2007-01-14 10:55:15.000000000 +0200 @@ -474,6 +474,7 @@ (with-html (:html (:head + (:link :rel "shortcut icon" :href "/hunchentoot/test/favicon.ico" :type "image/x-icon") (:title "Hunchentoot test menu")) (:body (:h2 (str *headline*)) @@ -544,6 +545,11 @@ (make-pathname :name "fz" :type "jpg" :version nil :defaults *this-file*) "image/jpeg") + (create-static-file-dispatcher-and-handler + "/hunchentoot/test/favicon.ico" + (make-pathname :name "favicon" :type "ico" :version nil + :defaults *this-file*) + "image/x-icon") (create-folder-dispatcher-and-handler "/hunchentoot/code/" (make-pathname :name nil :type nil :version nil
On Sun Jan 14, 2007 at 12:07:56PM +0200, Yoni Rabkin Katzenell wrote:
Yoni Rabkin Katzenell <yoni-r@actcom.com> writes:
--- test_original.lisp 2007-01-14 10:56:18.000000000 +0200 +++ test.lisp 2007-01-14 10:55:15.000000000 +0200 @@ -474,6 +474,7 @@ (with-html (:html (:head + (:link :rel "shortcut icon" :href "/hunchentoot/test/favicon.ico" :type "image/x-icon") (:title "Hunchentoot test menu")) (:body (:h2 (str *headline*)) @@ -544,6 +545,11 @@ (make-pathname :name "fz" :type "jpg" :version nil :defaults *this-file*) "image/jpeg") + (create-static-file-dispatcher-and-handler + "/hunchentoot/test/favicon.ico" + (make-pathname :name "favicon" :type "ico" :version nil + :defaults *this-file*) + "image/x-icon") (create-folder-dispatcher-and-handler "/hunchentoot/code/" (make-pathname :name nil :type nil :version nil
Wouldn't that execute the CREATE-STATIC-FILE-DISPATCHER-AND-HANDLER and CREATE-FOLDER-DISPATCHER-AND-HANDLER with every page view? It would probably be better to move them outside the function that builds the html so they only execute once when you startup the server. Regards, -Jeff
Jeffrey Cunningham <jeffrey@cunningham.net> writes: [snip]
Wouldn't that execute the CREATE-STATIC-FILE-DISPATCHER-AND-HANDLER and CREATE-FOLDER-DISPATCHER-AND-HANDLER with every page view?
I can't make sense of the question, sorry. The patch is just a simple link to an image. -- "Cut your own wood and it will warm you twice"
Jeffrey Cunningham wrote:
Wouldn't that execute the CREATE-STATIC-FILE-DISPATCHER-AND-HANDLER and CREATE-FOLDER-DISPATCHER-AND-HANDLER with every page view?
Yoni Rabkin Katzenell wrote:
@@ -474,6 +474,7 @@ (with-html ... @@ -544,6 +545,11 @@ (create-static-file-dispatcher-and-handler ...
Toby
Toby <tobia.conforto@linux.it> writes:
Jeffrey Cunningham wrote:
Wouldn't that execute the CREATE-STATIC-FILE-DISPATCHER-AND-HANDLER and CREATE-FOLDER-DISPATCHER-AND-HANDLER with every page view?
Yoni Rabkin Katzenell wrote:
@@ -474,6 +474,7 @@ (with-html ... @@ -544,6 +545,11 @@ (create-static-file-dispatcher-and-handler ...
That's Dr. Weitz's code. I did not add or modify those. -- "Cut your own wood and it will warm you twice"
On Sun, 14 Jan 2007 06:19:30 -0800, Jeffrey Cunningham <jeffrey@cunningham.net> wrote:
Wouldn't that execute the CREATE-STATIC-FILE-DISPATCHER-AND-HANDLER and CREATE-FOLDER-DISPATCHER-AND-HANDLER with every page view? It would probably be better to move them outside the function that builds the html so they only execute once when you startup the server.
Huh???
On Sun Jan 14, 2007 at 06:19:30AM -0800, Jeffrey Cunningham wrote:
On Sun Jan 14, 2007 at 12:07:56PM +0200, Yoni Rabkin Katzenell wrote:
Yoni Rabkin Katzenell <yoni-r@actcom.com> writes:
--- test_original.lisp 2007-01-14 10:56:18.000000000 +0200 +++ test.lisp 2007-01-14 10:55:15.000000000 +0200 @@ -474,6 +474,7 @@ (with-html (:html (:head + (:link :rel "shortcut icon" :href "/hunchentoot/test/favicon.ico" :type "image/x-icon") (:title "Hunchentoot test menu")) (:body (:h2 (str *headline*)) @@ -544,6 +545,11 @@ (make-pathname :name "fz" :type "jpg" :version nil :defaults *this-file*) "image/jpeg") + (create-static-file-dispatcher-and-handler + "/hunchentoot/test/favicon.ico" + (make-pathname :name "favicon" :type "ico" :version nil + :defaults *this-file*) + "image/x-icon") (create-folder-dispatcher-and-handler "/hunchentoot/code/" (make-pathname :name nil :type nil :version nil
Wouldn't that execute the CREATE-STATIC-FILE-DISPATCHER-AND-HANDLER and CREATE-FOLDER-DISPATCHER-AND-HANDLER with every page view? It would probably be better to move them outside the function that builds the html so they only execute once when you startup the server.
I Misread the patch above. At the time it looked like the CREATE-STATIC-FILE-DISPATCHER-AND-HANDLER and CREATE-FOLDER-DISPATCHER-AND-HANDLER calls were inside the WITH-HTML form, which didn't make any sense to me. I didn't see the line:
@@ -544,6 +545,11 @@
separating tht two. My apologies. --Jeff
On Sun, 14 Jan 2007 11:56:44 +0200, Yoni Rabkin Katzenell <yoni-r@actcom.com> wrote:
Some time ago I added two lines to test.lisp which add a favicon to the "menu" page. Maybe someone here will find it useful in a Google search.
You don't actually need the patch, but it is the shortest method of explaining what to add where.
Thanks. So, now we need someone to create a favicon.ico from the Hunchentoot logo... :)
Edi Weitz wrote:
Thanks. So, now we need someone to create a favicon.ico from the Hunchentoot logo... :) Look at http://www.htg1.de/hunchentoot/hunchentoot.html Uwe 8-)
Sorry, the 32 x 32 version looked awful. Here is a 16 x 16 favicon.ico
I like it, but some color might be nice :) On Jan 14, 2007, at 9:47 AM, Toby wrote:
Edi Weitz wrote:
Thanks. So, now we need someone to create a favicon.ico from the Hunchentoot logo... :)
Here's my take on the 16x16px format
Toby <hunchentoot.ico> _______________________________________________ tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
participants (6)
-
Cyrus Harmon -
Edi Weitz -
Jeffrey Cunningham -
Toby -
Uwe von Loh -
Yoni Rabkin Katzenell