[hunchentoot-devel] PATCH: Some minor fixes for cl-webdav under hunchentoot 1.0
Edi, I took a look at it tonight anyway, and there where some obvious minor fixes I spotted right away, attached is a patch that gets (using cadaver) an initial connection, a put, and a get to work. Just functions that were renamed in the new hunchentoot. Delete doesn't work, complains about a handler-done tag being unknown (but thrown). Here's the message log entry: [2009-11-15 20:55:06 [ERROR]] attempt to THROW to a tag that does not exist: HANDLER-DONE I'm not too familiar with older versions of hunchentoot, does that ring a bell for you? I'll keep looking. -Matt
On Mon, Nov 16, 2009 at 3:29 AM, Matthew Curry <mjcurry@gmail.com> wrote:
I took a look at it tonight anyway, and there where some obvious minor fixes I spotted right away, attached is a patch that gets (using cadaver) an initial connection, a put, and a get to work. Just functions that were renamed in the new hunchentoot.
Thanks a lot, it's in the repository now.
Delete doesn't work, complains about a handler-done tag being unknown (but thrown). Here's the message log entry: [2009-11-15 20:55:06 [ERROR]] attempt to THROW to a tag that does not exist: HANDLER-DONE I'm not too familiar with older versions of hunchentoot, does that ring a bell for you?
I think I've fixed that now (untested): http://bknr.net/trac/changeset/4471/trunk/thirdparty/cl-webdav
I'll keep looking.
Maybe we should just release it now and see if someone complains? I doubt that anybody really uses cl-webdav for serious work. Thanks again, Edi.
I'll keep looking.
Maybe we should just release it now and see if someone complains? I doubt that anybody really uses cl-webdav for serious work.
I don't mind, but I was going to basically test it by going down the list of cadaver commands that do stuff remotely, I think 'copy' didn't work either, but I'll try again later with your updates. -Matt
On Mon, Nov 16, 2009 at 4:01 PM, Matthew Curry <mjcurry@gmail.com> wrote:
I don't mind, but I was going to basically test it by going down the list of cadaver commands that do stuff remotely, I think 'copy' didn't work either, but I'll try again later with your updates.
I'll be out of town for a week anyway. I'll decide next week whether I'll make a new release. Thanks for your help, Edi.
On Mon, 2009-11-16 at 08:06 +0100, Edi Weitz wrote:
On Mon, Nov 16, 2009 at 3:29 AM, Matthew Curry <mjcurry@gmail.com> wrote:
I took a look at it tonight anyway, and there where some obvious minor fixes I spotted right away, attached is a patch that gets (using cadaver) an initial connection, a put, and a get to work. Just functions that were renamed in the new hunchentoot.
Thanks a lot, it's in the repository now.
What's going on here? I can't find the changes to handlers.lisp from that patch in the current svn version - the changes to resources.lisp seem to be there. How can that happen?
Delete doesn't work, complains about a handler-done tag being unknown (but thrown). Here's the message log entry: [2009-11-15 20:55:06 [ERROR]] attempt to THROW to a tag that does not exist: HANDLER-DONE I'm not too familiar with older versions of hunchentoot, does that ring a bell for you?
I think I've fixed that now (untested):
http://bknr.net/trac/changeset/4471/trunk/thirdparty/cl-webdav
I'll keep looking.
Maybe we should just release it now and see if someone complains? I doubt that anybody really uses cl-webdav for serious work.
Autsch! I do ... until today's update :-/ Cheers, RalfD
Thanks again, Edi.
_______________________________________________ tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
On Wed, Feb 17, 2010 at 9:11 PM, Ralf Mattes <rm@seid-online.de> wrote:
What's going on here? I can't find the changes to handlers.lisp from that patch in the current svn version - the changes to resources.lisp seem to be there. How can that happen?
Aren't these the ones you were looking for? http://bknr.net/trac/changeset/3339/trunk/thirdparty/cl-webdav
On Thu, 2010-02-18 at 11:35 +0100, Edi Weitz wrote:
On Wed, Feb 17, 2010 at 9:11 PM, Ralf Mattes <rm@seid-online.de> wrote:
What's going on here? I can't find the changes to handlers.lisp from that patch in the current svn version - the changes to resources.lisp seem to be there. How can that happen?
Aren't these the ones you were looking for?
http://bknr.net/trac/changeset/3339/trunk/thirdparty/cl-webdav
Hallo Edi, yes, these _are_ the patches (and they are trivial so I already fixed the code locally). My problem was/is: a fresh svn checkout like this: ralf@mhflaptop01:/tmp$ svn co svn://bknr.net/svn/trunk/thirdparty/cl-webdav A cl-webdav/resources.lisp A cl-webdav/properties.lisp A cl-webdav/util.lisp A cl-webdav/packages.lisp A cl-webdav/CHANGELOG.txt A cl-webdav/doc A cl-webdav/doc/index.html A cl-webdav/doc/CVS A cl-webdav/doc/CVS/Repository A cl-webdav/doc/CVS/Root A cl-webdav/doc/CVS/Entries A cl-webdav/doc/dav.png A cl-webdav/handlers.lisp A cl-webdav/xml.lisp A cl-webdav/authorized-file-resources.lisp A cl-webdav/specials.lisp A cl-webdav/cl-webdav.asd A cl-webdav/file-resources.lisp Checked out revision 4511. ralf@mhflaptop01:/tmp$ grep content-type cl-webdav/handlers.lisp (setf (content-type) "text/xml; charset=utf-8" <---- What happend to the patch? (setf (content-type) "text/xml; charset=utf-8" (setf (content-type) (resource-content-type resource)) (setf (content-type) "text/xml; charset=utf-8" (content-type) nil) Something seems utterly strange here. BTW, that svn url is the one used in bknr's "ediware" svn repository - is this out of date? Cheers RalfD
I think the problem was that my checkout was somehow botched. I just tried to clean up the mess. Please check if it works now. If you're OK with the changes, we can make this an official release. (Now that I know that there /is/ one user... :) And, yes, the URL should be right. On Thu, Feb 18, 2010 at 11:45 AM, Ralf Mattes <rm@seid-online.de> wrote:
On Thu, 2010-02-18 at 11:35 +0100, Edi Weitz wrote:
On Wed, Feb 17, 2010 at 9:11 PM, Ralf Mattes <rm@seid-online.de> wrote:
What's going on here? I can't find the changes to handlers.lisp from that patch in the current svn version - the changes to resources.lisp seem to be there. How can that happen?
Aren't these the ones you were looking for?
http://bknr.net/trac/changeset/3339/trunk/thirdparty/cl-webdav
Hallo Edi,
yes, these _are_ the patches (and they are trivial so I already fixed the code locally). My problem was/is: a fresh svn checkout like this:
ralf@mhflaptop01:/tmp$ svn co svn://bknr.net/svn/trunk/thirdparty/cl-webdav A cl-webdav/resources.lisp A cl-webdav/properties.lisp A cl-webdav/util.lisp A cl-webdav/packages.lisp A cl-webdav/CHANGELOG.txt A cl-webdav/doc A cl-webdav/doc/index.html A cl-webdav/doc/CVS A cl-webdav/doc/CVS/Repository A cl-webdav/doc/CVS/Root A cl-webdav/doc/CVS/Entries A cl-webdav/doc/dav.png A cl-webdav/handlers.lisp A cl-webdav/xml.lisp A cl-webdav/authorized-file-resources.lisp A cl-webdav/specials.lisp A cl-webdav/cl-webdav.asd A cl-webdav/file-resources.lisp Checked out revision 4511. ralf@mhflaptop01:/tmp$ grep content-type cl-webdav/handlers.lisp (setf (content-type) "text/xml; charset=utf-8" <---- What happend to the patch? (setf (content-type) "text/xml; charset=utf-8" (setf (content-type) (resource-content-type resource)) (setf (content-type) "text/xml; charset=utf-8" (content-type) nil)
Something seems utterly strange here. BTW, that svn url is the one used in bknr's "ediware" svn repository - is this out of date?
Cheers RalfD
On Thu, 2010-02-18 at 11:52 +0100, Edi Weitz wrote:
I think the problem was that my checkout was somehow botched. I just tried to clean up the mess. Please check if it works now. If you're OK with the changes, we can make this an official release. (Now that I know that there /is/ one user... :)
O.k. - first tests look promising. BTW, where is the source for the documentation? I'd like to send a patch ... Cheers, RalfD
And, yes, the URL should be right.
On Thu, Feb 18, 2010 at 12:39 PM, Ralf Mattes <rm@seid-online.de> wrote:
BTW, where is the source for the documentation?
Should be included in your checkout. (The HTML /is/ the source.) http://weitz.de/patches.html
On Thu, 2010-02-18 at 13:10 +0100, Edi Weitz wrote:
On Thu, Feb 18, 2010 at 12:39 PM, Ralf Mattes <rm@seid-online.de> wrote:
BTW, where is the source for the documentation?
Should be included in your checkout. (The HTML /is/ the source.)
Ok, here's a trivial doc patch (see attachment) Cheers, RalfD P.S.: It might be a good idea to mention that JavaScipt need to be enabled to see the documentation - I often get bitten by garbled doc formatting without enabling JavaScript ...
On Thu, Feb 18, 2010 at 1:35 PM, Ralf Mattes <rm@seid-online.de> wrote:
Ok, here's a trivial doc patch (see attachment)
Thanks, applied.
P.S.: It might be a good idea to mention that JavaScipt need to be enabled to see the documentation - I often get bitten by garbled doc formatting without enabling JavaScript ...
You mean the Hunchentoot documentation or CL-WEBDAV's? I think in the case of Hunchentoot's documentation there's no easy way to show such a message, but maybe Hans can chime in.
On Thu, 2010-02-18 at 14:02 +0100, Edi Weitz wrote:
On Thu, Feb 18, 2010 at 1:35 PM, Ralf Mattes <rm@seid-online.de> wrote:
Ok, here's a trivial doc patch (see attachment)
Thanks, applied.
P.S.: It might be a good idea to mention that JavaScipt need to be enabled to see the documentation - I often get bitten by garbled doc formatting without enabling JavaScript ...
You mean the Hunchentoot documentation or CL-WEBDAV's? I think in the case of Hunchentoot's documentation there's no easy way to show such a message, but maybe Hans can chime in.
CL-WebDAV, mainly: <noscript>Please enable JavaScipt for proper formatting </noscript> For hunchentoot: maybe serverside rendering ... cheers, RalfD
On Thu, Feb 18, 2010 at 3:17 PM, Ralf Mattes <rm@seid-online.de> wrote:
CL-WebDAV, mainly:
<noscript>Please enable JavaScipt for proper formatting </noscript>
Where does the CL-WEBDAV page use Javascript?
For hunchentoot: maybe serverside rendering ...
Definitely not. Too much work and you couldn't use it offline anymore.
Edi, Looks like there are a couple of (return-code) -> (return-code*) renames missing in the svn repository (revision 4513 right now). One of them I musta missed in my original patch anyway. copy/move return a 502 Bad Gateway response, which seems odd, but all other (supported) cadaver commands seem to work. patch attached. -Matt On Thu, Feb 18, 2010 at 5:52 AM, Edi Weitz <edi@agharta.de> wrote:
I think the problem was that my checkout was somehow botched. I just tried to clean up the mess. Please check if it works now. If you're OK with the changes, we can make this an official release. (Now that I know that there /is/ one user... :)
And, yes, the URL should be right.
On Thu, Feb 18, 2010 at 11:45 AM, Ralf Mattes <rm@seid-online.de> wrote:
On Thu, 2010-02-18 at 11:35 +0100, Edi Weitz wrote:
On Wed, Feb 17, 2010 at 9:11 PM, Ralf Mattes <rm@seid-online.de> wrote:
What's going on here? I can't find the changes to handlers.lisp from that patch in the current svn version - the changes to resources.lisp seem to be there. How can that happen?
Aren't these the ones you were looking for?
http://bknr.net/trac/changeset/3339/trunk/thirdparty/cl-webdav
Hallo Edi,
yes, these _are_ the patches (and they are trivial so I already fixed the code locally). My problem was/is: a fresh svn checkout like this:
ralf@mhflaptop01:/tmp$ svn co svn://bknr.net/svn/trunk/thirdparty/cl-webdav A cl-webdav/resources.lisp A cl-webdav/properties.lisp A cl-webdav/util.lisp A cl-webdav/packages.lisp A cl-webdav/CHANGELOG.txt A cl-webdav/doc A cl-webdav/doc/index.html A cl-webdav/doc/CVS A cl-webdav/doc/CVS/Repository A cl-webdav/doc/CVS/Root A cl-webdav/doc/CVS/Entries A cl-webdav/doc/dav.png A cl-webdav/handlers.lisp A cl-webdav/xml.lisp A cl-webdav/authorized-file-resources.lisp A cl-webdav/specials.lisp A cl-webdav/cl-webdav.asd A cl-webdav/file-resources.lisp Checked out revision 4511. ralf@mhflaptop01:/tmp$ grep content-type cl-webdav/handlers.lisp (setf (content-type) "text/xml; charset=utf-8" <---- What happend to the patch? (setf (content-type) "text/xml; charset=utf-8" (setf (content-type) (resource-content-type resource)) (setf (content-type) "text/xml; charset=utf-8" (content-type) nil)
Something seems utterly strange here. BTW, that svn url is the one used in bknr's "ediware" svn repository - is this out of date?
Cheers RalfD
_______________________________________________ tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
Thanks, I've applied your patches and made a new release (0.2.0) of cl-webdav which can be downloaded from http://weitz.de/ as usual. On Sat, Feb 20, 2010 at 6:00 AM, Matthew Curry <mjcurry@gmail.com> wrote:
Edi,
Looks like there are a couple of (return-code) -> (return-code*) renames missing in the svn repository (revision 4513 right now). One of them I musta missed in my original patch anyway. copy/move return a 502 Bad Gateway response, which seems odd, but all other (supported) cadaver commands seem to work. patch attached.
-Matt
On Thu, Feb 18, 2010 at 5:52 AM, Edi Weitz <edi@agharta.de> wrote:
I think the problem was that my checkout was somehow botched. I just tried to clean up the mess. Please check if it works now. If you're OK with the changes, we can make this an official release. (Now that I know that there /is/ one user... :)
And, yes, the URL should be right.
On Thu, Feb 18, 2010 at 11:45 AM, Ralf Mattes <rm@seid-online.de> wrote:
On Thu, 2010-02-18 at 11:35 +0100, Edi Weitz wrote:
On Wed, Feb 17, 2010 at 9:11 PM, Ralf Mattes <rm@seid-online.de> wrote:
What's going on here? I can't find the changes to handlers.lisp from that patch in the current svn version - the changes to resources.lisp seem to be there. How can that happen?
Aren't these the ones you were looking for?
http://bknr.net/trac/changeset/3339/trunk/thirdparty/cl-webdav
Hallo Edi,
yes, these _are_ the patches (and they are trivial so I already fixed the code locally). My problem was/is: a fresh svn checkout like this:
ralf@mhflaptop01:/tmp$ svn co svn://bknr.net/svn/trunk/thirdparty/cl-webdav A cl-webdav/resources.lisp A cl-webdav/properties.lisp A cl-webdav/util.lisp A cl-webdav/packages.lisp A cl-webdav/CHANGELOG.txt A cl-webdav/doc A cl-webdav/doc/index.html A cl-webdav/doc/CVS A cl-webdav/doc/CVS/Repository A cl-webdav/doc/CVS/Root A cl-webdav/doc/CVS/Entries A cl-webdav/doc/dav.png A cl-webdav/handlers.lisp A cl-webdav/xml.lisp A cl-webdav/authorized-file-resources.lisp A cl-webdav/specials.lisp A cl-webdav/cl-webdav.asd A cl-webdav/file-resources.lisp Checked out revision 4511. ralf@mhflaptop01:/tmp$ grep content-type cl-webdav/handlers.lisp (setf (content-type) "text/xml; charset=utf-8" <---- What happend to the patch? (setf (content-type) "text/xml; charset=utf-8" (setf (content-type) (resource-content-type resource)) (setf (content-type) "text/xml; charset=utf-8" (content-type) nil)
Something seems utterly strange here. BTW, that svn url is the one used in bknr's "ediware" svn repository - is this out of date?
Cheers RalfD
_______________________________________________ tbnl-devel site list tbnl-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-devel
participants (3)
-
Edi Weitz -
Matthew Curry -
Ralf Mattes