On Tue, May 27, 2008 at 5:53 PM, Erik Huelsmann ehuels@gmail.com wrote:
On Tue, May 27, 2008 at 8:37 PM, Hans Hübner hans@huebner.org wrote:
Geo,
did you test the patch with SBCL, too?
Also, it would be helpful if you could leave the brace style and indentation of the source code as it is. I agree that formatting should be regular and correct, yet reformatting changes should not be interleaved with functional changes as it makes reviewing a lot harder.
I can put the patch into my branch of the usocket repository once you have verified that it does not break SBCL.
Done. Also available at: http://geocar.googlepages.com/usocket-ecl-4.diff
Hunchentoot still runs with sbcl when usocket is patched with this.
ECL however, no longer does because the new flexi-streams which now assumes char-code-limit is greater than 256, so I don't have a big patch ready yet.