Hello,
The attached patch removes redundant call to hcl:flag-special-free-action (on usocket) and replaces 'lispworks6.0' feature keyword with more general 'lispworks6' - LispWorks6.1 only defines 'lispworks6' and 'lispworks6.1'.
Hi, Kamil
Thanks for your patch. You're right about the redundant call to hcl:flag-special-free-action, I miss it when I'm removing the special free action to datagram-usocket class. I've fixed in latest 0.5.x branch [1] and will push it to trunk soon.
But the read macros #+(or lispworks4 lispworks5 lispworks6.0) in function initialize-dynamic-sockaddr is right, because since LispWorks 6.1 the TCP/IPv6 support was added, and now we have separated code for before/after version 6.1. (and the new code is provided by LispWorks guys, very high quality)
Regards,
Chun Tian (binghe)
[1] svn://common-lisp.net/project/usocket/svn/usocket/branches/0.5.x
On 2012-4-17, at 16:30, Kamil Shakirov wrote:
Hello,
The attached patch removes redundant call to hcl:flag-special-free-action (on usocket) and replaces 'lispworks6.0' feature keyword with more general 'lispworks6' - LispWorks6.1 only defines 'lispworks6' and 'lispworks6.1'.
-- --ska <usocket-0.5.5+lw6.1-fixes.patch>_______________________________________________ usocket-devel mailing list usocket-devel@common-lisp.net http://lists.common-lisp.net/cgi-bin/mailman/listinfo/usocket-devel
Hello Binghe,
On Wed, 2012-04-25 at 10:29 +0800, Chun Tian (binghe) wrote:
Hi, Kamil
Thanks for your patch. You're right about the redundant call to hcl:flag-special-free-action, I miss it when I'm removing the special free action to datagram-usocket class. I've fixed in latest 0.5.x branch [1] and will push it to trunk soon.
But the read macros #+(or lispworks4 lispworks5 lispworks6.0) in function initialize-dynamic-sockaddr is right, because since LispWorks 6.1 the TCP/IPv6 support was added, and now we have separated code for before/after version 6.1. (and the new code is provided by LispWorks guys, very high quality)
I didn't notice this latest change, sorry about the noise. :)