[usocket-devel] [Patch] ns-try-again-condition is undefined.

ns-try-again-condition is used in several places, but is defined as ns-try-again. The attached patch renames it to ns-try-again-condition. -- With Best Regards, Stas.

Hi, Stas Boukarev You're right. We should always use "ns-try-again-condition" instead of "ns-try-again" as most backends does. Fixed in trunk and earlier branches. P.S. Do you know how to reliably trigger this condition? I want to added "ns-try-again-condition" into our always-broken unit test code, so that all supported platforms could have this condition reported correctly. Thanks, Chun Tian (binghe) 在 2010-9-28,03:10, Stas Boukarev 写道:
ns-try-again-condition is used in several places, but is defined as ns-try-again. The attached patch renames it to ns-try-again-condition. Index: condition.lisp =================================================================== --- condition.lisp (revision 563) +++ condition.lisp (working copy) @@ -132,7 +132,7 @@ error available."))
(define-usocket-condition-classes - (ns-try-again) + (ns-try-again-condition) (ns-condition))
(define-condition ns-unknown-condition (ns-condition) Index: backend/cmucl.lisp =================================================================== --- backend/cmucl.lisp (revision 563) +++ backend/cmucl.lisp (working copy) @@ -209,10 +209,10 @@ ;; constants mentioned in C (let ((exception (second (assoc errno - '((1 ns-host-not-found-error) ;; HOST_NOT_FOUND - (2 ns-no-recovery-error) ;; NO_DATA - (3 ns-no-recovery-error) ;; NO_RECOVERY - (4 ns-try-again)))))) ;; TRY_AGAIN + '((1 ns-host-not-found-error) ;; HOST_NOT_FOUND + (2 ns-no-recovery-error) ;; NO_DATA + (3 ns-no-recovery-error) ;; NO_RECOVERY + (4 ns-try-again-condition)))))) ;; TRY_AGAIN (when exception (error exception))))))
-- With Best Regards, Stas. _______________________________________________ usocket-devel mailing list usocket-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/usocket-devel

"Chun Tian (binghe)" <binghe.lisp@gmail.com> writes:
Hi, Stas Boukarev
You're right. We should always use "ns-try-again-condition" instead of "ns-try-again" as most backends does.
Fixed in trunk and earlier branches.
P.S. Do you know how to reliably trigger this condition? I want to added "ns-try-again-condition" into our always-broken unit test code, so that all supported platforms could have this condition reported correctly. It happened to me when my connection died. I can't think of any software method, aside from writing your own nameserver.
-- With Best Regards, Stas.

Thanks all the same. On Tue, Sep 28, 2010 at 5:27 PM, Stas Boukarev <stassats@gmail.com> wrote:
"Chun Tian (binghe)" <binghe.lisp@gmail.com> writes:
Hi, Stas Boukarev
You're right. We should always use "ns-try-again-condition" instead of "ns-try-again" as most backends does.
Fixed in trunk and earlier branches.
P.S. Do you know how to reliably trigger this condition? I want to added "ns-try-again-condition" into our always-broken unit test code, so that all supported platforms could have this condition reported correctly. It happened to me when my connection died. I can't think of any software method, aside from writing your own nameserver.
-- With Best Regards, Stas.
-- Chun Tian (binghe)
participants (2)
-
Chun Tian (binghe)
-
Stas Boukarev