Hello,
backend/sbcl.lisp doesn't appear to work at all with ECL. The attached patch (also available at:
http://geocar.googlepages.com/usocket-ecl-3.diff
) makes build.
What do I need to do in order to get it applied?
Geo,
did you test the patch with SBCL, too?
Also, it would be helpful if you could leave the brace style and indentation of the source code as it is. I agree that formatting should be regular and correct, yet reformatting changes should not be interleaved with functional changes as it makes reviewing a lot harder.
I can put the patch into my branch of the usocket repository once you have verified that it does not break SBCL.
-Hans
On Tue, May 27, 2008 at 7:28 PM, Geo Carncross geocar@gmail.com wrote:
Hello,
backend/sbcl.lisp doesn't appear to work at all with ECL. The attached patch (also available at:
http://geocar.googlepages.com/usocket-ecl-3.diff
) makes build.
What do I need to do in order to get it applied?
usocket-devel mailing list usocket-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/usocket-devel
On Tue, May 27, 2008 at 8:37 PM, Hans Hübner hans@huebner.org wrote:
Geo,
did you test the patch with SBCL, too?
Also, it would be helpful if you could leave the brace style and indentation of the source code as it is. I agree that formatting should be regular and correct, yet reformatting changes should not be interleaved with functional changes as it makes reviewing a lot harder.
I can put the patch into my branch of the usocket repository once you have verified that it does not break SBCL.
That would be great!
Thanks,
Erik.
-Hans
On Tue, May 27, 2008 at 7:28 PM, Geo Carncross geocar@gmail.com wrote:
Hello,
backend/sbcl.lisp doesn't appear to work at all with ECL. The attached patch (also available at:
http://geocar.googlepages.com/usocket-ecl-3.diff
) makes build.
What do I need to do in order to get it applied?
usocket-devel mailing list usocket-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/usocket-devel
usocket-devel mailing list usocket-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/usocket-devel
On Tue, May 27, 2008 at 5:53 PM, Erik Huelsmann ehuels@gmail.com wrote:
On Tue, May 27, 2008 at 8:37 PM, Hans Hübner hans@huebner.org wrote:
Geo,
did you test the patch with SBCL, too?
Also, it would be helpful if you could leave the brace style and indentation of the source code as it is. I agree that formatting should be regular and correct, yet reformatting changes should not be interleaved with functional changes as it makes reviewing a lot harder.
I can put the patch into my branch of the usocket repository once you have verified that it does not break SBCL.
Done. Also available at: http://geocar.googlepages.com/usocket-ecl-4.diff
Hunchentoot still runs with sbcl when usocket is patched with this.
ECL however, no longer does because the new flexi-streams which now assumes char-code-limit is greater than 256, so I don't have a big patch ready yet.
Geo,
the ECL patch to usocket is now in my branch of the usocket repository at svn://common-lisp.net/project/usocket/svn/usocket/branches/hans - You may want to give it a try.
-Hans
On Wed, May 28, 2008 at 4:34 AM, Geo Carncross geocar@gmail.com wrote:
On Tue, May 27, 2008 at 5:53 PM, Erik Huelsmann ehuels@gmail.com wrote:
On Tue, May 27, 2008 at 8:37 PM, Hans Hübner hans@huebner.org wrote:
Geo,
did you test the patch with SBCL, too?
Also, it would be helpful if you could leave the brace style and indentation of the source code as it is. I agree that formatting should be regular and correct, yet reformatting changes should not be interleaved with functional changes as it makes reviewing a lot harder.
I can put the patch into my branch of the usocket repository once you have verified that it does not break SBCL.
Done. Also available at: http://geocar.googlepages.com/usocket-ecl-4.diff
Hunchentoot still runs with sbcl when usocket is patched with this.
ECL however, no longer does because the new flexi-streams which now assumes char-code-limit is greater than 256, so I don't have a big patch ready yet.
-
Erik Huelsmann -
Geo Carncross -
Hans Hübner