February 2014 - alexandria-devel - mailman3.common-lisp.net

[alexandria-devel] latest alexandria doesn't build on ECL due to non-standard LOOP
by Anton Vodonosov 18 Jan '18

18 Jan '18

Hello. Alexandria in the latest quicklisp has a regression comparing to quicklisp 2012-02-08. It doesn't build on ECL because on non-standard LOOP construct (it is tolerated by most Lisps, but not by ECL; see here: http://comments.gmane.org/gmane.lisp.ecl.general/3344) The compiler complains about copy-stream method in io.lisp. Build logs: https://cl-test-grid.appspot.com/blob?key=AMIfv97xRRWJgLOa5TvS78VriRK9mQ82m… Best regards, - Anton

2 1

[alexandria-devel] Implementation of DELETE-FROM-PLIST
by Robert Smith 30 Jul '14

30 Jul '14

Hey: Here's a destructive/non-consing version of DELETE-FROM-PLIST. I've tested with (I think) all corner cases from the REPL, but I ought to write tests proper. The function is here http://tinyurl.com/adqkssu ;or the following huge link, in case the last one is invalidated https://bitbucket.org/tarballs_are_good/lisp-random/src/3db634111d35e788c6e… . For simplicity or ease of review from an email client, I've pasted the function at the end of this email. Additionally, this function would make it pretty easy to write DELETE-FROM-PLIST-IF{-NOT}, since the function to determine if a key is bad is factored out. If one did write this function, then it would be easy to define DELETE-FROM-PLIST in terms of it. Let me know if there are any changes that should be made. Cheers, Robert Smith ;;;; from delete-from-plist.lisp (defun delete-from-plist (plist &rest keys) "Delete all keys and pairs indicated by KEYS from the plist PLIST." (labels ((assert-proper-plist (x) (assert x () "Expected a proper plist, got ~S" plist)) (bad-key-p (key) (member key keys :test #'eq)) (find-first () "Find the first cons in PLIST to keep." (loop :for the-cons :on plist :by #'cddr :unless (prog1 (bad-key-p (car the-cons)) (assert-proper-plist (cdr the-cons))) :do (return the-cons) :finally (return nil)))) (declare (inline assert-proper-plist bad-key-p find-first)) ;; Find the first good key and delete any bad key-value pairs ;; between it and the start. (let ((first (find-first))) (unless (eq first plist) (setf (cddr plist) first)) ;; At this point, we know FIRST points to the first key ;; which exists, or NIL. (loop :with last-good := first ; Keep the last good key :for the-cons :on (cddr first) :by #'cddr :do (progn (assert-proper-plist (cdr the-cons)) (if (bad-key-p (car the-cons)) (setf (cddr last-good) (cddr the-cons)) (setf last-good the-cons))) :finally (return first)))))

5 17

[alexandria-devel] Bug in gaussian-random
by Andy Peterson 16 Feb '14

16 Feb '14

Hello, Four months ago, I reported a bug in gaussian-random when either optional parameter min or max is nil but not both are nil. The docstring has been modified since then but the code is still the same and the bug remains. In such a situation it is possible to enter an infinite loop. This is easy to demonstrate by the call (gaussian-random 0 nil). You may need to repeat the call a few times because the bug depends on the values returned by the first call to the local function gauss. An infinite loop will occur if gauss returns a negative number. I have attached a patch which fixes the bug. Sincerely, Andy Peterson

2 1