- asdf-devel - mailman3.common-lisp.net

Re: [asdf-devel] fare-utils build failure
by Faré 18 Jan '13

18 Jan '13

Cc'ng asdf-devel. On Wed, Jan 16, 2013 at 9:30 AM, Zach Beane <xach(a)xach.com> wrote: > Faré <fahree(a)gmail.com> writes: > >>> How do I get asdf-driver? >>> >> It's currently part of the asdf git tree. Should I make it separate? >> I think you can already include asdf-driver.asd without including asdf. > > What is the relationship between asdf-driver and asdf? What is a driver? > asdf uses asdf-driver. asdf-driver is currently distributed as part of the asdf source tree, but if that is an issue, there is no barrier to splitting it apart. For bootstrap purposes, the source code of asdf-driver is transcluded into asdf.lisp as a prelude to asdf, so asdf can rely on it. asdf-driver is a general purpose portability and runtime management library. It provides various abstraction layers for packages, pathnames, command-line arguments, compilation, condition-muffling, run-program, image dump and restore with hooks, basic I/O, etc. Basically, it's all the portability work I did over the last few years as part of asdf and xcvb, so as to be able to run user code unchanged (above the abstraction layer) on all supported lisp implementations. When rpgoldman convinced me that a portable, usable run-program should be part of asdf, whereas the legacy run-shell-command is an unusable unmaintainable unfixable crock, I decided to pull in the implementation from xcvb-driver. At the same time, drewc convinced me that having plenty of smaller files, with one package per file, was a good idea. I have been haunted for a few years for having failed janderson when he proposed to split asdf in parts; yet now asdf.lisp is much bigger than it was then, and at the same, having integrated bundle operations and figured out the dependency mess means it's easier and safer to write a general purpose source-concatenation operation. Finally you (Xach) convinced me that ASDF itself should not be a utility library, but only a build system; at the same time I really need the portability library, for XCVB as well as for ASDF and for any portable CL code I write. To top it all, after having completely reimplemented ASDF several times, I have started feeling much more comfortable with taking it apart and reassembling it in better ways. So there. I split ASDF in parts, and the part that's not specific to the system definition facility has been separated into asdf-driver. On most implementations, you can upgrade asdf-driver on top of an old ASDF -- though I admit I haven't yet added this situation to my automated testing regime. (The outlier as usual is CLISP, which is very funky to upgrade, and I don't know how to do things short of deleting the ASDF package when there's an incompatibility, which isn't conducive to upgrading ASDF-DRIVER far beyond ASDF; but I have ideas on how to make things a little bit more usable.) —♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org If I go through life free and rich, I shall not cry because my neighbour, equally free, is richer. Liberty will ultimately make all men rich; it will not make all men equally rich. Authority may (and may not) make all men equally rich in purse; it certainly will make them equally poor in all that makes life best worth living. — Benjamin Tucker

2 6

[asdf-devel] More test results
by Robert Goldman 17 Jan '13

17 Jan '13

ccl now passes. clisp fails to build ASDF successfully: + clisp -norc --silent -ansi -I -on-error exit -x '(or #.(load "test/script-support.lisp") #.(asdf-test::compile-asdf-script))' [3]> ;; Loading file test/script-support.lisp ... ;; Loading file /Users/rpg/lisp/asdf/build/asdf.lisp ... ;; Loaded file /Users/rpg/lisp/asdf/build/asdf.lisp TEST ABORTED: READ from #<INPUT BUFFERED FILE-STREAM CHARACTER #P"/Users/rpg/lisp/asdf/build/asdf.lisp" @7809>: there is no package with name "ASDF" Script failed Compilation FAILED still 9 tests failing on Allegro 8.2: asdf-pathname-test.script test-force.script test-module-depend.script test-module-excessive-depend.script test-static-and-serial.script test-touch-system-1.script test-touch-system-2.script test1.script test3.script didn't bother with allegromodern yet... SBCL passes ECL goes ape-execrement, and goes into what looks like an infinite loop in error-handling on test test-retry-loading-component-1.script. Seemingly infinite flood of the following: ASDF/LISP-BUILD::STATUS Caught error #<a UNBOUND-VARIABLE> trlc1 5 trlc1 6 ASDF-TEST::NAME => ASDF/FIND-COMPONENT:RETRY ASDF-TEST::MODE => :EXTERNAL trlc1 7 ASDF-TEST::NAME => ASDF/FIND-COMPONENT:RETRY RESTART => #<RESTART.4389276816> ABCL compilation failed for me: Testsuite failed: ASDF compiled with unexpected warnings Compilation FAILED + abcl --noinit --nosystem --noinform --eval '(or #.(load "test/script-support.lisp") #.(asdf-test::compile-asdf-script))' ; in (ASDF/UTILITY:DEFUN* BUNDLABLE-FILE-P ...) ; Caught STYLE-WARNING: ; The variable TYPE is defined but never used. Looks like this happens because none of the #+ conditional compilation cases gives ABCL any love in this function. Best, r

2 1

[asdf-devel] asdf-encodings?
by Raymond Toy 16 Jan '13

16 Jan '13

Is this the right place to talk about asdf-encodings? Apologies if this is the wrong place. One minor issue with asdf-encodings and cmucl: It looks like find-implementation-encoding does not expect an error for unknown encodings, so for cmucl, the implementation should be #+cmu (ignore-errors (stream::find-external-format encoding)) Also, once asdf-encodings is loaded, compiles with asdf fail because cl:compile-file is called with :external-format set to the external format object instead of the name. To get the name from the object, use (stream::ef-name obj). I don't know where that should be applied. BTW, make test lisp=cmucl CMUCL=cmulisp passes 41 tests, but there are some warnings like loading level1/file1 Warning: compiling #<STATIC-FILE "test-module-pathnames" "sources/level1" "level2/static.file"> completed without its input file #P"/home/rtoy/src/clnet/asdf/test/sources/level1/level2/static.file" Don't know if that's significant or not. Ray

2 2

[asdf-devel] News on the front
by Faré 15 Jan '13

15 Jan '13

Dear Lisp hackers, I've completed yet another major pass of refactoring of ASDF. It is now divided into many files, that are concatenated together for single-file delivery. (An idea that I once rejected when James Anderson proposed it 3 years ago; he might have known better. The file has more than quadrupled in size since.) >From a pristine git checkout, you can concatenate them from the command-line with make build/asdf.lisp or from lisp with a recent bootstrapped asdf.lisp with (asdf:operate 'asdf::concatenate-source-op :generate-asdf) About 45% of ASDF is utilities, and those are now available through a semi-independent system asdf-driver. See make wc wc-driver wc-asdf. I'have notably moved in run-program/ from xcvb-driver, and its native-namestring support, by popular demand, which increased this number. I brought in the condition-control code and image support from xcvb-driver as well; I'll be working to package them better. Hot upgrade is preserved through the heroic development of define-package, an extension to defpackage that makes things as declared from however they were, instead of throwing an error at the first discrepancy. You better know what you want. As a result from this and all the package declarations, plus the bundle and concatenate support, ASDF has swollen 60% in size since 2.26, or 42% since I merged in asdf-bundle in 2.26.7. I'll argue that the functionality is also much improved, including the fixing of the fundamental build model that I've discussed in previous emails. I won't release anything until all the packages in quicklisp work, and I'll have to install cl-test-grid for that, but I invite those of you who are interested to test it and/or comment on the changes. It looks like I mostly understand ASDF these days. —♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org Every technique is first developed, then used, important, obsolete, normalized, and finally understood.

3 5

[asdf-devel] Status update on tests
by Robert Goldman 15 Jan '13

15 Jan '13

CCL fails on test-static-and-serial.script TEST ABORTED: These two expressions fail comparison with EQUAL: (FILE-WRITE-DATE FILE1) evaluates to 3567182153 DATE3 evaluates to 3567182002 Same failure on allegro. Allegro (8.2) has 6 failures all told: test-force.script test-static-and-serial.script test-touch-system-1.script test-touch-system-2.script test1.script test3.script On allegro there are a large number of date comparison failures. TEST ABORTED: the assertion (EQUAL (FILE-WRITE-DATE FILE1) DATE2) TEST ABORTED: These two expressions fail comparison with EQUAL: TEST ABORTED: These two expressions fail comparison with EQUAL: TEST ABORTED: the assertion (> DATE2 DATE1) failed. TEST ABORTED: These two expressions fail comparison with EQUAL: TEST ABORTED: the assertion (NOT (PROBE-FILE FASL2)) failed. More results as I can grab time to collect them. cheers, r

2 4

[asdf-devel] Test results: one failure on CCL
by Robert Goldman 14 Jan '13

14 Jan '13

Running test-all-noupgrade, CCL fails for me on test-encodings.script: Testing: test-encodings.script + /Users/rpg/ccl/dx86cl64 --no-init --quiet --eval '(load "test-encodings.script")' Test TEST-ENCODING-EXPLICIT-U8: should be UTF-8 ; Registering #<SYSTEM "test-encoding-explicit-u8"> TEST ABORTED: Component "asdf-encodings" not found Looks like this might be a simple bundling problem? Mac OS X, CCL 1.8 cheers, r

2 4

[asdf-devel] Tests fail oddly on Allegro 8.2
by Robert Goldman 14 Jan '13

14 Jan '13

All the tests reported as failing to me. When I ran with -d, I see this in the transcript: (:RESULT :TYPE "International Allegro CL Enterprise Edition" :VERSION "8.2 [64-bit Mac OS X (Intel)] (Oct 1, 2012 17:20)" :FILE #P"/Users/rpg/lisp/asdf/build/results/alisp-pathnames.txt" :SYSTEM-FAILURES (0 320) :DIRECTORY-FAILURES (0 1280) :FILE-FAILURES (0 1920) :HOMOGENEOUS 0) Script succeeded and then I drop out of the script, after having run only 1 test. So I'm wondering if there's something wrong in the way the test results are accumulated by the script.. Cheers, r

2 1

[asdf-devel] ASDF shipped with the latest Quicklisp-client doesn't work on Allegro CL 8.1
by Xiaofeng Yang 12 Jan '13

12 Jan '13

I'm sorry for this duplicated mail. I forgot to write the subject for the previous mail . Hi, all The ASDF shipped with latest Quicklisp-client doesn't work on Allegro CL 8.1 correctly. So I fixed it and made an ugly patch for it. I'm so sorry I don't know whether this is the right place to discuss this problem, so I will then add this issus to the quicklisp-bootstrap project. The problem and patch can also be found here: https://github.com/nakrakiiya/acl-patches/commit/86236e11d89765a15fe44c0ede… FIX: `Illegal keyword given: :EXTERNAL-FORMAT.' while executing `(quicklisp-quickstart:install)'. Details: CL-USER> (quicklisp-quickstart:install) ; Loading D:\Documents and Settings\nakra\quicklisp\setup.lisp Illegal keyword given: :EXTERNAL-FORMAT. [Condition of type PROGRAM-ERROR] Restarts: 0: [RETRY] Retry compiling #<CL-SOURCE-FILE "quicklisp" "package">. 1: [ACCEPT] Continue, treating compiling #<CL-SOURCE-FILE "quicklisp" "package"> as having been successful. 2: [RETRY] retry the load of D:\Documents and Settings\nakra\quicklisp\setup.lisp 3: [SKIP] skip loading D:\Documents and Settings\nakra\quicklisp\setup.lisp 4: [RECOMPILE-DUE-TO-INCOMPATIBLE-FASL] recompile D:\Documents and Settings\nakra\quicklisp\setup.lisp 5: [RETRY] Retry SLIME REPL evaluation request. --more-- Backtrace: 0: (ERROR PROGRAM-ERROR :FORMAT-CONTROL "Illegal keyword given: ~s." :FORMAT-ARGUMENTS (:EXTERNAL-FORMAT)) 1: (COMPILE-FILE-PATHNAME "x.lisp" ..) 2: (ASDF:COMPILE-FILE-PATHNAME* #P"D:\\Documents and Settings\\nakra\\quicklisp\\quicklisp\\package.lisp" :OUTPUT-FILE ..) 3: (ASDF:COMPILE-FILE* #P"D:\\Documents and Settings\\nakra\\quicklisp\\quicklisp\\package.lisp" :OUTPUT-FILE ..) 4: ((:INTERNAL (METHOD ASDF:PERFORM (ASDF:COMPILE-OP ASDF:CL-SOURCE-FILE)) 0)) 5: ((METHOD ASDF::CALL-WITH-AROUND-COMPILE-HOOK (ASDF:COMPONENT T)) #<ASDF:CL-SOURCE-FILE "quicklisp" "package"> #<Closure (:INTERNAL (METHOD ASDF:PERFORM #) 0) @ #x2143fc7a>) 6: ((METHOD ASDF:PERFORM (ASDF:COMPILE-OP ASDF:CL-SOURCE-FILE)) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 7: ((:INTERNAL (:EFFECTIVE-METHOD 2 NIL NIL NIL NIL) 0) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 8: ((METHOD ASDF::PERFORM-WITH-RESTARTS (T T)) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 9: ((METHOD ASDF::PERFORM-WITH-RESTARTS :AROUND (T T)) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 10: ((:INTERNAL (:EFFECTIVE-METHOD 2 NIL NIL T T) 0) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 11: ((FLET (METHOD ASDF::PERFORM-PLAN (LIST)) EXCL::CONTINUATION)) 12: ((METHOD ASDF::PERFORM-PLAN (LIST)) ..) 13: ((:INTERNAL (:EFFECTIVE-METHOD 1 T T NIL NIL) 0) ..) 14: ((:INTERNAL (METHOD ASDF:OPERATE (T T)) 0)) 15: (ASDF::CALL-WITH-SYSTEM-DEFINITIONS #<Closure (:INTERNAL (METHOD ASDF:OPERATE #) 0) [LOAD-OP] @ #x213d36da>) 16: ((METHOD ASDF:OPERATE (T T)) ASDF:LOAD-OP "quicklisp" :VERBOSE NIL) 17: ((:INTERNAL (:EFFECTIVE-METHOD 2 T NIL NIL NIL) 0) ASDF:LOAD-OP "quicklisp" . 1) 18: (ASDF:OOS ASDF:LOAD-OP "quicklisp" :VERBOSE NIL) 19: (LET ((*COMPILE-PRINT* NIL) (*COMPILE-VERBOSE* NIL) (*LOAD-VERBOSE* NIL) (*LOAD-PRINT* NIL)) (ASDF:OOS 'ASDF:LOAD-OP "quicklisp" :VERBOSE NIL)) --more-- The diff from the origin asdf.lisp file: $ git diff 6d465f92b240fe5ded55447f9a000a1e54a7a22a 86236e11d89765a15fe44c0ede40119ed4958c3c diff --git a/8.1/quicklisp-client-2012112500/asdf.lisp b/8.1/quicklisp-client-2012112500/asdf.lisp index 283ad86..2f9b98a 100644 --- a/8.1/quicklisp-client-2012112500/asdf.lisp +++ b/8.1/quicklisp-client-2012112500/asdf.lisp @@ -2478,7 +2478,10 @@ recursive calls to traverse.") c #'(lambda (&rest flags) (apply *compile-op-compile-file-function* source-file :output-file output-file - :external-format (component-external-format c) + #+(or (and allegro (version>= 8 2)) + (not allegro)) :external-format + #+(or (and allegro (version>= 8 2)) + (not allegro)) (component-external-format c) (append flags (compile-op-flags operation))))) (unless output (error 'compile-error :component c :operation operation)) Best regards, Xiaofeng Yang

3 4

[asdf-devel] (no subject)
by Xiaofeng Yang 12 Jan '13

12 Jan '13

Hi, all The ASDF shipped with latest Quicklisp-client doesn't work on Allegro CL 8.1 correctly. So I fixed it and made an ugly patch for it. I'm so sorry I don't know whether this is the right place to discuss this problem, so I will then add this issus to the quicklisp-bootstrap project. The problem and patch can also be found here: https://github.com/nakrakiiya/acl-patches/commit/86236e11d89765a15fe44c0ede… FIX: `Illegal keyword given: :EXTERNAL-FORMAT.' while executing `(quicklisp-quickstart:install)'. Details: CL-USER> (quicklisp-quickstart:install) ; Loading D:\Documents and Settings\nakra\quicklisp\setup.lisp Illegal keyword given: :EXTERNAL-FORMAT. [Condition of type PROGRAM-ERROR] Restarts: 0: [RETRY] Retry compiling #<CL-SOURCE-FILE "quicklisp" "package">. 1: [ACCEPT] Continue, treating compiling #<CL-SOURCE-FILE "quicklisp" "package"> as having been successful. 2: [RETRY] retry the load of D:\Documents and Settings\nakra\quicklisp\setup.lisp 3: [SKIP] skip loading D:\Documents and Settings\nakra\quicklisp\setup.lisp 4: [RECOMPILE-DUE-TO-INCOMPATIBLE-FASL] recompile D:\Documents and Settings\nakra\quicklisp\setup.lisp 5: [RETRY] Retry SLIME REPL evaluation request. --more-- Backtrace: 0: (ERROR PROGRAM-ERROR :FORMAT-CONTROL "Illegal keyword given: ~s." :FORMAT-ARGUMENTS (:EXTERNAL-FORMAT)) 1: (COMPILE-FILE-PATHNAME "x.lisp" ..) 2: (ASDF:COMPILE-FILE-PATHNAME* #P"D:\\Documents and Settings\\nakra\\quicklisp\\quicklisp\\package.lisp" :OUTPUT-FILE ..) 3: (ASDF:COMPILE-FILE* #P"D:\\Documents and Settings\\nakra\\quicklisp\\quicklisp\\package.lisp" :OUTPUT-FILE ..) 4: ((:INTERNAL (METHOD ASDF:PERFORM (ASDF:COMPILE-OP ASDF:CL-SOURCE-FILE)) 0)) 5: ((METHOD ASDF::CALL-WITH-AROUND-COMPILE-HOOK (ASDF:COMPONENT T)) #<ASDF:CL-SOURCE-FILE "quicklisp" "package"> #<Closure (:INTERNAL (METHOD ASDF:PERFORM #) 0) @ #x2143fc7a>) 6: ((METHOD ASDF:PERFORM (ASDF:COMPILE-OP ASDF:CL-SOURCE-FILE)) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 7: ((:INTERNAL (:EFFECTIVE-METHOD 2 NIL NIL NIL NIL) 0) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 8: ((METHOD ASDF::PERFORM-WITH-RESTARTS (T T)) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 9: ((METHOD ASDF::PERFORM-WITH-RESTARTS :AROUND (T T)) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 10: ((:INTERNAL (:EFFECTIVE-METHOD 2 NIL NIL T T) 0) #<ASDF:COMPILE-OP (:VERBOSE NIL) @ #x213d60c2> #<ASDF:CL-SOURCE-FILE "quicklisp" "package">) 11: ((FLET (METHOD ASDF::PERFORM-PLAN (LIST)) EXCL::CONTINUATION)) 12: ((METHOD ASDF::PERFORM-PLAN (LIST)) ..) 13: ((:INTERNAL (:EFFECTIVE-METHOD 1 T T NIL NIL) 0) ..) 14: ((:INTERNAL (METHOD ASDF:OPERATE (T T)) 0)) 15: (ASDF::CALL-WITH-SYSTEM-DEFINITIONS #<Closure (:INTERNAL (METHOD ASDF:OPERATE #) 0) [LOAD-OP] @ #x213d36da>) 16: ((METHOD ASDF:OPERATE (T T)) ASDF:LOAD-OP "quicklisp" :VERBOSE NIL) 17: ((:INTERNAL (:EFFECTIVE-METHOD 2 T NIL NIL NIL) 0) ASDF:LOAD-OP "quicklisp" . 1) 18: (ASDF:OOS ASDF:LOAD-OP "quicklisp" :VERBOSE NIL) 19: (LET ((*COMPILE-PRINT* NIL) (*COMPILE-VERBOSE* NIL) (*LOAD-VERBOSE* NIL) (*LOAD-PRINT* NIL)) (ASDF:OOS 'ASDF:LOAD-OP "quicklisp" :VERBOSE NIL)) --more-- The diff from the origin asdf.lisp file: $ git diff 6d465f92b240fe5ded55447f9a000a1e54a7a22a 86236e11d89765a15fe44c0ede40119ed4958c3c diff --git a/8.1/quicklisp-client-2012112500/asdf.lisp b/8.1/quicklisp-client-2012112500/asdf.lisp index 283ad86..2f9b98a 100644 --- a/8.1/quicklisp-client-2012112500/asdf.lisp +++ b/8.1/quicklisp-client-2012112500/asdf.lisp @@ -2478,7 +2478,10 @@ recursive calls to traverse.") c #'(lambda (&rest flags) (apply *compile-op-compile-file-function* source-file :output-file output-file - :external-format (component-external-format c) + #+(or (and allegro (version>= 8 2)) + (not allegro)) :external-format + #+(or (and allegro (version>= 8 2)) + (not allegro)) (component-external-format c) (append flags (compile-op-flags operation))))) (unless output (error 'compile-error :component c :operation operation)) Best regards, Xiaofeng Yang

1 0

[asdf-devel] CCL build failure
by Robert Goldman 10 Jan '13

10 Jan '13

CCL 1.8 on Mac OS X fails to compile asdf as pulled just now. Not-very-helpful transcript snippet: COMPONENT-DEPENDS-ON [Defmethod] COMPONENT-DEPENDS-ON [Defmethod] COMPONENT-DEPENDS-ON [Defmethod] COMPONENT-DEPENDS-ON [Defmethod] COMPONENT-DEPENDS-ON [Defmethod] COMPONENT-DEPENDS-ON [Defmethod] COMPONENT-DEPENDS-ON [Defmethod] COMPONENT-DEPENDS-ON [Defmethod] Toplevel Forms... Toplevel Forms... Toplevel Forms... Toplevel Forms... ions of (:METHOD PERFORM (LOAD-OP CL-SOURCE-FILE)), in this file Testsuite failed: ASDF compiled with ERRORS Interactively, interestingly, when I try to build from an asdf:*central-registry* with home:lisp;asdf; in it, I get this error: Error while trying to load definition for system asdf from pathname home:lisp;asdf;asdf.asd.newest: Illegal logical namestring "/Users/rpg/lisp/asdf/asdf.asd" [Condition of type ASDF:LOAD-SYSTEM-DEFINITION-ERROR] No idea what that's about. When I use /Users/rpg/lisp/asdf/ instead, it works fine. Interactively, I get: ;Compiler warnings for "home:lisp;asdf;asdf.lisp.newest" : ; In an anonymous lambda form at position 220553: Duplicate definitions of (:METHOD PERFORM (LOAD-OP CL-SOURCE-FILE)), in this file ; Warning: COMPILE-FILE failed while performing #<COMPILE-OP > on #<CL-SOURCE-FILE "asdf" "asdf">. ; While executing: #<STANDARD-METHOD ASDF:PERFORM (ASDF:COMPILE-OP ASDF:CL-SOURCE-FILE)>, in process repl-thread(14). ; Warning: COMPILE-FILE warned while performing #<COMPILE-OP > on #<CL-SOURCE-FILE "asdf" "asdf">. ; While executing: #<STANDARD-METHOD ASDF:PERFORM (ASDF:COMPILE-OP ASDF:CL-SOURCE-FILE)>, in process repl-thread(14). So are the redefinitions breaking the update?

2 5