- asdf-devel - mailman3.common-lisp.net

[asdf-devel] Fwd: Re: asdf:run-shell-command - fix, delete or don't touch?
by Robert Goldman 07 Oct '11

07 Oct '11

Here's my response from last night. The mailing list doesn't seem to like my alternative address. cheers, r

1 0

Re: [asdf-devel] Repeat file compilation
by Сергей Катревич 06 Oct '11

06 Oct '11

O please do not rush. Simplify perform-with-restart is good way. But your last patch: - or makes the new version asdf is not backward compatible - or provides an error (implicitly, rarely appears) perform-with-restart is generic function with methods that may defining with system definition in *.asd files (by :perform-with-restart keyword). This feature provided code: (defparameter +asdf-methods+ '(perform-with-restarts perform ...) (defun* %remove-component-inline-methods (component) (dolist (name +asdf-methods+) ...)) (defun* fine-component-inline-methods (ret rest) ;; !!! rest may be contain keyword :perform-with-restart (it defining "inline method") (dolist (name +asdf-methods+) ...)) calls: parse-component-form -> %refresh-component-inline-methods -> %remove-component-inline-methods -> fine-component-inline-methods This means that: we need in the (call-next-method) Please review my definition perform-with-restarts for compile-op and make analogue (if good code) for load-op: (defmethod perform-with-restarts ((o compile-op) (c cl-source-file)) (loop :with state :until (eq state :success) :do (restart-case (progn (call-next-method) (setf state :success)) (try-recompiling () :report (lambda (s) (format s (compatfmt "~@<Try recompiling ~a.~@:>") (component-name c))) )))) P.S. I run it and checked - the code solves the problem Чтв 06 Окт 2011 05:12:39 +0400, Far <fahree(a)gmail.com> написал: > I rewrote the perform-with-restarts methods based on what I understand > they *should* be doing, > and without any of the state machine complication that I never quite > got the hang of. > > Can you tell me if ASDF works better for you with the attached patch? > I passes all self-tests for me (on SBCL), but I admit I haven't tried > hard to trigger the case. > If it works for you, I'll commit it. > > I don't suppose anyone wants to write a test case for that. Sigh. > So I may have to myself write a file that includes a state machine > for compile-time and/or load-time failure. > Yay defvar and eval-when... > > —♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org > >

1 0

[asdf-devel] Repeat file compilation
by Сергей Катревич 06 Oct '11

06 Oct '11

Hi Lispers! I research sources ASDF Library. I am not understand: Why repeat the compilation of a file (below code and details)? (defmethod perform-with-restarts ((o compile-op) (c cl-source-file)) (loop :with state = :initial :until (or (eq state :success) (eq state :failure)) :do (case state (:recompiled (setf state :failure) (call-next-method) (setf state :success)) (:failed-compile (setf state :recompiled) (perform-with-restarts o c)) (t (with-simple-restart (try-recompiling "Try recompiling ~a" (component-name c)) (setf state :failed-compile) (call-next-method) (setf state :success)))))) This is bad for me: my code evaluated twice (eval-when (:compile-toplevel) ...) in a file that i am recompiled throghout select try-recompiling restart. Details. 1. (setf state :failed-compiled) 2. error compilation. 3. select try-recompiling restart. 4. next iteration. 5. (setf state :recompiled) 6. recursive call: (perform-with-restarts o c) (in recusive-call) 6.1 (setf state :failed-compile) 6.2 (call-next-method) = success compile 6.3 (setf state :success) 6.4 next iteration and exit call. 7. next iteration 8. (setf state :failure) 9. (call-next-method) - second compilation! ??? I understand that (call-next-method) conceptual feature. But the file should not compile twice! Suggestions?

2 2

[asdf-devel] Please test ASDF 2.017.6
by Faré 03 Oct '11

03 Oct '11

I applied Juanjo's patch for testing with ecl-bytecmp. Only affect test files. Considering that there's been no action on the source code since last week, I propose that current version 2.017.6 is a pre-release for 2.018. Or maybe I'll call it 2.18 and loose the 0 which isn't very meaningful anymore? Please test thoroughly. I intend to make a release after one more week or two of inaction. So far, since 2.017: fix a component reuse bug noticed by Xach, and minor portability improvements with ECL, and minor testing improvements for ECL and SCL; everything relatively minor means we're slowly converging to something stable. —♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org

2 5

[asdf-devel] Suggested patches for ASDF
by Juan Jose Garcia-Ripoll 20 Sep '11

20 Sep '11

Apart from some documentation and copyright notices, two major changes: - ECL will support two compilers. ASDF needs to be aware of that. - The plug-in for REQUIRE allows ECL users to supply another default operator. LOAD-FASL-OP is recommended because it builds each library into a single shared library, saving resources. Juanjo -- Instituto de Física Fundamental, CSIC c/ Serrano, 113b, Madrid 28006 (Spain) http://juanjose.garciaripoll.googlepages.com

4 25

[asdf-devel] Troubles with ASDF:RUN-SHELL-COMMAND
by Robert Goldman 19 Sep '11

19 Sep '11

As a side-effect of trying to export ASDF:*VERBOSE-OUTPUT*, to catch the output from RUN-SHELL-COMMAND, I created a test to verify that it was behaving properly. Boy, was that a mistake! I found that, in fact, ASDF:RUN-SHELL-COMMAND was not working on (at least) ACL, when faced with a command that had embedded double-quotes. See launchpad bug: https://bugs.launchpad.net/bugs/853566 I have fixed this and pushed the fix and the tests to the branch named 'run-shell-command' on cl.net. I would be VERY grateful if others would run the test on other lisps and other platforms. I would be especially grateful if people would run the tests on windows, since I don't really have a good understanding of how RUN-SHELL-COMMAND should work on that platform. I think it's bad that RUN-SHELL-COMMAND doesn't work properly, but I don't want to push these mods as a new version of ASDF until they run everywhere. Best, Robert

1 0

[asdf-devel] Export asdf::*verbose-out*?
by Robert Goldman 15 Sep '11

15 Sep '11

The user needs to bind asdf::*verbose-out* to something in order to see what happens when executing a command through asdf:run-shell-command. Given that the user is to do this, shouldn't this symbol be exported from the ASDF package? best, r

1 0

Re: [asdf-devel] Pathname failures on ASDF 2.017.4 on SCL 1.3.9
by Faré 14 Sep '11

14 Sep '11

Dear ASDF developers, there were test failures recently in SCL, and Douglas Crosher found that they were related to the semantics of merge-pathnames*. I'm not sure anymore what merge-pathnames does, how its current behavior differs from SCL's ext:resolve-pathname, and more importantly, what it should be doing, so I'm thinking aloud and maybe one of you will catch something. >>>: Douglas Crosher >>: Fare >: Douglas Crosher >>> The SCL requires slightly different code in merge-pathnames* >>> which seems to have been causing the issue. >>> >>> The issue occurs because pathnames in the test do not have a host etc >>> so are resolved relative to a logical-pathname host: >>> >>> (merge-pathnames* "/home/mod1/file.lisp" #p"ASDFTEST:SRC;") >>> => #p"ASDFTEST:HOME;MOD1;FILE.LISP.NEWEST" >>> >>> Adding the host etc gives the following and corrects the issue: >>> >>> (merge-pathnames* "file://localhost/home/mod1/file.lisp" >>> #p"ASDFTEST:SRC;") >>> => #p"file://localhost/home/mod1/file.lisp" >>> >>> I can't see any reason why a pathname with an absolute directory >>> should be handled specially in merge-pathnames* and the following >>> example seems right for the SCL: >>> >>> (merge-pathnames* "/home/mod1/file.lisp" #p"http://host/") >>> => #p"http://host/home/mod1/file.lisp" >>> >> The reason why merge-pathnames* does this is because >> we want to treat the merging of relative pathnames specially: >> based on defsystem specifications, we have pathnames that are relative >> to wherever the .asd file is; however, at the time the user specifies >> those relative pathnames, and as he does some merging operations on them, >> he has no idea what kind of implementation will be present and what >> host (logical or physical), device, etc., will be used for the pathname. >> Therefore, I needed this abstraction (and accompanying syntax) for >> "pathnames wherein a relative pathname does not specify host or device, >> but an absolute pathname does". >> >> I suppose there's a slight mismatch with scl's ext:resolve-pathname. >> Instead of your first patch, >> maybe merge-pathnames* shouldn't just call that latter function, >> but do some more wrapping around it? > > The SCL's ext:resolve-pathname seems to handle the relative paths just fine, > and works with URLs. > > The problem occurred when the system definition specified a path with an > absolute directory and no host or device. > The SCL's ext:resolve-pathname will resolve such a path relative to the base > host etc which I think is useful. > > Consider a standard CL example of a system definition with a base pathname > which is a logical pathname. In this case it would be reasonable to have a > component pathname with an absolute directory and no host be resolved > relative to the base logical pathname - which is what the SCL's > ext:resolve-pathname will do. The current behaviour of merge-pathname* is > to simply ignore the default host and device for a pathname with an absolute > directory which does not seem useful. Perhaps you could consider modifying > merge-pathname* to merge the host and device for pathname with an absolute > directory rather than ignoring the defaults in this case. > > This issue is hard to describe, but I may be able to come up with a new test > for it. > OK. I think I get it. The issue is that at least *some* CL implementations (for instance clisp) use a NIL pathname-host for normal Unix absolute pathnames. In that case, the host being NIL doesn't mean "host unspecified", but "normal absolute pathname", and it is wrong to replace it with a say logical host from the defaults. Maybe the "right thing" then is to identify, in each implementation, what is the canonical way of representing the possible "absolute pathname referring to some default toplevel filesystem" as opposed to possibly "absolute pathname depending on unspecified host", and keep a NIL in the first case (where that applies) but not the other case. Then, the asdf-pathname-test would have to be updated to do the right thing with those two cases (whichever applies). It seems that your ext:resolve-pathnames might already be doing this "right thing" — except maybe when a relative pathname is specified with a host? NB: to maximize the chances of pathnames being created with the correct host and device, maybe load-sysdef should bind *default-pathname-defaults* to (pathname-directory-pathname pathname) around load? Oh noes, more portability issues with CL pathnames! At that point, I'll just weep. —♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org

1 0

[asdf-devel] ECL tests on the Mac
by Robert Goldman 14 Sep '11

14 Sep '11

I just installed ECL from MacPorts, and when I run the test suite I get a failure. Using ecl -norc Ran 35 tests: 34 passing and 1 failing failing test(s): test-configuration.script Should I expect this? best, r

3 10

Re: [asdf-devel] Unexpected behavior when loading different versions of a system
by Daniel Herring 07 Sep '11

07 Sep '11

On Tue, 6 Sep 2011, Robert P. Goldman wrote: > P.S. I'd be interested in feedback about the use I made of git here. I > *could* have squashed the series of commits that ended up with the patch > you see here, but in the end, I decided that it might be helpful for > people to see in the history the blind alley that I pursued, because it > seemed like a simpler fix to begin with. db16d0..8f5e2d I frequently like my history to show stuff like this. Some people prefer a clean, "always works" history. One approach is to treat the development work as a branch and merge it back into master with the summary message you would use in the squash. I think this caters to both styles. - Daniel

1 0