[asdf-devel] defsystem :version (:read-file-line ...) fails because :at key isn't recognized
Hi, Basically, the problem is described in the message header. Whereas :read-file-form option is used by ASDF itself, :read-file-line isn't used and wasn't tested. Attached is a patch with relevant test cases and fixes. I would also suggest refactoring the code, because the code paths for :read-file-form and :read-file-line are almost identical, but are implemented in separate functions. Best regards, Vsevolod Dyomkin +38-096-111-41-56 skype, twitter: vseloved
Vsevolod Dyomkin wrote:
Hi,
Basically, the problem is described in the message header. Whereas :read-file-form option is used by ASDF itself, :read-file-line isn't used and wasn't tested.
Attached is a patch with relevant test cases and fixes.
I would also suggest refactoring the code, because the code paths for :read-file-form and :read-file-line are almost identical, but are implemented in separate functions.
Best regards,
Vsevolod Dyomkin +38-096-111-41-56 skype, twitter: vseloved
Thank you very much. I have applied the patch to my working copy and am testing it now prior to pushing it. Best, Robert
Vsevolod Dyomkin wrote:
Hi,
Basically, the problem is described in the message header. Whereas :read-file-form option is used by ASDF itself, :read-file-line isn't used and wasn't tested.
Attached is a patch with relevant test cases and fixes.
I would also suggest refactoring the code, because the code paths for :read-file-form and :read-file-line are almost identical, but are implemented in separate functions.
Best regards,
Vsevolod Dyomkin +38-096-111-41-56 skype, twitter: vseloved
I have incorporated this patch as written (no refactoring -- sorry, I have been too busy), and together with some documentation tweaks, have pushed it as 3.0.2.4. This is still a release candidate. I won't make 3.0.3 until we have the directory pathname ticket fixes in and tested, and we have some test reports from others. I haven't been testing on anything but Mac OS X Lion for a while now, and I don't know that /anyone/ has been testing on Windows. Best, Robert
1- My apologies for the omission of read-file-line in uiop/stream. Oops. Thanks for catching this. 2- reading a line doesn't involve the reader, only read-line, and so a "safe" version is entirely superfluous, and an api for that seems bogus to me. 3- Does the test suite run on Windows at all? I've never tried. —♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org The highest goal of computer science is to automate that which can be automated. — Derek L. VerLee On Thu, Aug 15, 2013 at 11:29 PM, Robert Goldman <rpgoldman@sift.info>wrote:
Vsevolod Dyomkin wrote:
Hi,
Basically, the problem is described in the message header. Whereas :read-file-form option is used by ASDF itself, :read-file-line isn't used and wasn't tested.
Attached is a patch with relevant test cases and fixes.
I would also suggest refactoring the code, because the code paths for :read-file-form and :read-file-line are almost identical, but are implemented in separate functions.
Best regards,
Vsevolod Dyomkin +38-096-111-41-56 skype, twitter: vseloved
I have incorporated this patch as written (no refactoring -- sorry, I have been too busy), and together with some documentation tweaks, have pushed it as 3.0.2.4.
This is still a release candidate. I won't make 3.0.3 until we have the directory pathname ticket fixes in and tested, and we have some test reports from others. I haven't been testing on anything but Mac OS X Lion for a while now, and I don't know that /anyone/ has been testing on Windows.
Best, Robert
Faré wrote:
3- Does the test suite run on Windows at all? I've never tried.
Dave Cooper had a whack at it, and it didn't work out of the box, but it didn't seem like it would be impossible, if a cygwin installation could appropriately be wired together with lisp. I'm not sure how one would handle/test the oddities of the dual Unix-style/Windows-style pathnames. I'm mostly familiar with Allegro, which makes Unix-style pathnames work on Windows. cheers, r
I haven't really tried it yet. I'm still on a road trip without much time at computer or net connectivity, will be home this weekend, and plan to get asdf testing set up starting next week. Once the basics are working I will have a go with Windows configurations (at least with Allegro and CCL). On Fri, Aug 16, 2013 at 9:23 AM, Robert Goldman <rpgoldman@sift.info> wrote:
Faré wrote:
3- Does the test suite run on Windows at all? I've never tried.
Dave Cooper had a whack at it, and it didn't work out of the box, but it didn't seem like it would be impossible, if a cygwin installation could appropriately be wired together with lisp.
I'm not sure how one would handle/test the oddities of the dual Unix-style/Windows-style pathnames. I'm mostly familiar with Allegro, which makes Unix-style pathnames work on Windows.
cheers, r
-- My Best, Dave Cooper, Genworks Support david.cooper@genworks.com, dave.genworks.com(skype) USA: 248-327-3253(o), 1-248-330-2979(mobile) UK: 0191 645 1699
participants (4)
-
Dave Cooper -
Faré -
Robert Goldman -
Vsevolod Dyomkin