- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][master] 2 commits: Fix a double free detected by the GCC analyzer
by Carl Shapiro (＠cshapiro) 25 Apr '24

25 Apr '24

Carl Shapiro pushed to branch master at cmucl / cmucl Commits: 729fae26 by Carl Shapiro at 2024-04-25T01:15:17-07:00 Fix a double free detected by the GCC analyzer The obuffer variable contained a pointer to a block of memory freed by realloc(3) if the ERANGE case was executed more than once. Afterward, if the 0 case executed, obuffer would be passed to free(3) causing a double free. This change sets the value of obuffer to buffer immediately after a successful call to realloc(3) ensure it is always NULL or a valid block of memory. - - - - - 7c91087e by Carl Shapiro at 2024-04-25T16:37:26+00:00 Merge branch 'file-author' into 'master' Fix a double free detected by the GCC analyzer See merge request cmucl/cmucl!210 - - - - - 1 changed file: - src/lisp/os-common.c Changes: ===================================== src/lisp/os-common.c ===================================== @@ -762,10 +762,10 @@ os_file_author(const char *path) case ERANGE: /* Buffer is too small, double its size and try again */ size *= 2; - obuffer = (buffer == initial) ? NULL : buffer; if ((buffer = realloc(obuffer, size)) == NULL) { goto exit; } + obuffer = buffer; continue; default: /* All other errors */ View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/8de3c927c724813022110b… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/8de3c927c724813022110b… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #303: Remove unused var *assert-not-standard-readtable*
by Raymond Toy (＠rtoy) 22 Apr '24

22 Apr '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: b040810c by Raymond Toy at 2024-04-22T13:57:52+00:00 Fix #303: Remove unused var *assert-not-standard-readtable* - - - - - 8de3c927 by Raymond Toy at 2024-04-22T13:57:57+00:00 Merge branch 'issue-303-remove-unused-assert-not-standard-readtable' into 'master' Fix #303: Remove unused var *assert-not-standard-readtable* Closes #303 See merge request cmucl/cmucl!209 - - - - - 1 changed file: - src/code/reader.lisp Changes: ===================================== src/code/reader.lisp ===================================== @@ -620,8 +620,7 @@ ;; Of course, we want to be able to modify the standard ;; readtable here! (invoke-restart 'kernel::continue)))) - (let ((*readtable* std-lisp-readtable) - (*assert-not-standard-readtable* nil)) + (let ((*readtable* std-lisp-readtable)) (set-cat-entry #\tab #.whitespace) (set-cat-entry #\linefeed #.whitespace) (set-cat-entry #\space #.whitespace) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/1abdcb329d945247acc210… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/1abdcb329d945247acc210… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-303-remove-unused-assert-not-standard-readtable
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed new branch issue-303-remove-unused-assert-not-standard-readtable at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-303-remove-unused-a… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Use snapshot-2024-04 to run the CI
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 83df8fec by Raymond Toy at 2024-04-19T12:01:18-07:00 Use snapshot-2024-04 to run the CI Snapshots have been uploaded so use them for running the CI. - - - - - 1abdcb32 by Raymond Toy at 2024-04-19T15:08:49-07:00 Remove // comment According to [fc0bd2a6f0] this change was supposed to be removed but never was. Let's do it now. This was also the only place where we used C++ comment-style. - - - - - 2 changed files: - .gitlab-ci.yml - src/lisp/gencgc.c Changes: ===================================== .gitlab-ci.yml ===================================== @@ -1,6 +1,6 @@ variables: - download_url: "https://common-lisp.net/project/cmucl/downloads/snapshots/2023/08" - version: "xoroshiro-assembly-x86" + download_url: "https://common-lisp.net/project/cmucl/downloads/snapshots/2024/04" + version: "2024-04-x86" bootstrap: "" ===================================== src/lisp/gencgc.c ===================================== @@ -4325,7 +4325,7 @@ u32_vector(lispobj obj, unsigned *length) static inline void free_hash_entry(struct hash_table *hash_table, int hash_index, int kv_index) { - unsigned length = UINT_MAX; // to compare to + unsigned length = UINT_MAX; unsigned *index_vector = u32_vector(hash_table->index_vector, &length); unsigned *next_vector = u32_vector(hash_table->next_vector, 0); int free_p = 1; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a33e75aed5ec46cd2ec116… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/a33e75aed5ec46cd2ec116… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new tag snapshot-2024-04
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed new tag snapshot-2024-04 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/snapshot-2024-04 You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Deleted tag snapshot-2024-04
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy deleted tag snapshot-2024-04 at cmucl / cmucl -- You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Update with fixed tickets that we forgot to add earlier.
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: a33e75ae by Raymond Toy at 2024-04-19T07:36:31-07:00 Update with fixed tickets that we forgot to add earlier. - - - - - 1 changed file: - src/general-info/release-21f.md Changes: ===================================== src/general-info/release-21f.md ===================================== @@ -30,14 +30,17 @@ public domain. * ANSI compliance fixes: * Bug fixes: * Gitlab tickets: + * * ~~#154~~ piglatin translation does not work anymore - * ~~#171~~ Readably print `(make-pathname :name :unspecfic)` + * ~~#171~~ Readably print `(make-pathname :name :unspecfic)` + * ~~#180~~ Move `get-page-size` to C * ~~#196~~ Fix issues with mapping and nconc accumulation (mapcan) * ~~#216~~ `enough-namestring` with relative pathname fails * ~~#234~~ Make :ASCII external format builtin * ~~#240~~ Speed up set operations * ~~#242~~ Fix bug in `alien-funcall` with `c-call:char` as result type * ~~#244~~ Add `c-call:signed-char` + * ~~#245~~ Replace `egrep` with `grep -E` in `make-dist.sh` * ~~#248~~ Print MOVS instruction with correct case * ~~#249~~ Replace LEA instruction with simpler shorter instructions in arithmetic vops for x86 * ~~#253~~ Block-compile list-to-hashtable and callers @@ -53,6 +56,7 @@ public domain. * ~~#265~~ CI for mac os is broken * ~~#266~~ Support "~user" in namestrings * ~~#269~~ Add function to get user's home directory + * ~~#270~~ Simplify `os_file_author` interface * ~~#271~~ Update ASDF to 3.3.7 * ~~#272~~ Move scavenge code for static vectors to its own function * ~~#274~~ 1d99999999 hangs @@ -67,7 +71,11 @@ public domain. * ~~#290~~ Pprint `with-float-traps-masked` better * ~~#291~~ Pprint `handler-case` neatly. * ~~#293~~ Allow restarts for FP overflow in reader. + * ~~#294~~ Implement assembly routine for xoroshiro update function + * ~~#296~~ Disassembly of movd instruction broken * ~~#297~~ Pprint `new-assem:assemble` with less indentation. + * ~~#298~~ Add `with-float-rounding-mode` macro + * ~~#299~~ Enable xoroshiro assembly routine * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a33e75aed5ec46cd2ec116c… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a33e75aed5ec46cd2ec116c… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new tag snapshot-2024-04
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed new tag snapshot-2024-04 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/snapshot-2024-04 You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #293: Allow restarts for FP overflow in reader
by Raymond Toy (＠rtoy) 19 Apr '24

19 Apr '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: c40327d1 by Raymond Toy at 2024-04-19T14:13:56+00:00 Fix #293: Allow restarts for FP overflow in reader - - - - - 787626ad by Raymond Toy at 2024-04-19T14:14:04+00:00 Merge branch 'issue-293-restart-on-reader-fp-overflow' into 'master' Fix #293: Allow restarts for FP overflow in reader Closes #293, #275, and #287 See merge request cmucl/cmucl!201 - - - - - 5 changed files: - src/code/bignum.lisp - src/code/reader.lisp - src/general-info/release-21f.md - src/i18n/locale/cmucl.pot - tests/float.lisp Changes: ===================================== src/code/bignum.lisp ===================================== @@ -2032,7 +2032,7 @@ down to individual words.") (declare (type bignum-index len)) (let ((exp (+ exp bias))) (when (> exp max) - (error 'simple-type-error + (error 'floating-point-overflow :datum x :format-control (intl:gettext "Too large to be represented as a ~S:~% ~S") :format-arguments (list format x) ===================================== src/code/reader.lisp ===================================== @@ -1823,6 +1823,51 @@ the end of the stream." num)))) (t (error _"Internal error in floating point reader."))))) +(defun restart-overflow (sign-num sign-div float-format stream) + (flet + ((floating-point-infinity (sign float-format) + (ecase float-format + ((short-float single-float) + (if (minusp sign) + ext:single-float-negative-infinity + ext:single-float-positive-infinity)) + ((double-float long-float) + (if (minusp sign) + ext:double-float-negative-infinity + ext:double-float-positive-infinity)) + #+double-double + ((kernel::double-double-float) + (if (minusp sign) + kernel::double-double-float-negative-infinity + kernel::double-double-float-positive-infinity)))) + (largest-float (sign float-format) + (ecase float-format + ((short-float single-float) + (if (minusp sign) + most-negative-single-float + most-positive-single-float)) + ((double-float long-float) + (if (minusp sign) + most-negative-double-float + most-positive-double-float)) + #+double-double + ((kernel::double-double-float) + (if (minusp sign) + ext:most-negative-double-double-float + ext:most-positive-double-double-float))))) + + (restart-case + (%reader-error stream _"Floating-point overflow reading ~S: ~S" + float-format (read-buffer-to-string)) + (infinity () + :report (lambda (stream) + (format stream "Return floating-point infinity")) + (floating-point-infinity (* sign-num sign-div) float-format)) + (largest-float () + :report (lambda (stream) + (format stream "Return largest floating-point value")) + (largest-float (* sign-num sign-div) float-format))))) + (defun make-float-aux (exponent number divisor float-format stream) ;; Computes x = number*10^exponent/divisor. ;; @@ -1867,7 +1912,7 @@ the end of the stream." (error 'floating-point-underflow)) (when (>= log2-num log2-high) ;; Number is definitely too large; signal an error - (error "Overflow")))))))) + (error 'floating-point-overflow)))))))) ;; Otherwise the number might fit, so we carefully compute the result. (handler-case @@ -1893,11 +1938,15 @@ the end of the stream." :report (lambda (stream) (format stream "Return ~A" zero)) zero)))) + (floating-point-overflow () + ;; Resignal a reader error, but allow the user to replace + ;; overflow with another value. + (restart-overflow (signum number) (signum divisor) + float-format stream)) (error () (%reader-error stream _"Number not representable as a ~S: ~S" float-format (read-buffer-to-string)))))) - (defun make-ratio (stream) ;;assume *read-buffer* contains a legal ratio. Build the number from ;;the string. ===================================== src/general-info/release-21f.md ===================================== @@ -66,6 +66,7 @@ public domain. * ~~#288~~ Re-enable `deftransform` for random integers. * ~~#290~~ Pprint `with-float-traps-masked` better * ~~#291~~ Pprint `handler-case` neatly. + * ~~#293~~ Allow restarts for FP overflow in reader. * ~~#297~~ Pprint `new-assem:assemble` with less indentation. * Other changes: * Improvements to the PCL implementation of CLOS: ===================================== src/i18n/locale/cmucl.pot ===================================== @@ -8749,6 +8749,10 @@ msgstr "" msgid "Internal error in floating point reader." msgstr "" +#: src/code/reader.lisp +msgid "Floating-point overflow reading ~S: ~S" +msgstr "" + #: src/code/reader.lisp msgid "Floating point underflow when reading ~S: ~S" msgstr "" ===================================== tests/float.lisp ===================================== @@ -287,4 +287,49 @@ (invoke-restart 'lisp::continue)))) (read-from-string string))))))) +(define-test fp-overflow-restarts.infinity + (:tag :issues) + ;; Test that the "infinity" restart from reader on floating-point + ;; overflow returns an infinity of the correct type and sign. + (dolist (item (list (list "4e38" ext:single-float-positive-infinity) + (list "-4e38" ext:single-float-negative-infinity) + (list "2d308" ext:double-float-positive-infinity) + (list "-2d308" ext:double-float-negative-infinity) + ;; These test the short-cut case in the reader for + ;; very large numbers. + (list "4e999" ext:single-float-positive-infinity) + (list "-4e999" ext:single-float-negative-infinity) + (list "1d999" ext:double-float-positive-infinity) + (list "-1d999" ext:double-float-negative-infinity))) + (destructuring-bind (string expected-result) + item + (assert-equal expected-result + (values (handler-bind ((reader-error + (lambda (c) + (declare (ignore c)) + (invoke-restart 'lisp::infinity)))) + (read-from-string string))))))) +(define-test fp-overflow-restarts.huge + (:tag :issues) + ;; Test that the "largest-float" restart from reader on + ;; floating-point overflow returns the largest float of the correct + ;; type and sign. + (dolist (item (list (list "4e38" most-positive-single-float) + (list "-4e38" most-negative-single-float) + (list "2d308" most-positive-double-float) + (list "-2d308" most-negative-double-float) + ;; These test the short-cut case in the reader for + ;; very large numbers. + (list "4e999" most-positive-single-float) + (list "-4e999" most-negative-single-float) + (list "1d999" most-positive-double-float) + (list "-1d999" most-negative-double-float))) + (destructuring-bind (string expected-result) + item + (assert-equal expected-result + (handler-bind ((reader-error + (lambda (c) + (declare (ignore c)) + (values (invoke-restart 'lisp::largest-float))))) + (read-from-string string)))))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/07c9c06b3d8f1c2f7072c9… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/07c9c06b3d8f1c2f7072c9… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-304-debug-handlers-defn
by Raymond Toy (＠rtoy) 17 Apr '24

17 Apr '24

Raymond Toy pushed new branch issue-304-debug-handlers-defn at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-304-debug-handlers-… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0