- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl] Pushed new branch issue-316-support-roundtrip-char-casing
by Raymond Toy (＠rtoy) 13 May '24

13 May '24

Raymond Toy pushed new branch issue-316-support-roundtrip-char-casing at cmucl / cmucl -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-316-support-roundtr… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-312-motif-server] Declare type_writer to have a void* arg instead of caddr_t.
by Raymond Toy (＠rtoy) 10 May '24

10 May '24

Raymond Toy pushed to branch issue-312-motif-server at cmucl / cmucl Commits: 2c4e223e by Raymond Toy at 2024-05-10T15:00:29-07:00 Declare type_writer to have a void* arg instead of caddr_t. Update datatrans.h so that message_write_float is declared to have a second arg of type void*. Then update implementation of message_write_float to have a matching function signature and cast the void* arg to float* so we can get the float value. - - - - - 3 changed files: - src/motif/server/datatrans.c - src/motif/server/datatrans.h - src/motif/server/tables.h Changes: ===================================== src/motif/server/datatrans.c ===================================== @@ -265,10 +265,12 @@ void message_write_color(message_t m,XColor *color,int tag) message_put_word(m,color->blue); } -void message_write_float(message_t m,float *f,int tag) +void message_write_float(message_t m,void *f,int tag) { + float *fl = (float *) f; + message_put_dblword(m,combine_type_and_data(tag,0)); - message_put_dblword(m,*f); + message_put_dblword(m,*fl); } ===================================== src/motif/server/datatrans.h ===================================== @@ -38,7 +38,7 @@ extern void message_write_int_list(); extern void message_write_event(); extern void message_write_color(); /* GCC complains without the full prototype */ -extern void message_write_float(message_t,float*,int); +extern void message_write_float(message_t,void*,int); ===================================== src/motif/server/tables.h ===================================== @@ -10,8 +10,8 @@ #ifndef TABLES_H #define TABLES_H -typedef void (*type_writer)(message_t out,caddr_t src,int type_tag); -typedef void (*type_reader)(message_t in,caddr_t dest,int type_tag,int data); +typedef void (*type_writer)(message_t out,void *src,int type_tag); +typedef void (*type_reader)(message_t in,void *dest,int type_tag,int data); typedef struct { String type; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/2c4e223e3a53f79e3c147a4… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/2c4e223e3a53f79e3c147a4… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Update release notes for #314
by Raymond Toy (＠rtoy) 10 May '24

10 May '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 6a6e6445 by Raymond Toy at 2024-05-10T12:13:33-07:00 Update release notes for #314 Forgot to update the release notes when working on #314. - - - - - 1 changed file: - src/general-info/release-21f.md Changes: ===================================== src/general-info/release-21f.md ===================================== @@ -76,6 +76,7 @@ public domain. * ~~#297~~ Pprint `new-assem:assemble` with less indentation. * ~~#298~~ Add `with-float-rounding-mode` macro * ~~#299~~ Enable xoroshiro assembly routine + * ~~#314~~ tanh incorrect for large args * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6a6e64458e59b4a011d3085… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6a6e64458e59b4a011d3085… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #314: tanh incorrect for large args
by Raymond Toy (＠rtoy) 10 May '24

10 May '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 63ee590e by Raymond Toy at 2024-05-10T18:53:05+00:00 Fix #314: tanh incorrect for large args - - - - - f661bac3 by Raymond Toy at 2024-05-10T18:53:09+00:00 Merge branch 'issue-314-complex-tanh-incorrect-for-large-arg' into 'master' Fix #314: tanh incorrect for large args Closes #314 See merge request cmucl/cmucl!219 - - - - - 3 changed files: - src/code/irrat-dd.lisp - src/code/irrat.lisp - tests/irrat.lisp Changes: ===================================== src/code/irrat-dd.lisp ===================================== @@ -1800,12 +1800,10 @@ Z may be any number, but the result is always a complex." (declare (optimize (speed 3) (space 0) (inhibit-warnings 3))) (cond ((> (abs x) - #-(or linux hpux) #.(/ (%asinh most-positive-double-float) 4d0) - ;; This is more accurate under linux. - #+(or linux hpux) #.(/ (+ (%log 2.0d0) - (%log most-positive-double-float)) 4d0)) + ;; Don't need double-double accuracy here. + #.(/ (%asinh most-positive-double-float) 4d0)) (complex (float-sign x) - (float-sign y))) + (float-sign y 0w0))) (t (let* ((tv (dd-%tan y)) (beta (+ 1.0d0 (* tv tv))) ===================================== src/code/irrat.lisp ===================================== @@ -1521,12 +1521,12 @@ Z may be any number, but the result is always a complex." ;; space 0 to get maybe-inline functions inlined (declare (optimize (speed 3) (space 0))) (cond ((> (abs x) - #-(or linux hpux) #.(/ (%asinh most-positive-double-float) 4d0) - ;; This is more accurate under linux. - #+(or linux hpux) #.(/ (+ (%log 2.0d0) - (%log most-positive-double-float)) 4d0)) + (/ (%asinh most-positive-double-float) 4d0)) + ;; Kahan says the answer is + ;; + ;; copysign(1, x) + i*copysign(0, y) (coerce-to-complex-type (float-sign x) - (float-sign y) z)) + (float-sign y 0d0) z)) (t (let* ((tv (%tan y)) (beta (+ 1.0d0 (* tv tv))) ===================================== tests/irrat.lisp ===================================== @@ -231,3 +231,17 @@ (let ((z (sqrt (complex minf (- nan))))) (assert-true (ext:float-nan-p (realpart z))) (assert-eql minf (imagpart z)))))) + +;; See bug #314 +(define-test tanh-large + (:tag :issues) + (assert-eql (complex 1d0 -0d0) + (tanh #c(200d0 -200d0))) + (assert-eql (complex 1d0 +0d0) + (tanh #c(200d0 +200d0))) + (assert-eql (complex 1w0 -0w0) + (tanh #c(200w0 -200w0))) + (assert-eql (complex 1w0 +0w0) + (tanh #c(200w0 200w0)))) + + View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/b2fb3f8df03f6dac2c3b4a… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/b2fb3f8df03f6dac2c3b4a… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-314-complex-tanh-incorrect-for-large-arg] 2 commits: Fix the same tanh issue in irrat-dd.lisp.
by Raymond Toy (＠rtoy) 10 May '24

10 May '24

Raymond Toy pushed to branch issue-314-complex-tanh-incorrect-for-large-arg at cmucl / cmucl Commits: e028381e by Raymond Toy at 2024-05-10T09:08:48-07:00 Fix the same tanh issue in irrat-dd.lisp. The double-double version of complex-tanh has exactly the same problem. Apply the fix too. - - - - - 22cfda6d by Raymond Toy at 2024-05-10T09:09:26-07:00 Add tests for tanh of large double-double floats too. - - - - - 2 changed files: - src/code/irrat-dd.lisp - tests/irrat.lisp Changes: ===================================== src/code/irrat-dd.lisp ===================================== @@ -1800,12 +1800,10 @@ Z may be any number, but the result is always a complex." (declare (optimize (speed 3) (space 0) (inhibit-warnings 3))) (cond ((> (abs x) - #-(or linux hpux) #.(/ (%asinh most-positive-double-float) 4d0) - ;; This is more accurate under linux. - #+(or linux hpux) #.(/ (+ (%log 2.0d0) - (%log most-positive-double-float)) 4d0)) + ;; Don't need double-double accuracy here. + #.(/ (%asinh most-positive-double-float) 4d0)) (complex (float-sign x) - (float-sign y))) + (float-sign y 0w0))) (t (let* ((tv (dd-%tan y)) (beta (+ 1.0d0 (* tv tv))) ===================================== tests/irrat.lisp ===================================== @@ -239,4 +239,9 @@ (tanh #c(200d0 -200d0))) (assert-eql (complex 1d0 +0d0) (tanh #c(200d0 +200d0))) + (assert-eql (complex 1w0 -0w0) + (tanh #c(200w0 -200w0))) + (assert-eql (complex 1w0 +0w0) + (tanh #c(200w0 200w0)))) + View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/cd8e60037f2de0e8f3dedc… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/cd8e60037f2de0e8f3dedc… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-314-complex-tanh-incorrect-for-large-arg
by Raymond Toy (＠rtoy) 07 May '24

07 May '24

Raymond Toy pushed new branch issue-314-complex-tanh-incorrect-for-large-arg at cmucl / cmucl -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-314-complex-tanh-in… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-312-motif-server
by Raymond Toy (＠rtoy) 05 May '24

05 May '24

Raymond Toy pushed new branch issue-312-motif-server at cmucl / cmucl -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-312-motif-server You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Return an error if a copy of *CMUCL-LIB* cannot be allocated
by Carl Shapiro (＠cshapiro) 29 Apr '24

29 Apr '24

Carl Shapiro pushed to branch master at cmucl / cmucl Commits: 557dd71f by Carl Shapiro at 2024-04-28T14:41:49-07:00 Return an error if a copy of *CMUCL-LIB* cannot be allocated Previously, the malloc and strdup calls were assumed to succeed. Now, their return values are checked for an error signal. Consistent with other failures in this file, a value of -1 is returned. - - - - - b2fb3f8d by Carl Shapiro at 2024-04-29T01:02:35+00:00 Merge branch 'elf-c-unchecked-malloc' into 'master' Return an error if a copy of *CMUCL-LIB* cannot be allocated See merge request cmucl/cmucl!217 - - - - - 1 changed file: - src/lisp/elf.c Changes: ===================================== src/lisp/elf.c ===================================== @@ -333,13 +333,20 @@ obj_run_linker(long init_func_address, char *file) extern int debug_lisp_search; #ifndef UNICODE paths = strdup((char *)vec->data); + if (paths == NULL) { + perror("strdup"); + return -1; + } #else /* * What should we do here with 16-bit characters? For now we just * take the low 8-bits. */ paths = malloc(vec->length); - { + if (paths == NULL) { + perror("malloc"); + return -1; + } else { int k; unsigned short *data; data = (unsigned short*) vec->data; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5b3f4145422d2c70ca7a71… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5b3f4145422d2c70ca7a71… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-306-lisp.c] check_ptr takes const ptr and add more uses of it
by Raymond Toy (＠rtoy) 28 Apr '24

28 Apr '24

Raymond Toy pushed to branch issue-306-lisp.c at cmucl / cmucl Commits: 7fe88dcd by Raymond Toy at 2024-04-28T12:40:22-07:00 check_ptr takes const ptr and add more uses of it `check_ptr` takes a `const void* ptr` since it doesn't modify anything. Add more uses of `check_ptr` to verify that `strdup` and `malloc` returned a non-NULL pointer. - - - - - 1 changed file: - src/lisp/lisp.c Changes: ===================================== src/lisp/lisp.c ===================================== @@ -45,7 +45,7 @@ static void -check_ptr(void* ptr, const char* msg) +check_ptr(const void* ptr, const char* msg) { if (ptr == NULL) { perror(msg); @@ -276,6 +276,8 @@ default_cmucllib(const char *argv0arg) /* Create the colon separated list of directories */ defpath = malloc(total_len + 1); + check_ptr(defpath, "No space for cmucllib path"); + *defpath = '\0'; ptr = cmucllib_search_list; @@ -395,6 +397,8 @@ prepend_core_path(const char *lib, const char *corefile) } result = malloc(strlen(path) + strlen(lib) + 2); + check_ptr(result, "No space final core path"); + strcpy(result, path); strcat(result, ":"); strcat(result, lib); @@ -748,12 +752,14 @@ main(int argc, const char *argv[], const char *envp[]) */ if (lib != NULL) { cmucllib = strdup(lib); + check_ptr(cmucllib, "No space for strdup(lib)"); } else { char *libvar; libvar = getenv("CMUCLLIB"); if (libvar != NULL) { cmucllib = strdup(libvar); + check_ptr(cmucllib, "No space for strdup(libvar)"); } else { /* * The following doesn't make sense for executables. They @@ -784,7 +790,6 @@ main(int argc, const char *argv[], const char *envp[]) } } - /* Only look for a core file if we're not using a built-in image. */ if (builtin_image_flag == 0) { /* View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/7fe88dcd1cf24150a385c12… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/7fe88dcd1cf24150a385c12… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-306-lisp.c
by Raymond Toy (＠rtoy) 28 Apr '24

28 Apr '24

Raymond Toy pushed new branch issue-306-lisp.c at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-306-lisp.c You're receiving this email because of your account on gitlab.common-lisp.net.

1 0