- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][master] Update release notes for #314
by Raymond Toy (＠rtoy) 10 May '24

10 May '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 6a6e6445 by Raymond Toy at 2024-05-10T12:13:33-07:00 Update release notes for #314 Forgot to update the release notes when working on #314. - - - - - 1 changed file: - src/general-info/release-21f.md Changes: ===================================== src/general-info/release-21f.md ===================================== @@ -76,6 +76,7 @@ public domain. * ~~#297~~ Pprint `new-assem:assemble` with less indentation. * ~~#298~~ Add `with-float-rounding-mode` macro * ~~#299~~ Enable xoroshiro assembly routine + * ~~#314~~ tanh incorrect for large args * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6a6e64458e59b4a011d3085… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6a6e64458e59b4a011d3085… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #314: tanh incorrect for large args
by Raymond Toy (＠rtoy) 10 May '24

10 May '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 63ee590e by Raymond Toy at 2024-05-10T18:53:05+00:00 Fix #314: tanh incorrect for large args - - - - - f661bac3 by Raymond Toy at 2024-05-10T18:53:09+00:00 Merge branch 'issue-314-complex-tanh-incorrect-for-large-arg' into 'master' Fix #314: tanh incorrect for large args Closes #314 See merge request cmucl/cmucl!219 - - - - - 3 changed files: - src/code/irrat-dd.lisp - src/code/irrat.lisp - tests/irrat.lisp Changes: ===================================== src/code/irrat-dd.lisp ===================================== @@ -1800,12 +1800,10 @@ Z may be any number, but the result is always a complex." (declare (optimize (speed 3) (space 0) (inhibit-warnings 3))) (cond ((> (abs x) - #-(or linux hpux) #.(/ (%asinh most-positive-double-float) 4d0) - ;; This is more accurate under linux. - #+(or linux hpux) #.(/ (+ (%log 2.0d0) - (%log most-positive-double-float)) 4d0)) + ;; Don't need double-double accuracy here. + #.(/ (%asinh most-positive-double-float) 4d0)) (complex (float-sign x) - (float-sign y))) + (float-sign y 0w0))) (t (let* ((tv (dd-%tan y)) (beta (+ 1.0d0 (* tv tv))) ===================================== src/code/irrat.lisp ===================================== @@ -1521,12 +1521,12 @@ Z may be any number, but the result is always a complex." ;; space 0 to get maybe-inline functions inlined (declare (optimize (speed 3) (space 0))) (cond ((> (abs x) - #-(or linux hpux) #.(/ (%asinh most-positive-double-float) 4d0) - ;; This is more accurate under linux. - #+(or linux hpux) #.(/ (+ (%log 2.0d0) - (%log most-positive-double-float)) 4d0)) + (/ (%asinh most-positive-double-float) 4d0)) + ;; Kahan says the answer is + ;; + ;; copysign(1, x) + i*copysign(0, y) (coerce-to-complex-type (float-sign x) - (float-sign y) z)) + (float-sign y 0d0) z)) (t (let* ((tv (%tan y)) (beta (+ 1.0d0 (* tv tv))) ===================================== tests/irrat.lisp ===================================== @@ -231,3 +231,17 @@ (let ((z (sqrt (complex minf (- nan))))) (assert-true (ext:float-nan-p (realpart z))) (assert-eql minf (imagpart z)))))) + +;; See bug #314 +(define-test tanh-large + (:tag :issues) + (assert-eql (complex 1d0 -0d0) + (tanh #c(200d0 -200d0))) + (assert-eql (complex 1d0 +0d0) + (tanh #c(200d0 +200d0))) + (assert-eql (complex 1w0 -0w0) + (tanh #c(200w0 -200w0))) + (assert-eql (complex 1w0 +0w0) + (tanh #c(200w0 200w0)))) + + View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/b2fb3f8df03f6dac2c3b4a… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/b2fb3f8df03f6dac2c3b4a… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-314-complex-tanh-incorrect-for-large-arg] 2 commits: Fix the same tanh issue in irrat-dd.lisp.
by Raymond Toy (＠rtoy) 10 May '24

10 May '24

Raymond Toy pushed to branch issue-314-complex-tanh-incorrect-for-large-arg at cmucl / cmucl Commits: e028381e by Raymond Toy at 2024-05-10T09:08:48-07:00 Fix the same tanh issue in irrat-dd.lisp. The double-double version of complex-tanh has exactly the same problem. Apply the fix too. - - - - - 22cfda6d by Raymond Toy at 2024-05-10T09:09:26-07:00 Add tests for tanh of large double-double floats too. - - - - - 2 changed files: - src/code/irrat-dd.lisp - tests/irrat.lisp Changes: ===================================== src/code/irrat-dd.lisp ===================================== @@ -1800,12 +1800,10 @@ Z may be any number, but the result is always a complex." (declare (optimize (speed 3) (space 0) (inhibit-warnings 3))) (cond ((> (abs x) - #-(or linux hpux) #.(/ (%asinh most-positive-double-float) 4d0) - ;; This is more accurate under linux. - #+(or linux hpux) #.(/ (+ (%log 2.0d0) - (%log most-positive-double-float)) 4d0)) + ;; Don't need double-double accuracy here. + #.(/ (%asinh most-positive-double-float) 4d0)) (complex (float-sign x) - (float-sign y))) + (float-sign y 0w0))) (t (let* ((tv (dd-%tan y)) (beta (+ 1.0d0 (* tv tv))) ===================================== tests/irrat.lisp ===================================== @@ -239,4 +239,9 @@ (tanh #c(200d0 -200d0))) (assert-eql (complex 1d0 +0d0) (tanh #c(200d0 +200d0))) + (assert-eql (complex 1w0 -0w0) + (tanh #c(200w0 -200w0))) + (assert-eql (complex 1w0 +0w0) + (tanh #c(200w0 200w0)))) + View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/cd8e60037f2de0e8f3dedc… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/cd8e60037f2de0e8f3dedc… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-314-complex-tanh-incorrect-for-large-arg
by Raymond Toy (＠rtoy) 07 May '24

07 May '24

Raymond Toy pushed new branch issue-314-complex-tanh-incorrect-for-large-arg at cmucl / cmucl -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-314-complex-tanh-in… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-312-motif-server
by Raymond Toy (＠rtoy) 05 May '24

05 May '24

Raymond Toy pushed new branch issue-312-motif-server at cmucl / cmucl -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-312-motif-server You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Return an error if a copy of *CMUCL-LIB* cannot be allocated
by Carl Shapiro (＠cshapiro) 29 Apr '24

29 Apr '24

Carl Shapiro pushed to branch master at cmucl / cmucl Commits: 557dd71f by Carl Shapiro at 2024-04-28T14:41:49-07:00 Return an error if a copy of *CMUCL-LIB* cannot be allocated Previously, the malloc and strdup calls were assumed to succeed. Now, their return values are checked for an error signal. Consistent with other failures in this file, a value of -1 is returned. - - - - - b2fb3f8d by Carl Shapiro at 2024-04-29T01:02:35+00:00 Merge branch 'elf-c-unchecked-malloc' into 'master' Return an error if a copy of *CMUCL-LIB* cannot be allocated See merge request cmucl/cmucl!217 - - - - - 1 changed file: - src/lisp/elf.c Changes: ===================================== src/lisp/elf.c ===================================== @@ -333,13 +333,20 @@ obj_run_linker(long init_func_address, char *file) extern int debug_lisp_search; #ifndef UNICODE paths = strdup((char *)vec->data); + if (paths == NULL) { + perror("strdup"); + return -1; + } #else /* * What should we do here with 16-bit characters? For now we just * take the low 8-bits. */ paths = malloc(vec->length); - { + if (paths == NULL) { + perror("malloc"); + return -1; + } else { int k; unsigned short *data; data = (unsigned short*) vec->data; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5b3f4145422d2c70ca7a71… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5b3f4145422d2c70ca7a71… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-306-lisp.c] check_ptr takes const ptr and add more uses of it
by Raymond Toy (＠rtoy) 28 Apr '24

28 Apr '24

Raymond Toy pushed to branch issue-306-lisp.c at cmucl / cmucl Commits: 7fe88dcd by Raymond Toy at 2024-04-28T12:40:22-07:00 check_ptr takes const ptr and add more uses of it `check_ptr` takes a `const void* ptr` since it doesn't modify anything. Add more uses of `check_ptr` to verify that `strdup` and `malloc` returned a non-NULL pointer. - - - - - 1 changed file: - src/lisp/lisp.c Changes: ===================================== src/lisp/lisp.c ===================================== @@ -45,7 +45,7 @@ static void -check_ptr(void* ptr, const char* msg) +check_ptr(const void* ptr, const char* msg) { if (ptr == NULL) { perror(msg); @@ -276,6 +276,8 @@ default_cmucllib(const char *argv0arg) /* Create the colon separated list of directories */ defpath = malloc(total_len + 1); + check_ptr(defpath, "No space for cmucllib path"); + *defpath = '\0'; ptr = cmucllib_search_list; @@ -395,6 +397,8 @@ prepend_core_path(const char *lib, const char *corefile) } result = malloc(strlen(path) + strlen(lib) + 2); + check_ptr(result, "No space final core path"); + strcpy(result, path); strcat(result, ":"); strcat(result, lib); @@ -748,12 +752,14 @@ main(int argc, const char *argv[], const char *envp[]) */ if (lib != NULL) { cmucllib = strdup(lib); + check_ptr(cmucllib, "No space for strdup(lib)"); } else { char *libvar; libvar = getenv("CMUCLLIB"); if (libvar != NULL) { cmucllib = strdup(libvar); + check_ptr(cmucllib, "No space for strdup(libvar)"); } else { /* * The following doesn't make sense for executables. They @@ -784,7 +790,6 @@ main(int argc, const char *argv[], const char *envp[]) } } - /* Only look for a core file if we're not using a built-in image. */ if (builtin_image_flag == 0) { /* View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/7fe88dcd1cf24150a385c12… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/7fe88dcd1cf24150a385c12… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-306-lisp.c
by Raymond Toy (＠rtoy) 28 Apr '24

28 Apr '24

Raymond Toy pushed new branch issue-306-lisp.c at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-306-lisp.c You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Remove the definition of __NO_CTYPE from the Linux build
by Carl Shapiro (＠cshapiro) 28 Apr '24

28 Apr '24

Carl Shapiro pushed to branch master at cmucl / cmucl Commits: af5a360e by Carl Shapiro at 2024-04-26T19:03:44-07:00 Remove the definition of __NO_CTYPE from the Linux build The definition of this macro disables the definition of isalpha(3) and other symbols from ctype.h from being defined as macros that depend on internal glibc functions not present in all versions of glibc. At the time, that allowed binaries compiled against newer versions of glibc to run on systems with older versions of glibc. However, today the internal functions have been available for more than two decades and so this feature does not appreciably affect compatibility. - - - - - 5b3f4145 by Carl Shapiro at 2024-04-28T05:24:36+00:00 Merge branch 'no-ctype' into 'master' Remove the definition of __NO_CTYPE from the Linux build See merge request cmucl/cmucl!214 - - - - - 1 changed file: - src/lisp/Config.x86_linux Changes: ===================================== src/lisp/Config.x86_linux ===================================== @@ -2,7 +2,7 @@ include Config.x86_common CFLAGS += $(COPT) -CPPFLAGS += -m32 -D__NO_CTYPE +CPPFLAGS += -m32 CFLAGS += -rdynamic -march=pentium4 -mfpmath=sse -mtune=generic CFLAGS += -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/520213dd9aa1154c1b9127… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/520213dd9aa1154c1b9127… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-307-dynamically-alloc-altstack] Initialize altstack on Darwin too
by Raymond Toy (＠rtoy) 27 Apr '24

27 Apr '24

Raymond Toy pushed to branch issue-307-dynamically-alloc-altstack at cmucl / cmucl Commits: 1acd68dc by Raymond Toy at 2024-04-26T20:54:36-07:00 Initialize altstack on Darwin too Make CI happy by initializing altstack on darwin too. - - - - - 1 changed file: - src/lisp/Darwin-os.c Changes: ===================================== src/lisp/Darwin-os.c ===================================== @@ -107,10 +107,13 @@ os_init0(const char *argv[], const char *envp[]) void os_init(const char *argv[], const char *envp[]) { + extern char *altstack; os_vm_page_size = OS_VM_DEFAULT_PAGESIZE; #ifdef __ppc__ timebase_init(); #endif + + altstack = malloc(SIGNAL_STACK_SIZE); } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/1acd68dcf71f04039cbf82b… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/1acd68dcf71f04039cbf82b… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0