February 2026 - cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][master] 2 commits: Fix #468: Make core-math signal the same errors as fdlibm
by Raymond Toy (＠rtoy) 16 Feb '26

16 Feb '26

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 9dec6e71 by Raymond Toy at 2026-02-16T07:40:15-08:00 Fix #468: Make core-math signal the same errors as fdlibm - - - - - ec7e3a25 by Raymond Toy at 2026-02-16T07:40:15-08:00 Merge branch 'issue-468-core-math-signals' into 'master' Fix #468: Make core-math signal the same errors as fdlibm Closes #468, #426, and #425 See merge request cmucl/cmucl!347 - - - - - 2 changed files: - src/lisp/irrat.c - tests/fdlibm.lisp Changes: ===================================== src/lisp/irrat.c ===================================== @@ -39,10 +39,22 @@ extern void cr_sincos(double, double *, double *); * Wrappers for the special functions */ +#define MAYBE_SIGNAL_INVALID(test, val) \ + if ((test)) { \ + return fdlibm_setexception(val, FDLIBM_INVALID); \ + } + +#define MAYBE_SIGNAL_OVERFLOW(x) \ + if (isinf(x)) { \ + return fdlibm_setexception(x, FDLIBM_OVERFLOW); \ + } + double lisp_sin(double x) { #ifdef FEATURE_CORE_MATH + MAYBE_SIGNAL_INVALID(isinf(x), x) + return cr_sin(x); #else return fdlibm_sin(x); @@ -53,6 +65,8 @@ double lisp_cos(double x) { #ifdef FEATURE_CORE_MATH + MAYBE_SIGNAL_INVALID(isinf(x), x) + return cr_cos(x); #else return fdlibm_cos(x); @@ -63,6 +77,8 @@ double lisp_tan(double x) { #ifdef FEATURE_CORE_MATH + MAYBE_SIGNAL_INVALID(isinf(x), x) + return cr_tan(x); #else return fdlibm_tan(x); @@ -113,6 +129,8 @@ double lisp_sinh(double x) { #ifdef FEATURE_CORE_MATH + MAYBE_SIGNAL_OVERFLOW(x) + return cr_sinh(x); #else return __ieee754_sinh(x); @@ -143,6 +161,8 @@ double lisp_asinh(double x) { #ifdef FEATURE_CORE_MATH + MAYBE_SIGNAL_OVERFLOW(x) + return cr_asinh(x); #else return fdlibm_asinh(x); @@ -153,6 +173,10 @@ double lisp_acosh(double x) { #ifdef FEATURE_CORE_MATH + MAYBE_SIGNAL_INVALID(x < 1, x) + + MAYBE_SIGNAL_OVERFLOW(x) + return cr_acosh(x); #else return __ieee754_acosh(x); ===================================== tests/fdlibm.lisp ===================================== @@ -90,12 +90,8 @@ (define-test %acosh.exceptions (:tag :fdlibm) - ;; Core-math returns infinity instead of signaling overflow. - #-core-math (assert-error 'floating-point-overflow (kernel:%acosh ext:double-float-positive-infinity)) - ;; Core-math currently returns QNaN - #-core-math (assert-error 'floating-point-invalid-operation (kernel:%acosh 0d0)) (ext:with-float-traps-masked (:overflow) @@ -108,12 +104,8 @@ (:tag :fdlibm) (assert-error 'floating-point-invalid-operation (kernel:%asinh *snan*)) - ;; Core-math returns the signed infinity instead of signaling an - ;; overflow. - #-core-math (assert-error 'floating-point-overflow (kernel:%asinh ext:double-float-positive-infinity)) - #-core-math (assert-error 'floating-point-overflow (kernel:%asinh ext:double-float-negative-infinity)) (assert-true (ext:float-nan-p (kernel:%asinh *qnan*))) @@ -218,7 +210,6 @@ (ext:with-float-traps-masked (:overflow) (assert-equal ext:double-float-positive-infinity (kernel:%exp 710d0))) - #-core-math (let ((modes (ext:get-floating-point-modes))) (unwind-protect (progn @@ -675,6 +666,14 @@ (define-test %cos.exceptions (:tag :fdlibm) + ;; cos(inf) signals invalid operation + (assert-error 'floating-point-invalid-operation + (kernel:%cos ext:double-float-positive-infinity)) + (assert-error 'floating-point-invalid-operation + (kernel:%cos ext:double-float-negative-infinity)) + ;; cos(nan) is NaN + (assert-true (ext:float-nan-p (kernel:%cos *qnan*))) + ;; cos(x) = 1 for |x| < 2^-27. Signal inexact unless x = 0 (let ((x (scale-float 1d0 -28)) (x0 0d0)) @@ -690,6 +689,14 @@ (define-test %sin.exceptions (:tag :fdlibm) + ;; sin(inf) signals invalid operation + (assert-error 'floating-point-invalid-operation + (kernel:%sin ext:double-float-positive-infinity)) + (assert-error 'floating-point-invalid-operation + (kernel:%sin ext:double-float-negative-infinity)) + ;; sin(nan) is NaN + (assert-true (ext:float-nan-p (kernel:%sin *qnan*))) + ;; sin(x) = x for |x| < 2^-27. Signal inexact unless x = 0 (let ((x (scale-float 1d0 -28)) (x0 0d0)) @@ -705,6 +712,14 @@ (define-test %tan.exceptions (:tag :fdlibm) + ;; tan(inf) signals invalid operation + (assert-error 'floating-point-invalid-operation + (kernel:%tan ext:double-float-positive-infinity)) + (assert-error 'floating-point-invalid-operation + (kernel:%tan ext:double-float-negative-infinity)) + ;; tan(nan) is NaN + (assert-true (ext:float-nan-p (kernel:%sin *qnan*))) + ;; tan(x) = x for |x| < 2^-28. Signal inexact unless x = 0 (let ((x (scale-float 1d0 -29)) (x0 0d0)) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/6ac1b6b434353fc47f4530… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/6ac1b6b434353fc47f4530… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-472-ansi-tests-test-log-not-found
by Raymond Toy (＠rtoy) 16 Feb '26

16 Feb '26

Raymond Toy pushed new branch issue-472-ansi-tests-test-log-not-found at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-472-ansi-tests-test… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-464-lisp-version-uses-branch-name] 10 commits: Update cmucl.pot for new docstrings
by Raymond Toy (＠rtoy) 08 Feb '26

08 Feb '26

Raymond Toy pushed to branch issue-464-lisp-version-uses-branch-name at cmucl / cmucl Commits: 138ee50f by Raymond Toy at 2026-02-08T14:53:06-08:00 Update cmucl.pot for new docstrings Forgot to update this when accurate complex division was committed. [skip-ci] - - - - - b0b24446 by Raymond Toy at 2026-02-08T14:53:06-08:00 Fix #463: Handle double-double-float and double-float comparisons - - - - - 755ff361 by Raymond Toy at 2026-02-08T14:53:06-08:00 Fix #459: More accurate complex division for double-double-float - - - - - 928ea99e by Raymond Toy at 2026-02-08T14:53:06-08:00 Fix critical typo in deftransform for / for complex floats We inadvertently left off the quote for the code that the deftransform is supposed to use. Without that the compiler produces an error when the deftransform would be applicable. This bug was introduced when the MR for #459 was landed. - - - - - afc3f4f1 by Raymond Toy at 2026-02-08T14:53:06-08:00 Fix #428: Add some constants for common values in irrat.lisp - - - - - 5674647a by Raymond Toy at 2026-02-08T14:53:06-08:00 Fix #466: Add C wrapper for the special functions - - - - - 299f3713 by Raymond Toy at 2026-02-08T14:53:06-08:00 Fix #434: Add support for correctly rounded double-precision math functions - - - - - 9bf2d1b1 by Raymond Toy at 2026-02-08T14:53:06-08:00 Minor cleanup of GNUMakefile First, CORE64_OBJS is no longer defined, so don't use it. The CORE64_OBJS that used to name the .o files for core-math are now computed as part of OBJS. This removal also meant that the "clean" target no longer removed the core-math object files. Fix this by changing the rule to remove $(OBJS) instead of *.o. - - - - - 50b11f1a by Raymond Toy at 2026-02-08T14:53:06-08:00 Fix #470: Fix unit test issues on Ubuntu CI - - - - - a0e8bf87 by Raymond Toy at 2026-02-08T14:53:06-08:00 Fix #469: Reenable cr_pow - - - - - 53 changed files: - .gitlab-ci.yml - bin/run-unit-tests.sh - src/code/irrat.lisp - src/code/linux-os.lisp - src/code/numbers.lisp - src/compiler/float-tran-dd.lisp - src/compiler/float-tran.lisp - src/compiler/x86/sse2-c-call.lisp - src/general-info/release-22a.md - src/i18n/locale/cmucl.pot - src/lisp/Config.x86_common - src/lisp/Config.x86_linux - src/lisp/GNUmakefile - + src/lisp/core-math/src/binary64/Makefile - + src/lisp/core-math/src/binary64/acos/acos.c - + src/lisp/core-math/src/binary64/acosh/acosh.c - + src/lisp/core-math/src/binary64/asin/asin.c - + src/lisp/core-math/src/binary64/asinh/asinh.c - + src/lisp/core-math/src/binary64/atan/atan.c - + src/lisp/core-math/src/binary64/atan2/atan2.c - + src/lisp/core-math/src/binary64/atan2/tint.h - + src/lisp/core-math/src/binary64/atanh/atanh.c - + src/lisp/core-math/src/binary64/cos/cos.c - + src/lisp/core-math/src/binary64/cosh/cosh.c - + src/lisp/core-math/src/binary64/exp/exp.c - + src/lisp/core-math/src/binary64/expm1/expm1.c - + src/lisp/core-math/src/binary64/hypot/hypot.c - + src/lisp/core-math/src/binary64/log/dint.h - + src/lisp/core-math/src/binary64/log/log.c - + src/lisp/core-math/src/binary64/log10/dint.h - + src/lisp/core-math/src/binary64/log10/log10.c - + src/lisp/core-math/src/binary64/log1p/log1p.c - + src/lisp/core-math/src/binary64/log2/log2.c - + src/lisp/core-math/src/binary64/pow/dint.h - + src/lisp/core-math/src/binary64/pow/pow.c - + src/lisp/core-math/src/binary64/pow/pow.h - + src/lisp/core-math/src/binary64/pow/qint.h - + src/lisp/core-math/src/binary64/sin/sin.c - + src/lisp/core-math/src/binary64/sincos/sincos.c - + src/lisp/core-math/src/binary64/sinh/sinh.c - + src/lisp/core-math/src/binary64/tan/tan.c - + src/lisp/core-math/src/binary64/tan/tan.wc - + src/lisp/core-math/src/binary64/tanh/tanh.c - src/lisp/fdlibm.h - + src/lisp/irrat.c - src/lisp/log2.c - src/lisp/sincos.c - tests/fdlibm.lisp - tests/float.lisp - tests/irrat.lisp - tests/issues.lisp - tests/run-tests.lisp - + tests/test-run-prog/ls-link The diff was not included because it is too large. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/da7c94c626d95643a2df46… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/da7c94c626d95643a2df46… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-464-lisp-version-uses-branch-name] Fix typo.
by Raymond Toy (＠rtoy) 08 Feb '26

08 Feb '26

Raymond Toy pushed to branch issue-464-lisp-version-uses-branch-name at cmucl / cmucl Commits: da7c94c6 by Raymond Toy at 2026-02-08T12:05:56-08:00 Fix typo. On the master branch, we were using "git describe --all", but really wanted "git describe --dirty". - - - - - 1 changed file: - bin/git-version.sh Changes: ===================================== bin/git-version.sh ===================================== @@ -40,7 +40,7 @@ else BRANCH="`git rev-parse --abbrev-ref HEAD`" if [ "$BRANCH" = "master" ]; then # On the master branch, use simple git describe --dirty for the version - DEFAULT_VERSION="`git describe --all || git describe 2>/dev/null`" + DEFAULT_VERSION="`git describe --dirty || git describe 2>/dev/null`" else # We're not on the master branch. Do something different. # The option --all allows use to use the the branch name or tag View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/da7c94c626d95643a2df467… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/da7c94c626d95643a2df467… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-464-lisp-version-uses-branch-name] Do something different for the master branch
by Raymond Toy (＠rtoy) 08 Feb '26

08 Feb '26

Raymond Toy pushed to branch issue-464-lisp-version-uses-branch-name at cmucl / cmucl Commits: 9467db45 by Raymond Toy at 2026-02-08T12:02:18-08:00 Do something different for the master branch On the master branch, use the version from "git describe --dirty". This way, the version for builds on the master branch can be distinguished by the number of commits since the last release/tag. Otherwise, we'll use the most recent tag or branch name, as before. - - - - - 1 changed file: - bin/git-version.sh Changes: ===================================== bin/git-version.sh ===================================== @@ -36,37 +36,39 @@ if [ -n "$VERSION" ]; then GIT_HASH="$VERSION" DEFAULT_VERSION="$VERSION" else - # The option --all allows use to use the the branch name or tag - # name as appropriate. This is much more informative. However, - # we have to remove everything before the first slash which - # contains things like "tag/" or "head/". - GIT_DESC="`git describe --all --dirty || git describe 2>/dev/null`" - GIT_HASH="`echo ${GIT_DESC} | sed 's;^[^/]*/;;' 2>/dev/null`" - BRANCH="`git rev-parse --abbrev-ref HEAD`*" + # Get the current branch. + BRANCH="`git rev-parse --abbrev-ref HEAD`" + if [ "$BRANCH" = "master" ]; then + # On the master branch, use simple git describe --dirty for the version + DEFAULT_VERSION="`git describe --all || git describe 2>/dev/null`" + else + # We're not on the master branch. Do something different. + # The option --all allows use to use the the branch name or tag + # name as appropriate. This is much more informative. However, + # we have to remove everything before the first slash which + # contains things like "tag/" or "head/". + GIT_DESC="`git describe --all --dirty || git describe 2>/dev/null`" + GIT_HASH="`echo ${GIT_DESC} | sed 's;^[^/]*/;;' 2>/dev/null`" - case "$GIT_HASH" in - snapshot-[0-9][0-9][0-9][0-9]-[01][0-9]) - # The git hash looks like snapshot-yyyy-mm-<stuff>. Remove the - # "snapshot-" part. - DEFAULT_VERSION=`expr "$GIT_HASH" : "snapshot-$.*$"` - ;; - [0-9][0-9][a-f]) - # The git hash looks like a release which is 3 hex digits. - # Use it as is. - DEFAULT_VERSION="${GIT_HASH}" - ;; - ${BRANCH}*) - # The hash looks like the current branch with possibly more - # stuff at the end. Use the hash as the version. - DEFAULT_VERSION="${GIT_HASH}" - ;; - [0-9]*) - # Assuming this is CI which seems to produce a githash like - # "pipeline/<digits>". Make the version include "ci-" so we - # know this was done via CI. - DEFAULT_VERSION="ci-${GIT_HASH}" - ;; - esac + case "$GIT_HASH" in + snapshot-[0-9][0-9][0-9][0-9]-[01][0-9]) + # The git hash looks like snapshot-yyyy-mm-<stuff>. Remove the + # "snapshot-" part. + DEFAULT_VERSION=`expr "$GIT_HASH" : "snapshot-$.*$"` + ;; + [0-9][0-9][a-f]) + # The git hash looks like a release which is 3 hex digits. + # Use it as is. + DEFAULT_VERSION="${GIT_HASH}" + ;; + [0-9]*) + # Assuming this is CI which seems to produce a githash like + # "pipeline/<digits>". Make the version include "ci-" so we + # know this was done via CI. + DEFAULT_VERSION="ci-${GIT_HASH}" + ;; + esac + fi if [ -z "$DEFAULT_VERSION" ]; then echo "Unable to determine a default version from git describe: $GIT_DESC" View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9467db45738f62bf9e06d4c… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9467db45738f62bf9e06d4c… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-471-test-cases-for-pow] Adjust pow.case.9 for core-math
by Raymond Toy (＠rtoy) 07 Feb '26

07 Feb '26

Raymond Toy pushed to branch issue-471-test-cases-for-pow at cmucl / cmucl Commits: 6011e629 by Raymond Toy at 2026-02-06T17:25:39-08:00 Adjust pow.case.9 for core-math Looks like cr_pow does what std::pow says for 1^exp for any exp and (-1)^(+/-inf) is 1. No errors signaled. Update the test for core-math. - - - - - 1 changed file: - tests/fdlibm.lisp Changes: ===================================== tests/fdlibm.lisp ===================================== @@ -785,10 +785,27 @@ (define-test %pow.case.9 (:tag :fdlibm) + ;; std::pow says 1^exp is 1 for any exp, including NaN. (-1)^(+/-inf) + ;; is 1. No errors signaled. + #+core-math + (progn + (assert-equal 1d0 + (kernel:%pow 1d0 ext:double-float-positive-infinity)) + (assert-equal 1d0 + (kernel:%pow 1d0 ext:double-float-negative-infinity)) + (assert-equal 1d0 + (kernel:%pow 1d0 *qnan*)) + (assert-equal 1d0 + (kernel:%pow -1d0 ext:double-float-positive-infinity)) + (assert-equal 1d0 + (kernel:%pow -1d0 ext:double-float-negative-infinity))) + #-core-math ;; +-1 ^ +-inf is NaN. ;; ;; But the implementation signals invalid operation, so we need to ;; check for that. + ;; + (progn (assert-error 'floating-point-invalid-operation (kernel:%pow 1d0 ext:double-float-positive-infinity)) (assert-error 'floating-point-invalid-operation @@ -805,7 +822,7 @@ (assert-true (ext:float-nan-p (kernel:%pow -1d0 ext:double-float-positive-infinity))) (assert-true (ext:float-nan-p - (kernel:%pow -1d0 ext:double-float-negative-infinity))))) + (kernel:%pow -1d0 ext:double-float-negative-infinity)))))) (define-test %pow.case.10 (:tag :fdlibm) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6011e6296a16d7d7ca253ce… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6011e6296a16d7d7ca253ce… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-471-test-cases-for-pow
by Raymond Toy (＠rtoy) 06 Feb '26

06 Feb '26

Raymond Toy pushed new branch issue-471-test-cases-for-pow at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-471-test-cases-for-… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-468-core-math-signals] 7 commits: Define macros to handle invalid and overflow signals
by Raymond Toy (＠rtoy) 06 Feb '26

06 Feb '26

Raymond Toy pushed to branch issue-468-core-math-signals at cmucl / cmucl Commits: 3fa81f34 by Raymond Toy at 2026-02-03T08:32:45-08:00 Define macros to handle invalid and overflow signals - - - - - 9a4f3d7e by Raymond Toy at 2026-02-04T08:06:20-08:00 Minor cleanup of GNUMakefile First, CORE64_OBJS is no longer defined, so don't use it. The CORE64_OBJS that used to name the .o files for core-math are now computed as part of OBJS. This removal also meant that the "clean" target no longer removed the core-math object files. Fix this by changing the rule to remove $(OBJS) instead of *.o. - - - - - f5a798b8 by Raymond Toy at 2026-02-05T17:51:48-08:00 Fix #470: Fix unit test issues on Ubuntu CI - - - - - 5b6d4d73 by Raymond Toy at 2026-02-05T17:51:48-08:00 Merge branch 'issue-470-ubuntu-ci-failures' into 'master' Fix #470: Fix unit test issues on Ubuntu CI Closes #470 See merge request cmucl/cmucl!348 - - - - - 772641b9 by Raymond Toy at 2026-02-05T19:39:14-08:00 Fix #469: Reenable cr_pow - - - - - 6ac1b6b4 by Raymond Toy at 2026-02-05T19:39:14-08:00 Merge branch 'issue-469-enable-cr-pow' into 'master' Fix #469: Reenable cr_pow Closes #469 and #470 See merge request cmucl/cmucl!346 - - - - - f795ec67 by Raymond Toy at 2026-02-05T20:28:36-08:00 Merge branch 'master' into issue-468-core-math-signals - - - - - 6 changed files: - .gitlab-ci.yml - bin/run-unit-tests.sh - src/lisp/GNUmakefile - src/lisp/irrat.c - tests/issues.lisp - + tests/test-run-prog/ls-link Changes: ===================================== .gitlab-ci.yml ===================================== @@ -147,7 +147,9 @@ linux:build: - job: linux:install artifacts: true variables: - CONFIG: "x86_linux_clang" + # Fedora 41 must build with gcc because the clang build fails some + # ansi-tests. See [#469]. + CONFIG: "x86_linux" # These rules is needed so that the static analyzer job can run on a # schedule because this is a prerequisite of the analyzer build. A # regular push or merge request does the normal stuff. @@ -171,7 +173,7 @@ linux:cross-build: - linux-4/lisp variables: # This must match the config used for the linux build! - CONFIG: "x86_linux_clang" + CONFIG: "x86_linux" needs: @@ -346,7 +348,10 @@ ubuntu:build: - job: ubuntu:install artifacts: true variables: - CONFIG: "x86_linux_clang" + # Build with gcc on Ubuntu 25.10. It produces a lisp than passes + # the ansi-tests. Clang seems to fail the ansi-tests WRITE.1, + # PRINT.1, and friends when cr_pow is used. + CONFIG: "x86_linux" ubuntu:test: <<: *unit_test_configuration ===================================== bin/run-unit-tests.sh ===================================== @@ -42,9 +42,9 @@ done shift $((OPTIND - 1)) # Create the test directory needed by the issue.45 test. -rm -rf test-tmp -mkdir test-tmp -ln -s /bin/ls test-tmp/ls-link +#rm -rf test-tmp +#mkdir test-tmp +#ln -s /bin/ls test-tmp/ls-link # Set the timestamps on 64-bit-timestamp-2038.txt and # 64-bit-timestamp-2106.txt, but only for OSes where we know this @@ -56,8 +56,9 @@ ln -s /bin/ls test-tmp/ls-link # tests/os.lisp. case `uname -s` in Linux) - touch -d "1 April 2038" tests/resources/64-bit-timestamp-2038.txt - touch -d "1 April 2106" tests/resources/64-bit-timestamp-2106.txt + # -t format is [[CC]YY]MMDDhhmm[.ss] + touch -t 203804010000 tests/resources/64-bit-timestamp-2038.txt + touch -t 210604010000 tests/resources/64-bit-timestamp-2106.txt ;; esac ===================================== src/lisp/GNUmakefile ===================================== @@ -55,7 +55,7 @@ version.o : version.c version mv ,version version $(CC) ${CFLAGS} $(CPPFLAGS) -DVERSION=`cat version` -c $< -lisp: ${OBJS} ${CORE64_OBJS} version.o +lisp: ${OBJS} version.o $(CC) -g ${OS_LINK_FLAGS} -o ,lisp $^ ${OS_LIBS} -lm mv -f ,lisp lisp @@ -75,7 +75,7 @@ internals.h internals.inc: @false clean: - $(RM) Depends *.o $(CORE64_OBJS) lisp lisp.nm core lisp.a + $(RM) Depends $(OBJS) lisp lisp.nm core lisp.a echo 'Map file for lisp version 0' > lisp.nm depend: Depends ===================================== src/lisp/irrat.c ===================================== @@ -39,14 +39,21 @@ extern void cr_sincos(double, double *, double *); * Wrappers for the special functions */ +#define MAYBE_SIGNAL_INVALID(test, val) \ + if ((test)) { \ + return fdlibm_setexception(val, FDLIBM_INVALID); \ + } + +#define MAYBE_SIGNAL_OVERFLOW(x) \ + if (isinf(x)) { \ + return fdlibm_setexception(x, FDLIBM_OVERFLOW); \ + } + double lisp_sin(double x) { #ifdef FEATURE_CORE_MATH - /* Signals invalid if x is infinite */ - if (isinf(x)) { - return fdlibm_setexception(x, FDLIBM_INVALID); - } + MAYBE_SIGNAL_INVALID(isinf(x), x) return cr_sin(x); #else @@ -58,10 +65,7 @@ double lisp_cos(double x) { #ifdef FEATURE_CORE_MATH - /* Signals invalid if x is infinite */ - if (isinf(x)) { - return fdlibm_setexception(x, FDLIBM_INVALID); - } + MAYBE_SIGNAL_INVALID(isinf(x), x) return cr_cos(x); #else @@ -73,10 +77,7 @@ double lisp_tan(double x) { #ifdef FEATURE_CORE_MATH - /* Signals invalid if x is infinite */ - if (isinf(x)) { - return fdlibm_setexception(x, FDLIBM_INVALID); - } + MAYBE_SIGNAL_INVALID(isinf(x), x) return cr_tan(x); #else @@ -128,10 +129,7 @@ double lisp_sinh(double x) { #ifdef FEATURE_CORE_MATH - /* Signal overflow if x is infinite */ - if (isinf(x)) { - return fdlibm_setexception(x, FDLIBM_OVERFLOW); - } + MAYBE_SIGNAL_OVERFLOW(x) return cr_sinh(x); #else @@ -163,10 +161,7 @@ double lisp_asinh(double x) { #ifdef FEATURE_CORE_MATH - /* Signal overflow if x is infinite */ - if (isinf(x)) { - return fdlibm_setexception(x, FDLIBM_OVERFLOW); - } + MAYBE_SIGNAL_OVERFLOW(x) return cr_asinh(x); #else @@ -178,14 +173,9 @@ double lisp_acosh(double x) { #ifdef FEATURE_CORE_MATH - /* Signals invalid if x is not in the domain x >= 1 */ - if (x < 1) { - return fdlibm_setexception(x, FDLIBM_INVALID); - } - /* Signal overflow if x is infinite */ - if (isinf(x)) { - return fdlibm_setexception(x, FDLIBM_OVERFLOW); - } + MAYBE_SIGNAL_INVALID(x < 1, x) + + MAYBE_SIGNAL_OVERFLOW(x) return cr_acosh(x); #else @@ -236,13 +226,17 @@ lisp_log10(double x) double lisp_pow(double x, double y) { +#ifdef FEATURE_CORE_MATH /* - * cr_pow seems causes ansi-tests to fail in test WRITE.1 among - * others. Somewhere an invalid operation is occurring. Thus - * just use fdlibm for now until we can figure out what's causing - * the failure. + * cr_pow when compiled with older versions of gcc or clang can + * cause failures in the ansi-tests [#469]. Ubuntu 25.10 and Fedora 41 + * (gcc only) are known to have compilers that work well enough + * that the ansi-tests pass. */ + return cr_pow(x, y); +#else return __ieee754_pow(x, y); +#endif } double ===================================== tests/issues.lisp ===================================== @@ -436,7 +436,7 @@ (define-test issue.45 (:tag :issues) ;; This depends on run-tests to setup the test directory correctly! - (let* ((test-dir #p"test-tmp/") + (let* ((test-dir #p"tests/test-run-prog/") (test-dir-name (namestring test-dir))) (flet ((do-test (program) (with-output-to-string (s) ===================================== tests/test-run-prog/ls-link ===================================== @@ -0,0 +1,2 @@ +#! /bin/sh +exec /bin/ls "$@" View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/730da685588abfcad4b932… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/730da685588abfcad4b932… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #469: Reenable cr_pow
by Raymond Toy (＠rtoy) 06 Feb '26

06 Feb '26

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 772641b9 by Raymond Toy at 2026-02-05T19:39:14-08:00 Fix #469: Reenable cr_pow - - - - - 6ac1b6b4 by Raymond Toy at 2026-02-05T19:39:14-08:00 Merge branch 'issue-469-enable-cr-pow' into 'master' Fix #469: Reenable cr_pow Closes #469 and #470 See merge request cmucl/cmucl!346 - - - - - 3 changed files: - .gitlab-ci.yml - bin/run-unit-tests.sh - src/lisp/irrat.c Changes: ===================================== .gitlab-ci.yml ===================================== @@ -147,7 +147,9 @@ linux:build: - job: linux:install artifacts: true variables: - CONFIG: "x86_linux_clang" + # Fedora 41 must build with gcc because the clang build fails some + # ansi-tests. See [#469]. + CONFIG: "x86_linux" # These rules is needed so that the static analyzer job can run on a # schedule because this is a prerequisite of the analyzer build. A # regular push or merge request does the normal stuff. @@ -171,7 +173,7 @@ linux:cross-build: - linux-4/lisp variables: # This must match the config used for the linux build! - CONFIG: "x86_linux_clang" + CONFIG: "x86_linux" needs: @@ -346,7 +348,10 @@ ubuntu:build: - job: ubuntu:install artifacts: true variables: - CONFIG: "x86_linux_clang" + # Build with gcc on Ubuntu 25.10. It produces a lisp than passes + # the ansi-tests. Clang seems to fail the ansi-tests WRITE.1, + # PRINT.1, and friends when cr_pow is used. + CONFIG: "x86_linux" ubuntu:test: <<: *unit_test_configuration ===================================== bin/run-unit-tests.sh ===================================== @@ -41,6 +41,11 @@ done # Shift out the options shift $((OPTIND - 1)) +# Create the test directory needed by the issue.45 test. +#rm -rf test-tmp +#mkdir test-tmp +#ln -s /bin/ls test-tmp/ls-link + # Set the timestamps on 64-bit-timestamp-2038.txt and # 64-bit-timestamp-2106.txt, but only for OSes where we know this # works. (This is so we don't an annoying error message from touch ===================================== src/lisp/irrat.c ===================================== @@ -202,13 +202,17 @@ lisp_log10(double x) double lisp_pow(double x, double y) { +#ifdef FEATURE_CORE_MATH /* - * cr_pow seems causes ansi-tests to fail in test WRITE.1 among - * others. Somewhere an invalid operation is occurring. Thus - * just use fdlibm for now until we can figure out what's causing - * the failure. + * cr_pow when compiled with older versions of gcc or clang can + * cause failures in the ansi-tests [#469]. Ubuntu 25.10 and Fedora 41 + * (gcc only) are known to have compilers that work well enough + * that the ansi-tests pass. */ + return cr_pow(x, y); +#else return __ieee754_pow(x, y); +#endif } double View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5b6d4d73d0748022cb160c… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5b6d4d73d0748022cb160c… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-469-enable-cr-pow] 4 commits: Minor cleanup of GNUMakefile
by Raymond Toy (＠rtoy) 06 Feb '26

06 Feb '26

Raymond Toy pushed to branch issue-469-enable-cr-pow at cmucl / cmucl Commits: 9a4f3d7e by Raymond Toy at 2026-02-04T08:06:20-08:00 Minor cleanup of GNUMakefile First, CORE64_OBJS is no longer defined, so don't use it. The CORE64_OBJS that used to name the .o files for core-math are now computed as part of OBJS. This removal also meant that the "clean" target no longer removed the core-math object files. Fix this by changing the rule to remove $(OBJS) instead of *.o. - - - - - f5a798b8 by Raymond Toy at 2026-02-05T17:51:48-08:00 Fix #470: Fix unit test issues on Ubuntu CI - - - - - 5b6d4d73 by Raymond Toy at 2026-02-05T17:51:48-08:00 Merge branch 'issue-470-ubuntu-ci-failures' into 'master' Fix #470: Fix unit test issues on Ubuntu CI Closes #470 See merge request cmucl/cmucl!348 - - - - - fb50ed76 by Raymond Toy at 2026-02-05T17:55:03-08:00 Merge branch 'master' into issue-469-enable-cr-pow - - - - - 0 changed files: Changes: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/ef6f16eca1f968af59a0e3… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/ef6f16eca1f968af59a0e3… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0