February 2026 - cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-468-core-math-signals] Clean up comments
by Raymond Toy (＠rtoy) 03 Feb '26

03 Feb '26

Raymond Toy pushed to branch issue-468-core-math-signals at cmucl / cmucl Commits: 730da685 by Raymond Toy at 2026-02-02T21:01:34-08:00 Clean up comments The comments about core-math not doing the right thing have been removed because core-math does the expected thing. - - - - - 1 changed file: - tests/fdlibm.lisp Changes: ===================================== tests/fdlibm.lisp ===================================== @@ -90,10 +90,8 @@ (define-test %acosh.exceptions (:tag :fdlibm) - ;; Core-math returns infinity instead of signaling overflow. (assert-error 'floating-point-overflow (kernel:%acosh ext:double-float-positive-infinity)) - ;; Core-math currently returns QNaN (assert-error 'floating-point-invalid-operation (kernel:%acosh 0d0)) (ext:with-float-traps-masked (:overflow) @@ -106,8 +104,6 @@ (:tag :fdlibm) (assert-error 'floating-point-invalid-operation (kernel:%asinh *snan*)) - ;; Core-math returns the signed infinity instead of signaling an - ;; overflow. (assert-error 'floating-point-overflow (kernel:%asinh ext:double-float-positive-infinity)) (assert-error 'floating-point-overflow View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/730da685588abfcad4b9329… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/730da685588abfcad4b9329… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-468-core-math-signals] 2 commits: Check for infinite arg for sin, cos, tan
by Raymond Toy (＠rtoy) 03 Feb '26

03 Feb '26

Raymond Toy pushed to branch issue-468-core-math-signals at cmucl / cmucl Commits: 1751d2c9 by Raymond Toy at 2026-02-02T20:51:58-08:00 Check for infinite arg for sin, cos, tan fdlibm signals overflow for infinite args for sin, cos, and tan. Do the same for core-math. Also add test that NaN is silently returned from sin, cos, and tan are given a quiet NaN. That's what fdlibm does. - - - - - 13291eab by Raymond Toy at 2026-02-02T20:58:39-08:00 Enable underflow test for exp(-1000d0) This tests passes with core-math, so enable it. - - - - - 2 changed files: - src/lisp/irrat.c - tests/fdlibm.lisp Changes: ===================================== src/lisp/irrat.c ===================================== @@ -43,6 +43,11 @@ double lisp_sin(double x) { #ifdef FEATURE_CORE_MATH + /* Signals invalid if x is infinite */ + if (isinf(x)) { + return fdlibm_setexception(x, FDLIBM_INVALID); + } + return cr_sin(x); #else return fdlibm_sin(x); @@ -53,6 +58,11 @@ double lisp_cos(double x) { #ifdef FEATURE_CORE_MATH + /* Signals invalid if x is infinite */ + if (isinf(x)) { + return fdlibm_setexception(x, FDLIBM_INVALID); + } + return cr_cos(x); #else return fdlibm_cos(x); @@ -63,6 +73,11 @@ double lisp_tan(double x) { #ifdef FEATURE_CORE_MATH + /* Signals invalid if x is infinite */ + if (isinf(x)) { + return fdlibm_setexception(x, FDLIBM_INVALID); + } + return cr_tan(x); #else return fdlibm_tan(x); ===================================== tests/fdlibm.lisp ===================================== @@ -214,7 +214,6 @@ (ext:with-float-traps-masked (:overflow) (assert-equal ext:double-float-positive-infinity (kernel:%exp 710d0))) - #-core-math (let ((modes (ext:get-floating-point-modes))) (unwind-protect (progn @@ -671,6 +670,14 @@ (define-test %cos.exceptions (:tag :fdlibm) + ;; cos(inf) signals invalid operation + (assert-error 'floating-point-invalid-operation + (kernel:%cos ext:double-float-positive-infinity)) + (assert-error 'floating-point-invalid-operation + (kernel:%cos ext:double-float-negative-infinity)) + ;; cos(nan) is NaN + (assert-true (ext:float-nan-p (kernel:%cos *qnan*))) + ;; cos(x) = 1 for |x| < 2^-27. Signal inexact unless x = 0 (let ((x (scale-float 1d0 -28)) (x0 0d0)) @@ -686,6 +693,14 @@ (define-test %sin.exceptions (:tag :fdlibm) + ;; sin(inf) signals invalid operation + (assert-error 'floating-point-invalid-operation + (kernel:%sin ext:double-float-positive-infinity)) + (assert-error 'floating-point-invalid-operation + (kernel:%sin ext:double-float-negative-infinity)) + ;; sin(nan) is NaN + (assert-true (ext:float-nan-p (kernel:%sin *qnan*))) + ;; sin(x) = x for |x| < 2^-27. Signal inexact unless x = 0 (let ((x (scale-float 1d0 -28)) (x0 0d0)) @@ -701,6 +716,14 @@ (define-test %tan.exceptions (:tag :fdlibm) + ;; tan(inf) signals invalid operation + (assert-error 'floating-point-invalid-operation + (kernel:%tan ext:double-float-positive-infinity)) + (assert-error 'floating-point-invalid-operation + (kernel:%tan ext:double-float-negative-infinity)) + ;; tan(nan) is NaN + (assert-true (ext:float-nan-p (kernel:%sin *qnan*))) + ;; tan(x) = x for |x| < 2^-28. Signal inexact unless x = 0 (let ((x (scale-float 1d0 -29)) (x0 0d0)) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5de13d334adb9a01c393af… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5de13d334adb9a01c393af… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-468-core-math-signals] 2 commits: Fix merge mistake
by Raymond Toy (＠rtoy) 03 Feb '26

03 Feb '26

Raymond Toy pushed to branch issue-468-core-math-signals at cmucl / cmucl Commits: 7dbd0bcd by Raymond Toy at 2026-02-02T20:26:55-08:00 Fix merge mistake Extra #endif was accidentally left in. - - - - - 5de13d33 by Raymond Toy at 2026-02-02T20:37:41-08:00 Check for infinite arg for %asinh Also enable overflow check for %asinh of neg infinity. - - - - - 2 changed files: - src/lisp/irrat.c - tests/fdlibm.lisp Changes: ===================================== src/lisp/irrat.c ===================================== @@ -148,6 +148,11 @@ double lisp_asinh(double x) { #ifdef FEATURE_CORE_MATH + /* Signal overflow if x is infinite */ + if (isinf(x)) { + return fdlibm_setexception(x, FDLIBM_OVERFLOW); + } + return cr_asinh(x); #else return fdlibm_asinh(x); @@ -223,7 +228,6 @@ lisp_pow(double x, double y) * the failure. */ return __ieee754_pow(x, y); -#endif } double ===================================== tests/fdlibm.lisp ===================================== @@ -110,7 +110,6 @@ ;; overflow. (assert-error 'floating-point-overflow (kernel:%asinh ext:double-float-positive-infinity)) - #-core-math (assert-error 'floating-point-overflow (kernel:%asinh ext:double-float-negative-infinity)) (assert-true (ext:float-nan-p (kernel:%asinh *qnan*))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/f055eed9555b420a07e70e… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/f055eed9555b420a07e70e… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-468-core-math-signals] 3 commits: Fix #434: Add support for correctly rounded double-precision math functions
by Raymond Toy (＠rtoy) 03 Feb '26

03 Feb '26

Raymond Toy pushed to branch issue-468-core-math-signals at cmucl / cmucl Commits: fdb86a06 by Raymond Toy at 2026-02-01T07:38:55-08:00 Fix #434: Add support for correctly rounded double-precision math functions - - - - - e3ec78e4 by Raymond Toy at 2026-02-01T07:38:55-08:00 Merge branch 'issue-425-correctly-rounded-math-functions' into 'master' Fix #434: Add support for correctly rounded double-precision math functions Closes #434, #426, and #425 See merge request cmucl/cmucl!312 - - - - - f055eed9 by Raymond Toy at 2026-02-02T20:22:35-08:00 Merge branch 'master' into issue-468-core-math-signals - - - - - 2 changed files: - src/lisp/irrat.c - tests/fdlibm.lisp Changes: ===================================== src/lisp/irrat.c ===================================== @@ -216,9 +216,12 @@ lisp_log10(double x) double lisp_pow(double x, double y) { -#ifdef FEATURE_CORE_MATH - return cr_pow(x, y); -#else + /* + * cr_pow seems causes ansi-tests to fail in test WRITE.1 among + * others. Somewhere an invalid operation is occurring. Thus + * just use fdlibm for now until we can figure out what's causing + * the failure. + */ return __ieee754_pow(x, y); #endif } ===================================== tests/fdlibm.lisp ===================================== @@ -110,6 +110,7 @@ ;; overflow. (assert-error 'floating-point-overflow (kernel:%asinh ext:double-float-positive-infinity)) + #-core-math (assert-error 'floating-point-overflow (kernel:%asinh ext:double-float-negative-infinity)) (assert-true (ext:float-nan-p (kernel:%asinh *qnan*))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/18b8d9171b420852756a33… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/18b8d9171b420852756a33… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-469-enable-cr-pow] Update comments in lisp_pow and .gitlab-ci.yml
by Raymond Toy (＠rtoy) 02 Feb '26

02 Feb '26

Raymond Toy pushed to branch issue-469-enable-cr-pow at cmucl / cmucl Commits: ef364c94 by Raymond Toy at 2026-02-02T13:21:36-08:00 Update comments in lisp_pow and .gitlab-ci.yml Ubuntu 25.10 works with gcc or clang. Fedora 41 only works with gcc. - - - - - 2 changed files: - .gitlab-ci.yml - src/lisp/irrat.c Changes: ===================================== .gitlab-ci.yml ===================================== @@ -147,6 +147,8 @@ linux:build: - job: linux:install artifacts: true variables: + # Fedora 41 must build with gcc because the clang build fails some + # ansi-tests. See [#469]. CONFIG: "x86_linux" # These rules is needed so that the static analyzer job can run on a # schedule because this is a prerequisite of the analyzer build. A @@ -346,7 +348,7 @@ ubuntu:build: - job: ubuntu:install artifacts: true variables: - # gcc can't compile the core-math routines. + # Ubuntu 25.10 can build with either gcc or clang and pass the ansi-tests. CONFIG: "x86_linux_clang" ubuntu:test: ===================================== src/lisp/irrat.c ===================================== @@ -204,10 +204,10 @@ lisp_pow(double x, double y) { #ifdef FEATURE_CORE_MATH /* - * cr_pow seems causes ansi-tests to fail in test WRITE.1 among - * others. Somewhere an invalid operation is occurring. Thus - * just use fdlibm for now until we can figure out what's causing - * the failure. + * cr_pow when compiled with older versions of gcc or clang can + * cause failures in the ansi-tests [#469]. Ubuntu 25.10 and Fedora 41 + * (gcc only) are known to have compilers that work well enough + * that the ansi-tests pass. */ return cr_pow(x, y); #else View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/ef364c944c8d8e4349f3dde… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/ef364c944c8d8e4349f3dde… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-469-enable-cr-pow
by Raymond Toy (＠rtoy) 01 Feb '26

01 Feb '26

Raymond Toy pushed new branch issue-469-enable-cr-pow at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-469-enable-cr-pow You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #434: Add support for correctly rounded double-precision math functions
by Raymond Toy (＠rtoy) 01 Feb '26

01 Feb '26

Raymond Toy pushed to branch master at cmucl / cmucl Commits: fdb86a06 by Raymond Toy at 2026-02-01T07:38:55-08:00 Fix #434: Add support for correctly rounded double-precision math functions - - - - - e3ec78e4 by Raymond Toy at 2026-02-01T07:38:55-08:00 Merge branch 'issue-425-correctly-rounded-math-functions' into 'master' Fix #434: Add support for correctly rounded double-precision math functions Closes #434, #426, and #425 See merge request cmucl/cmucl!312 - - - - - 42 changed files: - .gitlab-ci.yml - src/code/irrat.lisp - src/code/linux-os.lisp - src/compiler/x86/sse2-c-call.lisp - src/lisp/Config.x86_common - src/lisp/Config.x86_linux - src/lisp/GNUmakefile - + src/lisp/core-math/src/binary64/Makefile - + src/lisp/core-math/src/binary64/acos/acos.c - + src/lisp/core-math/src/binary64/acosh/acosh.c - + src/lisp/core-math/src/binary64/asin/asin.c - + src/lisp/core-math/src/binary64/asinh/asinh.c - + src/lisp/core-math/src/binary64/atan/atan.c - + src/lisp/core-math/src/binary64/atan2/atan2.c - + src/lisp/core-math/src/binary64/atan2/tint.h - + src/lisp/core-math/src/binary64/atanh/atanh.c - + src/lisp/core-math/src/binary64/cos/cos.c - + src/lisp/core-math/src/binary64/cosh/cosh.c - + src/lisp/core-math/src/binary64/exp/exp.c - + src/lisp/core-math/src/binary64/expm1/expm1.c - + src/lisp/core-math/src/binary64/hypot/hypot.c - + src/lisp/core-math/src/binary64/log/dint.h - + src/lisp/core-math/src/binary64/log/log.c - + src/lisp/core-math/src/binary64/log10/dint.h - + src/lisp/core-math/src/binary64/log10/log10.c - + src/lisp/core-math/src/binary64/log1p/log1p.c - + src/lisp/core-math/src/binary64/log2/log2.c - + src/lisp/core-math/src/binary64/pow/dint.h - + src/lisp/core-math/src/binary64/pow/pow.c - + src/lisp/core-math/src/binary64/pow/pow.h - + src/lisp/core-math/src/binary64/pow/qint.h - + src/lisp/core-math/src/binary64/sin/sin.c - + src/lisp/core-math/src/binary64/sincos/sincos.c - + src/lisp/core-math/src/binary64/sinh/sinh.c - + src/lisp/core-math/src/binary64/tan/tan.c - + src/lisp/core-math/src/binary64/tan/tan.wc - + src/lisp/core-math/src/binary64/tanh/tanh.c - src/lisp/irrat.c - src/lisp/sincos.c - tests/fdlibm.lisp - tests/irrat.lisp - tests/run-tests.lisp The diff was not included because it is too large. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/318d0560eea48e2dbac0b9… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/318d0560eea48e2dbac0b9… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0