iterate-devel

iterate-devel@common-lisp.net

271 discussions

Trying to fix the GitLab CI pipeline
by Robert Goldman 16 Dec '22

16 Dec '22

I have been trying to repair the GitLab CI, and I'm stuck on clasp. Whatever I try to do with clasp docker images -- and I've tried the clfoundation ones, the clasp-devel ones and even made one myself -- I get an error in the GitLab pipeline trying to start up the image. For example: ``` Using docker image sha256:5880b3b4b01af70bcf79360e28e2e9e6adbfe9599f6fc61b6815a9ebac6aea7c for rpgoldman/clasp-for-iterate:latest with digest rpgoldman/clasp-for-iterate@sha256:31d928fe1cd7e3419daf79610babe0a75d2aa7eddf34d85cc75d11831e302967 ... shell not found ``` See [this pipeline transcript](https://gitlab.common-lisp.net/rgoldman/iterate/-/jobs/42061) This is a *stellar* error message! ;-) Anyone know what it means? I did some googling, but no dice. I have tried firing up this image myself and then running `make test l=clasp` in it, and the test works fine. So it's something about the interaction between the docker image and GitLab but I have no idea WTF that could be. Any suggestions? Or do I just need to give up testing on clasp? I don't want to do that, but it seems a lot better to test iterate on n - 1 lisp implementations than to test it on zero implementations. Thanks!

2 2

How do people feel about making a release?
by Robert Goldman 09 Sep '21

09 Sep '21

I was thinking we could tag the current master as 1.6.0 and call it a release. I hate to leave people -- especially people who get their copy of iterate from quicklisp -- stuck using a version of iterate that has known bugs for which a fix has been committed. I would bump the current version number to 1.6.0 to indicate that there are new features but that we are backward-compatible. Note that we now warn on the use of `count`, but I would argue that emitting a warning isn't a true backwards incompatibility, and the new state of `iterate` doesn't seem to warrant calling it 2.0 Thoughts? Anyone even read this mailing list?

3 2

Re: Defining AVERAGING clause
by Russ Tyndall 14 Mar '18

14 Mar '18

I think the natural ordering of things means this wont be a problem in 99% of situations. Obviously you cant use mean until the finally clause, but all of your finally's should come after the averaging finally. (iterate:defmacro-clause (averaging expr &optional into var) (let ((avg (or var iterate::*result-var*))) (alexandria:with-unique-names (cnt sum) `(progn (with ,avg) (with ,sum = 0) (with ,cnt = 0) (incf ,cnt) (incf ,sum ,expr) (finally (setf ,avg (if (plusp ,cnt) (/ ,sum ,cnt) 0)) ))))) (iter (for i from 0 to 100) (averaging i into mean) (finally (return mean))) => 50 Expands to: (LET* ((I NIL) (MEAN NIL) (#:SUM4008 0) (#:CNT4007 0)) (BLOCK NIL (TAGBODY (PROGN (SETQ I -1)) LOOP-TOP-NIL (PROGN (SETQ I (+ I 1)) (IF (> I 100) (GO LOOP-END-NIL)) (PROGN (SETQ #:CNT4007 (+ 1 #:CNT4007)) (SETQ #:SUM4008 (+ I #:SUM4008)))) (PROGN) (GO LOOP-TOP-NIL) LOOP-END-NIL (PROGN (SETF MEAN (IF (PLUSP #:CNT4007) (/ #:SUM4008 #:CNT4007) 0)) (RETURN MEAN))) NIL)) Cheers, Russ Tyndall Acceleration.net ----- Original Message ----- From: Robert Goldman [mailto:rpgoldman@sift.info] To: russ(a)acceleration.net Cc: iterate-devel(a)common-lisp.net Sent: Tue, 13 Mar 2018 12:27:47 -0500 Subject: Re: Defining AVERAGING clause Wouldn't this technique have trouble with code movement issues? For example, if I have ``` (iter (for x in data-table) (averaging x into mean) (finally (return mean))) ``` I know that's a contrived example, but I think the point is clear: if I'm going to make `averaging` a collector, I'd like to be able to use its result, and if that result is computed in a `finally` block that's invisible and out of my control, I can't do it, can I? There's `finally-protected`, but I think that's the *opposite* of what I need. Best, r On 13 Mar 2018, at 10:08, Russ Tyndall wrote: > Here is an existing "sampling" clause to pull a random sample from a > larger data set. The long and short is just use a finally clause, as > you would when writing a normal iterate loop. > > (iterate:defmacro-clause (sampling expr &optional into var size size) > "resevoir sample the input" > (let ((sample (or var iterate::*result-var*))) > (alexandria:with-unique-names (i sample-size sigil buffer row) > `(progn > (with ,sample) > (with ,sample-size = (or ,size 100)) > (with ,buffer = (make-array ,sample-size > :initial-element ',sigil)) > (with ,i = 0) > (if (< ,i ,sample-size) > (setf (aref ,buffer ,i) ,expr) > (let ((r (random ,i))) > (when (< r ,sample-size) > (setf (aref ,buffer r) ,expr)))) > (incf ,i) > (finally > ;; convert our sample to a list, but only if we > actually took the sample > (when (plusp ,i) > (setf ,sample > (iter (for ,row in-vector ,buffer) > (until (eq ,row ',sigil)) > (collect ,row))))))))) > > Cheers, > Russ Tyndall > Acceleration.net > On 03/13/2018 10:49 AM, Robert Goldman wrote: >> >> I was going to define an |AVERAGING| collector clause for iterate, >> but I'm not sure how to do it. The obvious thing, it seemed to me, >> would be to sum the values as I go along, and count them, and then >> divide the sum by the count when leaving the loop. >> >> But the examples for |DEFMACRO-CLAUSE| in the manual do all of their >> work while iterating, and there doesn't seem to be an "at-end" hook. >> Is the kind of thing I would like feasible, and if so, how is it to >> be done? >> >> thanks! >> r >>

2 1

Defining AVERAGING clause
by Robert Goldman 13 Mar '18

13 Mar '18

I was going to define an `AVERAGING` collector clause for iterate, but I'm not sure how to do it. The obvious thing, it seemed to me, would be to sum the values as I go along, and count them, and then divide the sum by the count when leaving the loop. But the examples for `DEFMACRO-CLAUSE` in the manual do all of their work while iterating, and there doesn't seem to be an "at-end" hook. Is the kind of thing I would like feasible, and if so, how is it to be done? thanks! r

3 5

Fwd: Please create a new release of source code archive
by Attila Lendvai 07 Feb '18

07 Feb '18

is there someone who knows how to make a release, and/or is willing to do one? ---------- Forwarded message ---------- From: Einstok Fair <einfair(a)zoho.eu> Date: Sat, Jan 27, 2018 at 11:40 PM Subject: Please create a new release of source code archive To: attila.lendvai(a)gmail.com Hello, I found your email in the output of $ darcs log patch 8e3164ce4db2468289cd426aa8a791d809df62ea Author: attila.lendvai(a)gmail.com Date: Tue Jan 23 18:39:55 MSK 2018 * more tests for the :previous bug I want to ask you to create a new source archive for this project. The previous one https://common-lisp.net/project/iterate/releases/ iterate-1.4.3.tar.gz 2006-05-06 15:55 285K was released 12 years ago. It is time to publish a new release. There is also a reason - that version 1.4.3 doesn't work with new sbcl 1.3.18 Thanks.

2 2

Re: Test status
by Robert Goldman 25 Jan '18

25 Jan '18

On 24 Jan 2018, at 16:55, Ilya Perminov wrote: > The latest SBCL (1.4.3) on Linux gives 2 failues: > ITERATE.TEST::BUG/WALK.2 and ITERATE.TEST::BUG/COLLECT-AT-BEGINNING. Hm. According to Attila, you should have 5 failures (which is what I have): ``` 5 out of 268 total tests failed: ITERATE.TEST::ALWAYS.FINALLY, ITERATE.TEST::NEVER.FINALLY, ITERATE.TEST::THEREIS.FINALLY, ITERATE.TEST::BUG/WALK.2, ITERATE.TEST::BUG/COLLECT-AT-BEGINNING ``` ...and it seems like there's something wrong so that I get three additional failures on Allegro. Probably don't have time to look into this now. Best, r

3 4

Re: Test status
by Robert Goldman 24 Jan '18

24 Jan '18

I think that must be using an older version of iterate, in quicklisp, because the latest version has `iterate/tests` instead (as it should). Best, r On 24 Jan 2018, at 17:12, Patrick Stein wrote: > I was going to recommend referring to cl-test-grid, but it seems that > testgrid cannot locate the iterate-tests system. > > https://common-lisp.net/project/cl-test-grid/library/iterate.html > > -- Patrick <pat(a)nklein.com> > >> On Jan 24, 2018, at 4:38 PM, Robert Goldman <rpgoldman(a)sift.info> >> wrote: >> >> On 24 Jan 2018, at 16:17, Ilya Perminov wrote: >> >> >> I think the warings are expected. A note just above them says "Note: >> These tests generate warnings involving MACROLET within Iterate". >> I am not sure why our test results are different. Maybe my SBCL >> version is too old, I'll try the latest one. >> >> Looks like these 5 failures are what I should be expecting. At the >> top of iterate-test.lisp I find this: >> >> ;; This is here to document which tests are failing at the time of >> ;; writing. It's not used directly here, but the tests of the >> ;; iterate-compat package of hu.dwim.reiterate expect it. >> (defvar *tests-expected-to-fail* >> '(always.finally >> never.finally >> thereis.finally >> bug/walk.2 >> bug/collect-at-beginning >> )) >> That suggests that the errors in code-movement.finally, >> code-movement.finally-protected and code-movement.else are unique to >> ACL and are not expected to fail. >> >> I'll try to make time to have a look at what is going on there. >> >> Best, >> r

1 0

Re: Test status
by Robert Goldman 24 Jan '18

24 Jan '18

On 24 Jan 2018, at 15:39, Ilya Perminov wrote: > Hi Robert, > > To "revert" my patch manually just revert this change: > > --- old-iterate/iterate.lisp 2018-01-15 16:49:24.171636397 -0800 > +++ new-iterate/iterate.lisp 2018-01-15 16:49:24.171636397 -0800 > @@ -3374,7 +3374,7 @@ > (if (not (and (integerp n) (> n 0))) > (clause-error "~a should be a positive integer" n-expr) > ;; Here, n is a positive integer. > - (let* ((p-i (intern-previous-info var)) > + (let* ((p-i (intern-previous-info var :next)) > (init-val (make-initial-value default default? (var-type > var))) > (temp (if (not (duplicable? init-val)) > (make-var-and-default-binding > > i.e. remove :next from (intern-previous-info var :next). > I only tested my patch on SBCL 1.3.0 and it did not break any tests. > The BUG > tests failed, but everything else passed. > > Ilya On MacOS, with SBCL 1.3.14, I get 5 failures: ``` 5 out of 268 total tests failed: ITERATE.TEST::ALWAYS.FINALLY, ITERATE.TEST::NEVER.FINALLY, ITERATE.TEST::THEREIS.FINALLY, ITERATE.TEST::BUG/WALK.2, ITERATE.TEST::BUG/COLLECT-AT-BEGINNING.; ``` I also see this: ``` ; caught STYLE-WARNING: ; undefined function: ITERATE:MULTIPLYING ; ; compilation unit finished ; Undefined function: ; ITERATE:MULTIPLYING ; caught 1 ERROR condition ; caught 1 WARNING condition ; caught 1 STYLE-WARNING condition ``` This is from loading the test system -- iterate itself loads without problems. I'm not sure why this happens: I see this: ``` iterate.lisp 2872:(defsynonym multiplying multiply) ``` and `multiplying` seems to be exported from package.lisp. The error occurs in `bug/macrolet.2` One thing I don't understand -- the test suite seems to use `:SB-RT` on SBCL, which is *not* the same as the `RT` package. Any idea what's going on here? Definitely caused me some confusion as a not-normally-SBCL user.

2 4

Test status
by Robert Goldman 24 Jan '18

24 Jan '18

I was just testing out the version of ITERATE with Ilya's new fixes. Question: what do we expect to happen when `ASDF:TEST-SYSTEM` is run on iterate? I see 8 test failures, on ACL 10.1, as follows: ``` 8 out of 267 total tests failed: ITERATE.TEST::ALWAYS.FINALLY, ITERATE.TEST::NEVER.FINALLY, ITERATE.TEST::THEREIS.FINALLY, ITERATE.TEST::CODE-MOVEMENT.ELSE, ITERATE.TEST::CODE-MOVEMENT.FINALLY, ITERATE.TEST::CODE-MOVEMENT.FINALLY-PROTECTED, ITERATE.TEST::BUG/WALK.2, ITERATE.TEST::BUG/COLLECT-AT-BEGINNING. ``` Is there some way for us to tell whether this is a regression, or if these are all known issues? I figure the tests prefixed with `BUG/` are probably known failures, but what about the other 6? Would it be possible to put a list of canonical test results on the iterate project page? Thanks!

1 1

Bug: (for X previous Y ...) does not check existence of Y
by Ilya Perminov 16 Jan '18

16 Jan '18

Hello, Iterate silently ignores "for ... previous" clauses that reference undefined variables, e.g, (iter (repeat 2) (for x previous y initially 0) (collect x)) returns (0 0). A patch to fix the bug is attached. Can someone apply it please. Thanks, Ilya

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

iterate-devel