Another syntax error in the new PS. This form:
(let ((blah (let ((x (foo))) (if (null x) y z)))))
... compiles to...
var blah = x = foo(), x == null ? y : z;
... which is incorrect. Previously, PS produced this, which is correct:
var blah = (x = foo(), x == null ? y : z);
Daniel
I have also encountered this problem. Enclosed is a patch, with an additional fix to a similar issues inside arefs/arrays.
I hope the patches are acceptable (don't know git well enough). I would prefer for them to not depend on my other patches from a few days ago. Will they still merge ok?
Yong.
On 5/4/10, Daniel Gackle danielgackle@gmail.com wrote:
Another syntax error in the new PS. This form:
(let ((blah (let ((x (foo))) (if (null x) y z)))))
... compiles to...
var blah = x = foo(), x == null ? y : z;
... which is incorrect. Previously, PS produced this, which is correct:
var blah = (x = foo(), x == null ? y : z);
Daniel
< Will they still merge ok? >
I believe that when you format patches this way, git will apply them as long as the surrounding context matches what is in the patch. (If I'm wrong about this, somebody please correct me!)
Daniel
On Fri, May 14, 2010 at 2:58 AM, szergling senatorzergling@gmail.comwrote:
I have also encountered this problem. Enclosed is a patch, with an additional fix to a similar issues inside arefs/arrays.
I hope the patches are acceptable (don't know git well enough). I would prefer for them to not depend on my other patches from a few days ago. Will they still merge ok?
Yong.
On 5/4/10, Daniel Gackle danielgackle@gmail.com wrote:
Another syntax error in the new PS. This form:
(let ((blah (let ((x (foo))) (if (null x) y z)))))
... compiles to...
var blah = x = foo(), x == null ? y : z;
... which is incorrect. Previously, PS produced this, which is correct:
var blah = (x = foo(), x == null ? y : z);
Daniel
parenscript-devel mailing list parenscript-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/parenscript-devel
Hi Yong,
Thanks a lot for the patches, they were spot on for fixing the problem and had new tests!
Git did have to change them when merging because of patches I had committed earlier, so they may cause conflicts for your local repository (even though they look like the same patches).
Vladimir
2010/5/14 szergling senatorzergling@gmail.com:
I have also encountered this problem. Enclosed is a patch, with an additional fix to a similar issues inside arefs/arrays.
I hope the patches are acceptable (don't know git well enough). I would prefer for them to not depend on my other patches from a few days ago. Will they still merge ok?
Yong.
On 5/4/10, Daniel Gackle danielgackle@gmail.com wrote:
Another syntax error in the new PS. This form:
(let ((blah (let ((x (foo))) (if (null x) y z)))))
... compiles to...
var blah = x = foo(), x == null ? y : z;
... which is incorrect. Previously, PS produced this, which is correct:
var blah = (x = foo(), x == null ? y : z);
Daniel
parenscript-devel mailing list parenscript-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/parenscript-devel
parenscript-devel@common-lisp.net
-
Daniel Gackle -
szergling -
Vladimir Sedach